Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp513069rdh; Sat, 23 Sep 2023 23:12:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPJadMcf1b21jLyMepNrivJhVcaSSbAn11ItwJktNjdTXknBrMAN1IJ38pxpH7xEoXDzMM X-Received: by 2002:a05:6870:17a7:b0:1bb:4606:5be with SMTP id r39-20020a05687017a700b001bb460605bemr5228121oae.9.1695535970898; Sat, 23 Sep 2023 23:12:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695535970; cv=none; d=google.com; s=arc-20160816; b=gwXPPDIZOHt9nFNh0BCj05vXYl18vVSV2tMhZl6ZdY31Pgwnc+r2kw80MdMGNYtwRy WcCQWc2oF+zuZxyI8cOztNkBn183sQ9GzEJKaiq2B1f4szzF4HLpnDR9Z+sVIVWeOp/x o7zbMhPLObzleDEocS/lgxkcTN26cmRWGZ/YXxB3HDx31jxh6lit11k9byqDzflntW5W KWUSidO/x+eBUK+PoS3ugJdlanGjcy2zguKBHxYRFRyXwCgeNHY4ImXVAZi3ayIWjbkv Vkv3bHpN2m5OZl4wfXEQ9UELo7IBs+7uKI84NVFkJ5F+2hy7QhJRv9kuJjyJUkQ9AdaW 8BEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=4lp4rqH/fgRa84q4bZqMK+Guj4Ezv52nETpih6zUjHw=; fh=qMYihroPsTfixFEshGCad8B/B7thdUexrs9evmlGtGs=; b=lCtjGCYmykvig2ojS3ysz3bRuXUsQVCX9DoP1o7rEolr5C4gvWb/3e52qjbcyZLRBn A+KXlZIUBE/JvsaFZD+fKwXRacO5KPSRbC9B/E7tjEnnkH7VSzGIw3DZcoRTNZ3H9gii rsfm+WPsJLSUVkxyJFXtx0lusP/iKS3tbV6GqxokdwkPEVOROG7Bw53Y8kgNTZNG24AL N+YiPa+zZBb9BX7zeSJGqDrlHUUGE8AEULVQni5esCHLLm0Y/IChWtjYIJxF6pt7qrtP RQv5Yw4v19h0qCjjRWuwfY58dwxtyntzy9ZrajEUEk3MVW25hbeyKU+8/5d1XDXXBrNB t74A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g4VrMnol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id 36-20020a631564000000b00565617189e2si7233976pgv.839.2023.09.23.23.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 23:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g4VrMnol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A7C4982DDFA0; Sat, 23 Sep 2023 11:47:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbjIWSrA (ORCPT + 99 others); Sat, 23 Sep 2023 14:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbjIWSq7 (ORCPT ); Sat, 23 Sep 2023 14:46:59 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 615FE113 for ; Sat, 23 Sep 2023 11:46:53 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-59c0281d72dso48093707b3.0 for ; Sat, 23 Sep 2023 11:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695494812; x=1696099612; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4lp4rqH/fgRa84q4bZqMK+Guj4Ezv52nETpih6zUjHw=; b=g4VrMnolXzD3zZ/0E3hR5BnbLkuZjMaD1irOZCK12IoTEQj0MIAzyve9urHYgKOa7n N6rkJud2y3ByiVfC92uNHkx8QxZ/1ElbYVldJd93515TU4Dl5kSl09Q9pwtpXhAoutj9 OEbxFT3Eakp7MR/vXLhmASurDX8SRWDYHcBbA+KtC7k7LNkBj2IcyjUmBqBDezUHFqsi WnoGzEzGzq6Enn56jx7Flx33DHyEGP7YvqRnAONHz4WWD0UVUk8S/MoSeeb3L0o5RRQz 7bfnHFnPwbhJKCknOLN8IyH1iB/Jk+rTM3dmQeszmjH93xBgFJ9zyb82S3aPttejwtWi PwjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695494812; x=1696099612; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4lp4rqH/fgRa84q4bZqMK+Guj4Ezv52nETpih6zUjHw=; b=hXu8ye50QE+p+RUn0T9J7nwxL1XGloUURjjRoRQ7G74JOmV/j9aa15TnSGzBGfoDud pKYV5qw4W/91ug0jYqr+y7byUaCyhWXVc15aBvkf87bnDyvZBGgjKtxWbGv3uyC0T2mR vvib0DCGv6xXuVqy1OhBE11Rn+2uR1klkYw4A5Hpt1zquipNn9Z8eRH3upqD5y+BKdXt yhbwAW60MzbFDrjp8oP6uCtLnQeu9RrZcmesYeNmAy6rsA0rrzIU1Hl5vvdZP+uRNrOI hQSvbpgj5GJI7MEXJU9nJDM2EukDKA8CWe63/NuI2ZrFmiCOhWfqXn+aQl2Ai4GbfIgl FHEQ== X-Gm-Message-State: AOJu0YzNmvDLKFxcbv7uDUK6euCODr/dZdCyND03wENsX7BioBraGSzg yPUVKO81bf985dcybpqGEtKjofq6tTB2wbkQRYvSeA== X-Received: by 2002:a05:690c:4483:b0:59f:5361:d18c with SMTP id gr3-20020a05690c448300b0059f5361d18cmr2072246ywb.41.1695494812564; Sat, 23 Sep 2023 11:46:52 -0700 (PDT) MIME-Version: 1.0 References: <20230922115116.2748804-1-srichara@win-platform-upstream01.qualcomm.com> <20230922115116.2748804-4-srichara@win-platform-upstream01.qualcomm.com> In-Reply-To: <20230922115116.2748804-4-srichara@win-platform-upstream01.qualcomm.com> From: Dmitry Baryshkov Date: Sat, 23 Sep 2023 21:46:41 +0300 Message-ID: Subject: Re: [PATCH V3 3/4] thermal/drivers/tsens: Add support for IPQ5018 tsens To: Sricharan R Cc: krzysztof.kozlowski@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, quic_srichara@quicinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sat, 23 Sep 2023 11:47:06 -0700 (PDT) X-Spam-Level: ** On Fri, 22 Sept 2023 at 14:51, Sricharan R wrote: > > From: Sricharan Ramabadhran > > IPQ5018 has tsens IP V1.0, 4 sensors and 1 interrupt. > The soc does not have a RPM, hence tsens has to be reset and > enabled in the driver init. Adding the driver support for same. > > Signed-off-by: Sricharan Ramabadhran > --- > [v3] Fixed Dmitry's comments for error checks in init_ipq5018 > > drivers/thermal/qcom/tsens-v1.c | 60 +++++++++++++++++++++++++++++++++ > drivers/thermal/qcom/tsens.c | 3 ++ > drivers/thermal/qcom/tsens.h | 2 +- > 3 files changed, 64 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry