Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp685328rdh; Sun, 24 Sep 2023 07:27:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHN+/eUvs2+BmINB4Lgeo9biMMB5oxt3yNMB0CDMQMKXslcNPA+c/Y3YgKoSqrtrvjui57p X-Received: by 2002:a05:6a20:3248:b0:13e:7d3:61d1 with SMTP id hm8-20020a056a20324800b0013e07d361d1mr4936262pzc.12.1695565657969; Sun, 24 Sep 2023 07:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695565657; cv=none; d=google.com; s=arc-20160816; b=zdsrmgkvxsq4V0plowhVz5lmkd7FWdic6OK0pZO09X0XPwl2yzlh1lQhC4yJ49mWOo DT+vbJSw7pjLrvIgAmSx0VfhiVHEumYtWgY39TLb7FnJ2czPbzlYQ+mmxJrIPlCtiWXb dwiIONBqV8IwLUgVjXJuu/V/bAngbc0kds8zTC1W29c74jh4K8PQtkQK+nZ3ItaxCABW lCjZadjR6l3Jewi7QucaljqrAA1rHXcu5WiEJAoM3R3Pf8et6gbLT924cOI+M4VNH2Rv fH9c+Hw/c2YQDSOKF//0M6RAelvC2lgP1YDmBwjM6k74FovwR4njVplKxFq7BZrqqCBf 4zOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=bTCoYBjr017l6wFXONnZTUqQscIlTsYc71hdwazXlvU=; fh=rX4W9uLyqRejidHviTDjxqCNRkF4Il6G7Gq3yPcXR+U=; b=f2RcB/oErio61aUlcFVHNR5Gk5PmsNKV6oH9gM3/6a++bHQTFkB9ULm12dmeV7LGVV /8Ew6258LOAsiX2oTnUJQtvtiNTtP+tg1FYdi8vgCr5RrzvCxoMYk3pqj6QwQzVN40sd /TWvq7xYBY6a6EiVHjS4K2oL32yCKnAxURPFDFuMiZAs/8bBh+hZ7sLapoXR7TU9Wa47 dH+AuDrGmCao5YLMPYhx5oAnZCLosfbf3MaASVvjzPnFDwlvzdnkW31rWKaZTDEUKZZw cdZ8zlE9eCnfbvT4NEEXCo5mZm3T/x5g+hG7Pvov5OWiTsFJuuS5yHK8HarNSyDEVc+m HNtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gUGAWIfW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id oc10-20020a17090b1c0a00b0027652755c21si470183pjb.142.2023.09.24.07.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 07:27:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gUGAWIfW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 481F6809340F; Sun, 24 Sep 2023 07:27:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229837AbjIXO1g (ORCPT + 99 others); Sun, 24 Sep 2023 10:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbjIXO1e (ORCPT ); Sun, 24 Sep 2023 10:27:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D333CFC; Sun, 24 Sep 2023 07:27:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7765CC433CD; Sun, 24 Sep 2023 14:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695565648; bh=bTCoYBjr017l6wFXONnZTUqQscIlTsYc71hdwazXlvU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gUGAWIfW7vC1NooiXlxXAW77CGrUMiNfl1d0Cb+Ur1u6pV9vKzFjnH/HrDXCQPWpz VzQhp79Iu77tCMpohvzqwhU2VI6jFcTxIl/PwmgQ/zqrNiGUG5qfp5VPuAEfVezs98 3JuLWuvfWl/1R0GAoVToJO3SKOdkdJ68ol7Yk4vODF97IuaSALUuTCxXSPBNEin0jO Uxy2F55OVFSNNiLGrA7Sy+pLvTK3RAka01exn8c0wABlLEzPyTKFwC7xju9Cj3sqOJ KNmno5TjgU1f3Ab9oAHE4z2RHFYTqAfnWTtwjjlz/nm/HbFxIvZgYnHc8dnRdf2+sA Cqd5Eki0be9Lg== Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2c12fc235fbso56150171fa.0; Sun, 24 Sep 2023 07:27:28 -0700 (PDT) X-Gm-Message-State: AOJu0YyemvH/kfC2Sd1cNrULgtVy+CLzTF922+gZLnFQ5e8Jix7Rzugy azwSLQbpeJNIRjyMHjWnqZJQaAtM4bO7C5Ij6A== X-Received: by 2002:a2e:b81c:0:b0:2c0:b37:a1cf with SMTP id u28-20020a2eb81c000000b002c00b37a1cfmr2571604ljo.22.1695565646665; Sun, 24 Sep 2023 07:27:26 -0700 (PDT) MIME-Version: 1.0 References: <20230914131058.2472260-1-jani.nikula@intel.com> <20230914155317.2511876-1-jani.nikula@intel.com> <87cyyetohx.fsf@intel.com> <87o7huo840.fsf@intel.com> In-Reply-To: <87o7huo840.fsf@intel.com> From: Chun-Kuang Hu Date: Sun, 24 Sep 2023 22:27:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection To: Jani Nikula Cc: Chen-Yu Tsai , dri-devel@lists.freedesktop.org, Chun-Kuang Hu , Guillaume Ranquet , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Markus Schneider-Pargmann , Bo-Chen Chen , linux-mediatek@lists.infradead.org, Dmitry Osipenko , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 24 Sep 2023 07:27:35 -0700 (PDT) Hi, Jani: Jani Nikula =E6=96=BC 2023=E5=B9=B49=E6=9C=8822=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=885:44=E5=AF=AB=E9=81=93=EF=BC=9A > > On Tue, 19 Sep 2023, Chen-Yu Tsai wrote: > > On Tue, Sep 19, 2023 at 7:02=E2=80=AFPM Jani Nikula wrote: > >> > >> On Fri, 15 Sep 2023, Chen-Yu Tsai wrote: > >> > On Thu, Sep 14, 2023 at 11:53=E2=80=AFPM Jani Nikula wrote: > >> >> > >> >> The sads returned by drm_edid_to_sad() needs to be freed. > >> >> > >> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195") > >> >> Cc: Guillaume Ranquet > >> >> Cc: Bo-Chen Chen > >> >> Cc: AngeloGioacchino Del Regno > >> >> Cc: Dmitry Osipenko > >> >> Cc: Chun-Kuang Hu > >> >> Cc: Philipp Zabel > >> >> Cc: Matthias Brugger > >> >> Cc: dri-devel@lists.freedesktop.org > >> >> Cc: linux-mediatek@lists.infradead.org > >> >> Cc: linux-kernel@vger.kernel.org > >> >> Cc: linux-arm-kernel@lists.infradead.org > >> >> Cc: # v6.1+ > >> >> Signed-off-by: Jani Nikula > >> > > >> > Looks correct to me. > >> > > >> > Reviewed-by: Chen-Yu Tsai > >> > >> Thanks for the reviews Chen-Yu and Guillaume. Will you push this to > >> drm-misc-next or shall I? > > > > Patches for the MediaTek drm driver go through their own separate tree, > > maintained by CK (Chun-Kuang). > > Chun-Kuang, can you confirm picking up these two patches, please? > > MAINTAINERS does not list a separate git repository for MediaTek drm > drivers, so I don't know where that would be. It should probably be > added to MAINTAINERS. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/= log/?h=3Dmediatek-drm-next Regards, Chun-Kuang. > > Thanks, > Jani. > > > > > ChenYu > > -- > Jani Nikula, Intel