Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Sun, 24 Sep 2023 15:50:32 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     alisadariana@gmail.com
Cc:     Alisa-Dariana Roman <alisa.roman@analog.com>,
        stable@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Alexandru Tachici <alexandru.tachici@analog.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7192: Correct reference voltage
Message-ID: <20230924155019.1675a37d@jic23-huawei>
In-Reply-To: <20230923225827.75681-1-alisadariana@gmail.com>
References: <20230923225827.75681-1-alisadariana@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 24 Sep 2023 01:58:27 +0300
alisadariana@gmail.com wrote:

> From: Alisa-Dariana Roman <alisadariana@gmail.com>
> 
> The avdd and the reference voltage are two different sources but the
> reference voltage was assigned according to the avdd supply.
> 
> Add vref regulator structure and set the reference voltage according to
> the vref supply from the devicetree.
> 
> In case vref supply is missing, reference voltage is set according to
> the avdd supply for compatibility with old devicetrees.
> 
> Fixes: b581f748cce0 ("staging: iio: adc: ad7192: move out of staging")
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> Cc: stable@vger.kernel.org

Looks good but I'd prefer dev_err_probe() for the error messages.
Obviously that wasn't true for the existing one but as we are touching the
code good to clean it up.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad7192.c | 31 +++++++++++++++++++++++++++----
>  1 file changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 69d1103b9508..c414fed60dd3 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -177,6 +177,7 @@ struct ad7192_chip_info {
>  struct ad7192_state {
>  	const struct ad7192_chip_info	*chip_info;
>  	struct regulator		*avdd;
> +	struct regulator		*vref;
>  	struct clk			*mclk;
>  	u16				int_vref_mv;
>  	u32				fclk;
> @@ -1008,10 +1009,32 @@ static int ad7192_probe(struct spi_device *spi)
>  	if (ret)
>  		return dev_err_probe(&spi->dev, ret, "Failed to enable specified DVdd supply\n");
>  
> -	ret = regulator_get_voltage(st->avdd);
> -	if (ret < 0) {
> -		dev_err(&spi->dev, "Device tree error, reference voltage undefined\n");
> -		return ret;
> +	st->vref = devm_regulator_get_optional(&spi->dev, "vref");
> +	if (IS_ERR(st->vref)) {
> +		if (PTR_ERR(st->vref) != -ENODEV)
> +			return PTR_ERR(st->vref);
> +
> +		ret = regulator_get_voltage(st->avdd);
> +		if (ret < 0) {
> +			dev_err(&spi->dev, "Device tree error, AVdd voltage undefined\n");
dev_err_probe()

> +			return ret;
> +		}
> +	} else {
> +		ret = regulator_enable(st->vref);
> +		if (ret) {
> +			dev_err(&spi->dev, "Failed to enable specified Vref supply\n");
dev_err_probe()
> +			return ret;
> +		}
> +
> +		ret = devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, st->vref);
> +		if (ret)
> +			return ret;
> +
> +		ret = regulator_get_voltage(st->vref);
> +		if (ret < 0) {
> +			dev_err(&spi->dev, "Device tree error, Vref voltage undefined\n");
dev_err_probe()

> +			return ret;
> +		}
>  	}
>  	st->int_vref_mv = ret / 1000;
>