Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp776175rdh; Sun, 24 Sep 2023 11:11:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA3UT0NA7+kfIqTAWCPv2RVpstT/xFrkwbSWzvZV5rn6H//olItnUvNBARLjSH6EFaI3eb X-Received: by 2002:a05:6a00:150b:b0:68b:c562:da65 with SMTP id q11-20020a056a00150b00b0068bc562da65mr3995094pfu.26.1695579100603; Sun, 24 Sep 2023 11:11:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695579100; cv=none; d=google.com; s=arc-20160816; b=hvUAvevx05P0XKsLeOuZzplK1brGPmv8tVXVfv/PjA130PQ2Uws6W8ttGCdfMHmrow x/OUgzp8nRvCwv3TMd6TJoMUvjzy7EnluzSnQo2PaHhM1dkgBGRfFFpptdkkcnOncafa EDM9lsEoa0OKlIDiZKX1ZbmYkzuYsFqC3W71rJANTqt43iBYyVxHyft6/CDZfOJ+xokj DOMFUZ9GH5D9tc4PTtqUh8Amo/uxgNq+Nunwq72VooXI9RaFUr1VBb6KodAt2LQQyvkq fRRYbW+6gCcPI2ZxyEuzONLdL1rf8d19cQ5ugRux5mC+fcoB+p2DxC8xEOIcCLtQonlu bggQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=jjuPWxrjFjzVcGySiH2Cg30pGMzs4U4vJzq6n98JO1E=; fh=J/aQ3VQ1usFn2OiUKgsoebtsI6yr0VQFLqFjqmvpq44=; b=u/mLEGQ+O3YuhxlL4xLSjHtw5/DaIvzjLlV/C8rPC8Cl2SsIXBJ7ALnBWzh4O2PF23 y1e9VbjXLJ083KcNuKqnvbwz0d1AVaN7SPCPESS9XBgXzQ43DPebKBPaGy6cuOIDSH2N 6F8U73YQ0IjMLALuUKYZTq7TTNocIlQ5aS6RqT2fHBqCLHwM8PpGQ2NWUsy30zMmfWjq 6ZtQZYyxvjokOnXpWd6tsCzm7KHzEGvFMMhn3td7oNxhUqx/bZGFJCsd9xxSHlh8u0tG nkikb2rGHzEOxDk21xuXRDjyG6Iea4J+jFIw97I+ngGDu7hgLjpHFRTtIac8LbfSrk0z 0nvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f2WS1Q4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b20-20020a656694000000b00577f59c8a12si7736136pgw.847.2023.09.24.11.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 11:11:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f2WS1Q4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 57DA5807CB6A; Sun, 24 Sep 2023 11:10:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230274AbjIXSKs (ORCPT + 99 others); Sun, 24 Sep 2023 14:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjIXSKr (ORCPT ); Sun, 24 Sep 2023 14:10:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD953FE; Sun, 24 Sep 2023 11:10:41 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5104C433C7; Sun, 24 Sep 2023 18:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695579041; bh=tYGxKVpxb7PZ2YIh2JBJHjxiM1XOyE8essbNsK2nP68=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f2WS1Q4Xi3Sodin4WDSptsS62GVbZdwRevbbVH+XhFjLBEY9hyCt4a0CzWDfYFIq7 1bjclmrMnQPEdvDl7UdRRkVfj2HU8Sd0YhqaHtg21Cft/nBXxzIh8wMfe9bxSTT0oy LALiG0kxaChjgrCxA3Ix65QPf3i5x7h+rVh6Wo/7WcvSmLLt3L1l1QgGpJ5+uZ9VZe J9JcX+Z+2SH9VQQXraT2Q6HqXWDirP4kd9i/ujpXA6oKGi8WDYDvGOshy6PDYZ6E48 W1WCxoi3eL1GbNCMQphcbD7KuFQsEDg3m2dSNzqdjhX2lDPFSmkA5cfq/5fhf/ovBD SV0GjfufZIdDA== Date: Sun, 24 Sep 2023 19:10:32 +0100 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Axel Haslam , Philip Molloy Subject: Re: [PATCH v2 17/19] staging: iio: resolver: ad2s1210: convert resolution to devicetree property Message-ID: <20230924191032.48cc906b@jic23-huawei> In-Reply-To: <20230921144400.62380-18-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> <20230921144400.62380-18-dlechner@baylibre.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 24 Sep 2023 11:10:56 -0700 (PDT) On Thu, 21 Sep 2023 09:43:58 -0500 David Lechner wrote: > Selecting the resolution was implemented as the `bits` sysfs attribute. > However, the selection of the resolution depends on how the hardware > is wired and the specific application, so this is rather a job for > devicetree to describe. > > A new devicetree property `adi,resolution` to specify the resolution > required for each chip is added and the `bits` sysfs attribute is > removed. > > Since the resolution is now supplied by a devicetree property, the > resolution-gpios are now optional and we can allow for the case where > the resolution pins on the AD2S1210 are hard-wired instead of requiring > them to be connected to gpios. > > Signed-off-by: David Lechner Good change to see. Note that mostly I've not commented on patches where I fully agree with them.