Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sun, 24 Sep 2023 12:48:15 -0700
From:   Kees Cook <kees@kernel.org>
To:     Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Kees Cook <keescook@chromium.org>
CC:     Casey Schaufler <casey@schaufler-ca.com>, paul@paul-moore.com,
        linux-security-module@vger.kernel.org, jmorris@namei.org,
        serge@hallyn.com, john.johansen@canonical.com,
        stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, mic@digikod.net,
        Dave Chinner <david@fromorbit.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v15 01/11] LSM: Identify modules by more than name
User-Agent: K-9 Mail for Android
In-Reply-To: <dfdb82a8-85b2-4704-35b9-3ad901a179f1@I-love.SAKURA.ne.jp>
References: <20230912205658.3432-1-casey@schaufler-ca.com> <20230912205658.3432-2-casey@schaufler-ca.com> <1f5e725d-58b6-eca2-97dc-d7c1209ff167@I-love.SAKURA.ne.jp> <568c0730-b458-04b4-dbfa-77da1758aa05@schaufler-ca.com> <94743c22-bc76-e741-e577-3e0845423f69@I-love.SAKURA.ne.jp> <6df9f8b8-5653-09a5-ae0a-6526016abaff@schaufler-ca.com> <ec37cd2f-24ee-3273-c253-58d480569117@I-love.SAKURA.ne.jp> <202309200803.1911A584@keescook> <af696700-ae4b-346e-4c52-3a7a21b0f46c@I-love.SAKURA.ne.jp> <202309231838.CB16E6B5@keescook> <dfdb82a8-85b2-4704-35b9-3ad901a179f1@I-love.SAKURA.ne.jp>
Message-ID: <407A11DD-932D-441E-B4EC-673F4423CEDD@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On September 24, 2023 4:06:07 AM PDT, Tetsuo Handa <penguin-kernel@I-love=
=2ESAKURA=2Ene=2Ejp> wrote:
>Patch description says
>
>  The LSM ID values are sequential, with the oldest module
>  LSM_ID_CAPABILITY being the lowest value and the existing modules
>  numbered in the order they were included in the main line kernel=2E
>  This is an arbitrary convention for assigning the values, but
>  none better presents itself=2E The value 0 is defined as being invalid=
=2E

"in the order they were included in the main line kernel" Out of trees are=
n't in main line=2E

And "This is an arbitrary convention" specifically says it's arbitrary=2E

There is literally nothing here stopping out of tree modules=2E I have pro=
ven this, and so have you with these quotes=2E What is left to object to?

>You withdraw your "Reviewed-by" response unless "The LSM ID values are se=
quential"
>and "must be approved by the LSM maintainers" are removed and "the LSM ma=
intainers/community
>shall never complain about what names and/or values are assigned" is adde=
d, don't you?

*For main line kernels*

Please, understand both the *intent* and *reality*: this does not block ou=
t of tree LSMs, full stop=2E

>Keeping how the HUGE space is used under control of the LSM community wil=
l be
>better for both in-tree and out-of-tree LSM modules=2E I really can't und=
erstand
>why you don't want to utilize this opportunity=2E

I cannot understand what else you need to hear=2E

-Kees


--=20
Kees Cook