Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20230923093037.961232-1-yangjihong1@huawei.com> <20230923093037.961232-2-yangjihong1@huawei.com>
In-Reply-To: <20230923093037.961232-2-yangjihong1@huawei.com>
From:   Ian Rogers <irogers@google.com>
Date:   Sun, 24 Sep 2023 11:10:52 -0700
Message-ID: <CAP-5=fWpZk-sXjy5D28Os6YgDeMiu9UiVRzqZM9RHMs8YFj-3Q@mail.gmail.com>
Subject: Re: [PATCH 1/4] perf bench messaging: Fix coding style issues for sched-messaging
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Sep 23, 2023 at 2:32=E2=80=AFAM Yang Jihong <yangjihong1@huawei.com=
> wrote:
>
> Fixed several code style issues in sched-messaging:
> 1. Use one space around "-" and "+" operators.
> 2. When a long line is broken, the operator is at the end of the line.
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Series:
Reviewed-by: Ian Rogers <irogers@google.com>
I wonder with the SIGTERM improvements whether there should be
improvements to tools/lib/subcmd and then we use that.

Thanks,
Ian

> ---
>  tools/perf/bench/sched-messaging.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/bench/sched-messaging.c b/tools/perf/bench/sched-=
messaging.c
> index fa1f8f998814..6a33118c8f9b 100644
> --- a/tools/perf/bench/sched-messaging.c
> +++ b/tools/perf/bench/sched-messaging.c
> @@ -98,7 +98,7 @@ static void *sender(struct sender_context *ctx)
>
>  again:
>                         ret =3D write(ctx->out_fds[j], data + done,
> -                                   sizeof(data)-done);
> +                                   sizeof(data) - done);
>                         if (ret < 0)
>                                 err(EXIT_FAILURE, "SENDER: write");
>                         done +=3D ret;
> @@ -201,8 +201,8 @@ static unsigned int group(pthread_t *pth,
>                 int wakefd)
>  {
>         unsigned int i;
> -       struct sender_context *snd_ctx =3D malloc(sizeof(struct sender_co=
ntext)
> -                       + num_fds * sizeof(int));
> +       struct sender_context *snd_ctx =3D malloc(sizeof(struct sender_co=
ntext) +
> +                                               num_fds * sizeof(int));
>
>         if (!snd_ctx)
>                 err(EXIT_FAILURE, "malloc()");
> @@ -239,7 +239,7 @@ static unsigned int group(pthread_t *pth,
>                 snd_ctx->wakefd =3D wakefd;
>                 snd_ctx->num_fds =3D num_fds;
>
> -               pth[num_fds+i] =3D create_worker(snd_ctx, (void *)sender)=
;
> +               pth[num_fds + i] =3D create_worker(snd_ctx, (void *)sende=
r);
>         }
>
>         /* Close the fds we have left */
> @@ -288,7 +288,7 @@ int bench_sched_messaging(int argc, const char **argv=
)
>
>         total_children =3D 0;
>         for (i =3D 0; i < num_groups; i++)
> -               total_children +=3D group(pth_tab+total_children, num_fds=
,
> +               total_children +=3D group(pth_tab + total_children, num_f=
ds,
>                                         readyfds[1], wakefds[0]);
>
>         /* Wait for everyone to be ready */
> --
> 2.34.1
>