Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp930665rdh; Sun, 24 Sep 2023 19:29:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOL7R06oOoJPPM6AjuTEFoxhLPdovpm7olfq/iCqNZBlNOKG9DhZJ1x9Dxs80jIEwRce+n X-Received: by 2002:a17:903:25c3:b0:1c3:a814:a12b with SMTP id jc3-20020a17090325c300b001c3a814a12bmr7300848plb.16.1695608939803; Sun, 24 Sep 2023 19:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695608939; cv=none; d=google.com; s=arc-20160816; b=pXCE+w6h0kxF2kQItN/P5jJxFQdOggCjJ2oPbGSWq1OdNUuS5Do1CWWSYwsVMxSpjs 5r111GbDzgpFYNryVneeVvb6QETCPTB0O7Y1Mgc/LfcSG0vTAaGE/YBhyt01E0v0h4T8 3LgN0odclisu6GEtaBma64+MIskXfQe31Z1qcskiF5UGd34JxU/41MzItj9n02kxaSM3 Tu5E6v7B/KqUL0UBDzFaVyFbUVZCTcAxHLpyTEADSOGijmQm2l6nj0bUNH7sF1om4gZI IZ0C0rJ9ivpI+NgSsNU4HYDGyvCrod5QSixV4awSEulvpRMPIferUHzwlcz9UWQvnVVi cbow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ZZ7D6OvMoe60gWWC5v0OO69jG6MgPdq71Rzj28LGg08=; fh=N51AisicwY6yIRngGAGlh1L96arWhTTsN7/Sa6+FL/o=; b=W1mkblPecsvmplcpeNBaw3JSODJx54+HUPU4KstY3ShXdY/CzRr3J+fyhhA+lAfm/L qxbHCY/whrK6GFlog+yPNX6nHBKj6L7BZ3kcssLhbwB1iaw2cRacvfOP2KHNMUgIoL7y 9PlIE0P04h2LJVekz7VyNuFWxsMxZ49ay1Yx58+a+LgOYhs0iDqj5ZcaeKCGGBVsjWNK KyZeoP/Byj9F06xKI12MTzrQAAbICnPMuVwQBV3Q7EfAJwsVduJ0562641CDaSdgi0eN chQ3tIFCJfA7ODyvafIbVIYshlkUiSlK388xZwaOq0Qg6vMRo+0D1gBs8Empqqyl1zFP 4tyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XeUq47K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id i11-20020a17090332cb00b001c3323ff53asi9119787plr.139.2023.09.24.19.28.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 19:28:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XeUq47K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5F28980215AE; Sun, 24 Sep 2023 13:58:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbjIXU61 (ORCPT + 99 others); Sun, 24 Sep 2023 16:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjIXU60 (ORCPT ); Sun, 24 Sep 2023 16:58:26 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21E27EE; Sun, 24 Sep 2023 13:58:20 -0700 (PDT) Received: from mercury (cust-west-par-46-193-56-210.cust.wifirst.net [46.193.56.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2C93366072E9; Sun, 24 Sep 2023 21:58:18 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695589098; bh=h8S0AVpoW3F2EytvwOGglewnFQNIvkNAQbE34WlVL0E=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=XeUq47K7GoNnjFu0Z/Xl6fZURJ+CNaPsMYNqh2EYtwcf88C/4ahy2EBGI/7ioASQm SyngW67glqcbQX/gvOCwXWxW9wpfS2KLxQrKoxzk6eMw5+1CVl6o++Ttk2uVgqA7uI TU8qq9SAqEuA7rOzh2LeIgY6EyytQwHAyxZiGsolgYiLE4IhznVXzsdZTYw1k6dLZR CRnxjy4mX1yUXxO5XY/5oLAzCcXpZxEPi7XMkkEIs5KB2CDe5B9HuI8c8ODhA1IoMs BlOKefBWl5QLOEMFHpUBylE5j7g4KAwJLYE/vtM3UKWUQvz2YUJeDFVnNKG867Cglw 3JpD8g7/fG+vQ== Received: by mercury (Postfix, from userid 1000) id A0C3D10611D9; Sun, 24 Sep 2023 22:58:15 +0200 (CEST) From: Sebastian Reichel To: Konrad Dybcio , Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Harshit Mogalapalli Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, error27@gmail.com, kernel test robot In-Reply-To: <20230923114807.2829188-1-harshit.m.mogalapalli@oracle.com> References: <20230923114807.2829188-1-harshit.m.mogalapalli@oracle.com> Subject: Re: [PATCH next] power: supply: mm8013: Fix error code in mm8013_probe() Message-Id: <169558909561.1797612.1920151492515517327.b4-ty@collabora.com> Date: Sun, 24 Sep 2023 22:58:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 24 Sep 2023 13:58:41 -0700 (PDT) On Sat, 23 Sep 2023 04:48:06 -0700, Harshit Mogalapalli wrote: > The value of ret is zero when passed to dev_error_probe(), we are passing > zero to dev_err_probe() is a success which is incorrect. > > Fix this by getting the error code using PTR_ERR(). > > Applied, thanks! [1/1] power: supply: mm8013: Fix error code in mm8013_probe() commit: 43ee22422db545800b8bf2c24ef53d040372fc7a Best regards, -- Sebastian Reichel