Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
MIME-Version: 1.0
References: <20230920144343.64830-1-dakr@redhat.com> <20230920144343.64830-3-dakr@redhat.com>
In-Reply-To: <20230920144343.64830-3-dakr@redhat.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Mon, 25 Sep 2023 10:42:35 +1000
Message-ID: <CAPM=9tzHPqviNL0VX5GnSZKkpJz0xy8520S5n_3SZaJr5ZdM-w@mail.gmail.com>
Subject: Re: [PATCH drm-misc-next v4 2/8] drm/gpuvm: allow building as module
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     daniel@ffwll.ch, matthew.brost@intel.com,
        thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
        donald.robson@imgtec.com, boris.brezillon@collabora.com,
        christian.koenig@amd.com, faith.ekstrand@collabora.com,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 21 Sept 2023 at 00:43, Danilo Krummrich <dakr@redhat.com> wrote:
>
> Currently, the DRM GPUVM does not have any core dependencies preventing
> a module build.
>
> Also, new features from subsequent patches require helpers (namely
> drm_exec) which can be built as module.
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>

Reviewed-by: Dave Airlie <airlied@redhat.com>

> ---
>  drivers/gpu/drm/Kconfig         | 7 +++++++
>  drivers/gpu/drm/Makefile        | 2 +-
>  drivers/gpu/drm/drm_gpuvm.c     | 3 +++
>  drivers/gpu/drm/nouveau/Kconfig | 1 +
>  4 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index ab9ef1c20349..0f78a03e4e84 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -216,6 +216,13 @@ config DRM_EXEC
>         help
>           Execution context for command submissions
>
> +config DRM_GPUVM
> +       tristate
> +       depends on DRM && DRM_EXEC
> +       help
> +         GPU-VM representation providing helpers to manage a GPUs virtua=
l
> +         address space
> +
>  config DRM_BUDDY
>         tristate
>         depends on DRM
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 7a84b3cddeab..8e1bde059170 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -45,7 +45,6 @@ drm-y :=3D \
>         drm_vblank.o \
>         drm_vblank_work.o \
>         drm_vma_manager.o \
> -       drm_gpuvm.o \
>         drm_writeback.o
>  drm-$(CONFIG_DRM_LEGACY) +=3D \
>         drm_agpsupport.o \
> @@ -81,6 +80,7 @@ obj-$(CONFIG_DRM_PANEL_ORIENTATION_QUIRKS) +=3D drm_pan=
el_orientation_quirks.o
>  #
>  #
>  obj-$(CONFIG_DRM_EXEC) +=3D drm_exec.o
> +obj-$(CONFIG_DRM_GPUVM) +=3D drm_gpuvm.o
>
>  obj-$(CONFIG_DRM_BUDDY) +=3D drm_buddy.o
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index 7074bcad5b28..bfea4a8a19ec 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -1723,3 +1723,6 @@ drm_gpuva_ops_free(struct drm_gpuvm *gpuvm,
>         kfree(ops);
>  }
>  EXPORT_SYMBOL_GPL(drm_gpuva_ops_free);
> +
> +MODULE_DESCRIPTION("DRM GPUVM");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kc=
onfig
> index c52e8096cca4..1e6aaf95ff7c 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -11,6 +11,7 @@ config DRM_NOUVEAU
>         select DRM_TTM
>         select DRM_TTM_HELPER
>         select DRM_EXEC
> +       select DRM_GPUVM
>         select DRM_SCHED
>         select I2C
>         select I2C_ALGOBIT
> --
> 2.41.0
>