Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp934490rdh; Sun, 24 Sep 2023 19:42:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETYouQ/3x8dbOIAufgEvbOVqwCd/VNvSZvAJP1PGbBQ4AIgNpvjznYWmcvdEDtosB9n2UF X-Received: by 2002:a05:6a20:96d7:b0:14c:d5d8:9fed with SMTP id hq23-20020a056a2096d700b0014cd5d89fedmr3193022pzc.54.1695609723282; Sun, 24 Sep 2023 19:42:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695609723; cv=none; d=google.com; s=arc-20160816; b=fSpPm21X6cswxBRuuFZ3WjUy0r4+jb2krXMZL4HrS1VOEVPRamIImO75w5nJCdLvTC JSplaVkKfUCB+C7sKX0EjZOuUeZaj9pIKcdGjwIlM0syozQCxDM2xnYCt5dUIOoWhVJS 60Np3I0pbhHjL5JzTIQZ2vbKME/Ohwi5iKJTOkyuzNYm3If4wXq+jl8+3vuLP0G6icBO i8ywJ39y/Tv49iYh1Ln2iUyOHmldwLCu+qqrmBoklQi7N8ttg4qAqoMUvPLoMvC3c+pQ xTHIeY1XNRFNnTKphl5aZyCRnV2JKkZGoZnjSLIqxkb5QASR7gR13oLExQ8I0FQnL1+5 kLUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=wxg7z3SJdIhGeJqzyu9pUfC9PJFTyuVUSbp28SXUuNo=; fh=c+AsKdIG97GUCRyCMYfG21FU9lcisJKjJoIcuoaq4Wc=; b=G7YixnoybJkB3t0VAuvJq4M6DOBA6PImmy2AQ5UWmAJ1Np1IiOt1kgHVbTh0eMAcXw ngGhzY3XblnE8m2hM5HwtjZ74fXbQwUbYc/B7TSLt/IjPdLelV/+nJlBuLbQBYnCBd/u aE9rR3muQ6t8Mk+7gd/m2qYz1aPIIq4PYUu7fZ75XIKVoKBAyfEBgG+GqXjcDUZtCJ63 sVBFoh6IkIBM15RORDqOCGmGI4b4LbKvqcPLcADOEJmO9TSTyxd3Mc0aWr7fLYqeo4Oe eKLe7BNPy/ZTo5/WBenWWHrUrdZAP5bVUBcn8QtkhJALvaerixy6pbqZwedMoX3GcAIL ERTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id c1-20020a170902d48100b001b7eb771d5esi9784715plg.527.2023.09.24.19.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 19:42:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 61F06801DB20; Sun, 24 Sep 2023 19:42:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbjIYCmA (ORCPT + 99 others); Sun, 24 Sep 2023 22:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231720AbjIYCl7 (ORCPT ); Sun, 24 Sep 2023 22:41:59 -0400 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9418092 for ; Sun, 24 Sep 2023 19:41:52 -0700 (PDT) Received: from localhost.localdomain (unknown [10.190.75.40]) by mail-app2 (Coremail) with SMTP id by_KCgBHT7dk8xBlWpXvAA--.27165S4; Mon, 25 Sep 2023 10:41:47 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn Cc: Lee Jones , Qiang Ning , linux-kernel@vger.kernel.org Subject: [PATCH] mfd: dln2: Fix double put in dln2_probe Date: Mon, 25 Sep 2023 10:41:33 +0800 Message-Id: <20230925024134.9683-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: by_KCgBHT7dk8xBlWpXvAA--.27165S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr4xZr17ZFy7tr1rXr4UXFb_yoWxZFbEgw 15u397XwsrGrW7K342yryruryI9rn5Wrn7Zw4fKasxJayYqa45Xrn7Xw47Gr13ZFWUZrn8 A34vqr1IvF1YyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb7AFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26rxl6s0DM28EF7xvwVC2z280 aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07 x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18 McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr4 1lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIE Y20_GFWkJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI 8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41l IxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIx AIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbXdbUUUUUU== X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAg0HBmUNoyAhBwAGsF X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 24 Sep 2023 19:42:00 -0700 (PDT) The dln2_free() already contains usb_put_dev(). Therefore, the redundant usb_put_dev() before dln2_free() may lead to a double free. Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()") Signed-off-by: Dinghao Liu --- drivers/mfd/dln2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index c7510434380a..fbbe82c6e75b 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -826,7 +826,6 @@ static int dln2_probe(struct usb_interface *interface, dln2_stop_rx_urbs(dln2); out_free: - usb_put_dev(dln2->usb_dev); dln2_free(dln2); return ret; -- 2.17.1