Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <b6658931-7607-36e8-ad92-41899fce531b@intel.com>
Date:   Mon, 25 Sep 2023 08:26:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v6 23/25] KVM: x86: Enable CET virtualization for VMX and
 advertise to userspace
To:     kernel test robot <oliver.sang@intel.com>
CC:     <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <seanjc@google.com>,
        <pbonzini@redhat.com>, <dave.hansen@intel.com>,
        <peterz@infradead.org>, <chao.gao@intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <202309242050.90b36814-oliver.sang@intel.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <202309242050.90b36814-oliver.sang@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REhTcjdVWlRZSSsrQS82SkNNcmpVaGVCUlM0bS9VczBpMW5aSHhRRVVvY0c0?=
 =?utf-8?B?Wlovc2IrR2NNaU5YSkFTSHlEMWxwbVZZTFRSaEFxckNxZ2wzeE9TQU1rRjNu?=
 =?utf-8?B?TW1tUWg3VVh4M1RyM3RSVzNNZ2VZeUxXV2hqR3M3aFlkNkIzako0NkF0bmRq?=
 =?utf-8?B?b3QwRjFtQ1U5UUU2MXVPcHlYK1V4S3pVc3BKSjFtRytWc0xnbDJyVFppd1pZ?=
 =?utf-8?B?dlpLWGR3NEI3OGlZcEhzbldnc3hMQVg3d1RJMTBWZlBlbWtIZ3BrRlF3STRD?=
 =?utf-8?B?by9lQ1NVZ1ExSzNIdDJjUlE2b3VVeUFLUmRIY1ArTUs3bmFHNjRwbHV5dnZX?=
 =?utf-8?B?ZFlabldFR3NuNVIxdzZxZXV5ZmJMZ0lBUERsSmpGSEplb0xvSmlxNUFzUXpo?=
 =?utf-8?B?TGxWMjZKV1E4UzQ3Yjg0U3BWUXVLLzB5a1NyU0ZZNnBjQlEyVkJaTEg0M3Nl?=
 =?utf-8?B?Z2FEVWZKa1RVc0tLN2NRbDBXdUJTZmpTWmYrZUpjZVBUZWFIdHRpQitiVUJP?=
 =?utf-8?B?NENYSDFDanA0S2Y4SjhPblI0QWtpS2Q1d2NVVUdYZ1V0M3hMU01CQ0x1SkQv?=
 =?utf-8?B?OThLdW10MkZaYTQ1R1R4VFJCZWZNKzJuZ2I0S0VwbGVZc1BNRXJUcXl0Tjh1?=
 =?utf-8?B?aEhhQzdubGJ5MG5pRjNCZTJiSXhsZ3NqZXNINStqWjdhR002aVU5MXduaC9l?=
 =?utf-8?B?dFBSS0VvK1dSWU5kNXpFcXUwSVc2UFBlSDFKT21WR21YdngvNFVGUXhuTXV0?=
 =?utf-8?B?TENEMmhEd3R1Wnp3MGx2bkhwNGhaTDJwdDNSK0FraFdyQXAvaHdVUXdjeTZZ?=
 =?utf-8?B?U2JJNWtLMXF3TUlVaHFDeVRmOVlmSzIyVE5XdGlva2ExVHpSTmp2d1ByQXc1?=
 =?utf-8?B?ZlU0Rm9vQUxJOU1SOFZxMnhQcTJXTFhKZXRlZXdOc3dTMjZFcWQ1TldYMnQ4?=
 =?utf-8?B?TmRGYVNOWEplaUdFZHlPeWFxNkRlaTdXTVFkQU9Iem53cjkzRW9GbVpGSGg5?=
 =?utf-8?B?OFN1dG9aaHFRL3ZzQnZEbWJvc3ZWRTdmNU1WMHRub3drbHU4b3JDZzBYT0xl?=
 =?utf-8?B?cTR3bDlHNTUxZnRVK3JkMFcyUWprUnArTFlVRThrRzNqL0Z5SW9zZ2hvUThK?=
 =?utf-8?B?dk5VWUkyVS9YSWNzVmdyeWhFeGQwZUZnckxHNWR4dzd0UzdneHBQNy9UUG1k?=
 =?utf-8?B?ZVh4aU9XZ1VOc1lQTzR4RVZlOE0zYXQyemJtM0hOVWF2WE1aanZadmNnd29C?=
 =?utf-8?B?b3BMcWszOFFlb0s0akF2SXZZRXM4YklqUTI4SjRMNzA1NzNwSW9WdHlFV2lU?=
 =?utf-8?B?R0w0bDEzSFZTM3JqVFJvaEZwaFZTdmpSa09IRVd0a1p5dDg2eXByNk1jL3BW?=
 =?utf-8?B?RXNTcFhFdkJiMHRwTkxlVWFUQXJQNGtEREE3enhIMERLekhVUGJIR2Y4ZDJo?=
 =?utf-8?B?RmNRdi9DVEtxQkRTb2xSenhmUVdnSXdWWVNHbjFkbHExbmhhN2Fib3A2VkxQ?=
 =?utf-8?B?RkZ0WmZCME0ya0xhMnppTStvSHR2WjljNXNTSTVVUjJRVnVNS25DUm9kWUd5?=
 =?utf-8?B?NTFHSFFkYWgyQWhLMlU3TlNVS1VmTVJJNzdNaCt0MzdBR3MweWFKeDBFVFlQ?=
 =?utf-8?B?bjVXeHdZN0xxUm1xM241Vm4vdjJlYjMxREQ1WlRFajYrWGo5eDBqOFNXLzFm?=
 =?utf-8?B?Z1hJb3dqQ2EvQU5WNnk1RDE4UVRGampJRFZnQWRFY0ZFeStZcmt4WURvUkZQ?=
 =?utf-8?B?OXNNM1p2L2lGUGhVWDBtZFE3QlFjRUlUTkJTV0FKY2tiN2R6ZVRIVzdDWmRl?=
 =?utf-8?B?dWx5T3pvQWQzOVRoNWZ1U2ExakpCdDNHdEJ2Y3l3K3BkY1JtMFVCYnR2clVq?=
 =?utf-8?B?QWFzUXgzcFJSVTZObmVnRnd0LzRJakhrVVhnMzBaYlFrVUVPdWxOREtRVHRo?=
 =?utf-8?B?RVE3dmFndFk3YnkvUGNJS1Jsb2k0Qk44M256Ny9DWFFvR09ab2xmMkp3TnFq?=
 =?utf-8?B?STdQRk91aU5hQWthNGF1NjA0aitiQXFJS2JLWlI2WGZZWVg0bTg4T0ZjZTVo?=
 =?utf-8?B?QUlyczJuVXplNTVwRXdrRzc5OFF1ckY5VytHZndyL3haa2gvUTBOVGZXN1Q2?=
 =?utf-8?B?OWFSbThOUWRyaGpSZmhDM2QzWUladDNUb3l5MmRBbVFHdUZ4dUVBdTV5RXo0?=
 =?utf-8?B?QUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82b9f241-e963-496c-bf33-08dbbd5e118c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 00:26:32.4460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8pTj1m2w6x6RXD1TfueaPy/MFwEsp2JQ0/lIDAGACZugK9Xkvjh/aOGnivODD7DrF8DMznvCHzkGO4Hoi4mhag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8102
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 24 Sep 2023 17:27:58 -0700 (PDT)


It's due to lack of capability check, I will fix the calltrace in next verison.

On 9/24/2023 9:38 PM, kernel test robot wrote:
>
> Hello,
>
> kernel test robot noticed "WARNING:at_arch/x86/kvm/vmx/vmx.c:#vmwrite_error[kvm_intel]" on:
>
> commit: 68d0338a67df85ab18482295976e7bd873987165 ("[PATCH v6 23/25] KVM: x86: Enable CET virtualization for VMX and advertise to userspace")
> url: https://github.com/intel-lab-lkp/linux/commits/Yang-Weijiang/x86-fpu-xstate-Manually-check-and-add-XFEATURE_CET_USER-xstate-bit/20230914-174056
> patch link: https://lore.kernel.org/all/20230914063325.85503-24-weijiang.yang@intel.com/
> patch subject: [PATCH v6 23/25] KVM: x86: Enable CET virtualization for VMX and advertise to userspace
>
> in testcase: kvm-unit-tests-qemu
> version:
> with following parameters:
>
>
>
>
> compiler: gcc-12
> test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz (Ice Lake) with 128G memory
>
> (please refer to attached dmesg/kmsg for entire log/backtrace)
>
>
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202309242050.90b36814-oliver.sang@intel.com
>
>
>
> The kernel config and materials to reproduce are available at:
> https://download.01.org/0day-ci/archive/20230924/202309242050.90b36814-oliver.sang@intel.com
>
>
>
> [  271.856711][T15436] ------------[ cut here ]------------
> [  271.863011][T15436] vmwrite failed: field=682a val=0 err=12
> [  271.869458][T15436] WARNING: CPU: 117 PID: 15436 at arch/x86/kvm/vmx/vmx.c:444 vmwrite_error+0x16b/0x2e0 [kvm_intel]
> [  271.880940][T15436] Modules linked in: kvm_intel kvm irqbypass btrfs blake2b_generic xor raid6_pq zstd_compress libcrc32c sd_mod t10_pi crc64_rocksoft_generic crc64_rocksoft crc64 sg intel_rapl_msr intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel sha512_ssse3 rapl intel_cstate ipmi_ssif ahci ast libahci mei_me drm_shmem_helper intel_uncore dax_hmem ioatdma joydev drm_kms_helper acpi_ipmi libata mei intel_pch_thermal dca wmi ipmi_si ipmi_devintf ipmi_msghandler acpi_power_meter acpi_pad fuse drm ip_tables [last unloaded: irqbypass]
> [  271.939752][T15436] CPU: 117 PID: 15436 Comm: qemu-system-x86 Not tainted 6.5.0-12553-g68d0338a67df #1
> [  271.950090][T15436] RIP: 0010:vmwrite_error+0x16b/0x2e0 [kvm_intel]
> [  271.957256][T15436] Code: ff c6 05 f1 4b 82 ff 01 66 90 b9 00 44 00 00 0f 78 c9 0f 86 e0 00 00 00 48 89 ea 48 89 de 48 c7 c7 80 1c d9 c0 e8 c5 b7 c4 bf <0f> 0b e9 ae fe ff ff 48 c7 c0 a0 6f d9 c0 48 ba 00 00 00 00 00 fc
> [  271.978720][T15436] RSP: 0018:ffa000000e117980 EFLAGS: 00010286
> [  271.985599][T15436] RAX: 0000000000000000 RBX: 000000000000682a RCX: ffffffff82216eee
> [  271.994345][T15436] RDX: 1fe2200403fd57c8 RSI: 0000000000000008 RDI: ffa000000e117738
> [  272.003044][T15436] RBP: 0000000000000000 R08: 0000000000000001 R09: fff3fc0001c22ee7
> [  272.011865][T15436] R10: ffa000000e11773f R11: 0000000000000001 R12: ff110011b12a4b20
> [  272.020632][T15436] R13: 0000000000000000 R14: 0000000000000000 R15: ff110011b12a4980
> [  272.029340][T15436] FS:  00007f79fd975700(0000) GS:ff1100201fe80000(0000) knlGS:0000000000000000
> [  272.039141][T15436] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  272.046484][T15436] CR2: 00007f79e8000010 CR3: 00000010d23c0003 CR4: 0000000000773ee0
> [  272.055167][T15436] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [  272.063980][T15436] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [  272.072749][T15436] PKRU: 55555554
> [  272.076985][T15436] Call Trace:
> [  272.080947][T15436]  <TASK>
> [  272.084650][T15436]  ? __warn+0xcd/0x260
> [  272.089420][T15436]  ? vmwrite_error+0x16b/0x2e0 [kvm_intel]
> [  272.096014][T15436]  ? report_bug+0x267/0x2d0
> [  272.101163][T15436]  ? handle_bug+0x3c/0x70
> [  272.106130][T15436]  ? exc_invalid_op+0x17/0x40
> [  272.111483][T15436]  ? asm_exc_invalid_op+0x1a/0x20
> [  272.117132][T15436]  ? llist_add_batch+0xbe/0x130
> [  272.122685][T15436]  ? vmwrite_error+0x16b/0x2e0 [kvm_intel]
> [  272.129113][T15436]  vmx_vcpu_reset+0x2382/0x30b0 [kvm_intel]
> [  272.135741][T15436]  ? init_vmcs+0x7230/0x7230 [kvm_intel]
> [  272.141988][T15436]  ? irq_work_sync+0x8a/0x1f0
> [  272.147302][T15436]  ? kvm_clear_async_pf_completion_queue+0x2e6/0x4c0 [kvm]
> [  272.155191][T15436]  kvm_vcpu_reset+0x8cc/0x1080 [kvm]
> [  272.161154][T15436]  kvm_arch_vcpu_create+0x8c5/0xbd0 [kvm]
> [  272.167584][T15436]  kvm_vm_ioctl_create_vcpu+0x4be/0xe20 [kvm]
> [  272.174297][T15436]  ? __alloc_pages+0x1d5/0x440
> [  272.179723][T15436]  ? kvm_get_dirty_log_protect+0x5f0/0x5f0 [kvm]
> [  272.186757][T15436]  ? __alloc_pages_slowpath+0x1cf0/0x1cf0
> [  272.194079][T15436]  ? do_user_addr_fault+0x26c/0xac0
> [  272.199837][T15436]  ? mem_cgroup_handle_over_high+0x570/0x570
> [  272.206405][T15436]  ? _raw_spin_lock+0x85/0xe0
> [  272.211721][T15436]  ? _raw_write_lock_irq+0xe0/0xe0
> [  272.217414][T15436]  kvm_vm_ioctl+0x939/0xde0 [kvm]
> [  272.223014][T15436]  ? __mod_memcg_lruvec_state+0x100/0x220
> [  272.229278][T15436]  ? kvm_unregister_device_ops+0x90/0x90 [kvm]
> [  272.235978][T15436]  ? __mod_lruvec_page_state+0x1ad/0x3a0
> [  272.242092][T15436]  ? perf_trace_mm_lru_insertion+0x7c0/0x7c0
> [  272.248627][T15436]  ? folio_batch_add_and_move+0xc1/0x110
> [  272.254832][T15436]  ? do_anonymous_page+0x5e2/0xc10
> [  272.260431][T15436]  ? up_write+0x52/0x90
> [  272.265006][T15436]  ? vfs_fileattr_set+0x4e0/0x4e0
> [  272.270502][T15436]  ? copy_page_range+0x880/0x880
> [  272.275831][T15436]  ? __count_memcg_events+0xdd/0x1e0
> [  272.281564][T15436]  ? handle_mm_fault+0x187/0x7a0
> [  272.286855][T15436]  ? __fget_light+0x236/0x4d0
> [  272.291883][T15436]  __x64_sys_ioctl+0x130/0x1a0
> [  272.296994][T15436]  do_syscall_64+0x38/0x80
> [  272.301756][T15436]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
> [  272.307993][T15436] RIP: 0033:0x7f79fe886237
> [  272.312758][T15436] Code: 00 00 00 48 8b 05 59 cc 0d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 29 cc 0d 00 f7 d8 64 89 01 48
> [  272.333241][T15436] RSP: 002b:00007f79fd974808 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [  272.342024][T15436] RAX: ffffffffffffffda RBX: 000000000000ae41 RCX: 00007f79fe886237
> [  272.350428][T15436] RDX: 0000000000000000 RSI: 000000000000ae41 RDI: 000000000000000d
> [  272.358789][T15436] RBP: 00005606ece4cc90 R08: 0000000000000000 R09: 0000000000000000
> [  272.367151][T15436] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> [  272.375587][T15436] R13: 00007ffefe5a1daf R14: 00007f79fd974a80 R15: 0000000000802000
> [  272.383950][T15436]  </TASK>
> [  272.387416][T15436] ---[ end trace 0000000000000000 ]---
> [  272.393295][T15436] kvm_intel: vmwrite failed: field=682a val=0 err=12
>
>
>