Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <0bf7db81-feda-4395-97fc-97d5a0f1b6db@quicinc.com>
Date:   Mon, 25 Sep 2023 08:39:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 5/6] arm64: dts: qcom: sm4450-qrd: add QRD4450 uart
 support
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <tglx@linutronix.de>, <maz@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <geert+renesas@glider.be>, <arnd@arndb.de>,
        <neil.armstrong@linaro.org>, <nfraprado@collabora.com>,
        <rafal@milecki.pl>, <peng.fan@nxp.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <quic_tsoni@quicinc.com>,
        <quic_shashim@quicinc.com>, <quic_kaushalk@quicinc.com>,
        <quic_tdas@quicinc.com>, <quic_tingweiz@quicinc.com>,
        <quic_aiquny@quicinc.com>, <kernel@quicinc.com>
References: <20230922081026.2799-1-quic_tengfan@quicinc.com>
 <20230922081026.2799-6-quic_tengfan@quicinc.com>
 <CAA8EJpq1NAOZTOmBUUnkeLDThvxosj=MzNHo=5VAXnRPQci68g@mail.gmail.com>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <CAA8EJpq1NAOZTOmBUUnkeLDThvxosj=MzNHo=5VAXnRPQci68g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 9/24/2023 3:12 AM, Dmitry Baryshkov 写道:
> On Fri, 22 Sept 2023 at 11:13, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Add uart support for QRD4450 for enable uart console.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 19 +++++++++++++++++--
>>   1 file changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> index 00a1c81ca397..e354bad57a9e 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> @@ -10,9 +10,24 @@
>>          model = "Qualcomm Technologies, Inc. SM4450 QRD";
>>          compatible = "qcom,sm4450-qrd", "qcom,sm4450";
>>
>> -       aliases { };
>> +       aliases {
>> +               serial0 = &uart7;
>> +       };
>>
>>          chosen {
>> -               bootargs = "console=hvc0";
>> +               stdout-path = "serial0:115200n8";
>>          };
>>   };
>> +
>> +&qupv3_id_0 {
>> +       status = "okay";
>> +};
>> +
>> +&tlmm {
>> +       /* Reserved for other subsystems */
>> +       gpio-reserved-ranges = <0 4>, <136 1>;
>> +};
> 
> Is this also related to the UART support? it looks like it is a
> separate patch, which should likely have the Fixes tag
Hi Dmitry,
This is related to the pinctrl support, UART support depend on pinctrl.
I will separate this to another patch for clearer.
> 
>> +
>> +&uart7 {
>> +       status = "okay";
>> +};
>> --
>> 2.17.1
>>
> 
> 

-- 
Thx and BRs,
Tengfei Fan