Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Mon, 25 Sep 2023 04:18:46 +0000
From:   Matthew Brost <matthew.brost@intel.com>
To:     "Dr. David Alan Gilbert" <dave@treblig.org>
CC:     <mgreer@animalcreek.com>, <krzysztof.kozlowski@linaro.org>,
        <linux-kernel@vger.kernel.org>, <airlied@gmail.com>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: ERR_PTR(0) in a couple of places
Message-ID: <ZREKJpfMx7ZEcw3n@DUT025-TGLU.fm.intel.com>
References: <ZQ+Fo9WKyGphwI8R@gallifrey>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZQ+Fo9WKyGphwI8R@gallifrey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wGYXFpTUTign0w0+ye8jF5T01mL4ANfoNleAh/o5jvOiqrWrT+r2eOW60BLU?=
 =?us-ascii?Q?tCE1Ekddy1za0Lvs224fYDxJ+LaQ1kQinsy6pkj/61stRacPtvLIcEV0uLfp?=
 =?us-ascii?Q?LTWjd3IC1gIDJwiVX+9QygON0axMe8dZvTLjQhDATwis3XpO53lYeL0ovMRy?=
 =?us-ascii?Q?WkJQUNoy8q6W/OJDAKd3E6M7zoomZJNIfNEq/ZYi8ejPQefnuzkWCG6+sZlu?=
 =?us-ascii?Q?SaQRPG5QshIodAriK2tBYpm/8UIXN8WXpgvRxGQNvsWTmfmYMlFudrvKvRBY?=
 =?us-ascii?Q?RaZttdSBoCYe4MP0mc8oiUFRC5GcxpjQQuIcGw3x3SBj1fSZFgC55l8xJq6g?=
 =?us-ascii?Q?fO3B92ocDPKVpW3b2tmIX5xsmX9We6ajiUaG0nRzzQMGlFh0KTk7GihS5B/y?=
 =?us-ascii?Q?3eXaleoCJPJQniG/lPa1jyFMeQy1rujjMxNmfPbbALZ07XGSUfOXvSSOvgAy?=
 =?us-ascii?Q?GbYvpyISSq60rsWWBlJNSnT+pKvS1ZFpOQ8vJR6WNqyZwZmLFSmQfu7dQ12I?=
 =?us-ascii?Q?FdMlkEYTT5e9rqPIffi86fs5MQNyvlOP0CxwATDuTw8d3D0/vko3oiQgh0xy?=
 =?us-ascii?Q?iXUIC5hIqjtLgq5HWVyCjR7v1DUB0+TxLCEBdpsfhVnK/SFD1O15GzqbCVcz?=
 =?us-ascii?Q?VvrsEWwQRS6gBbk8hbqRxbkqgLhBST20+ZI/sSgHzWghhDudvtGCqX2jSvEi?=
 =?us-ascii?Q?KqVP24sold3Mhpr5xAe5Osw3its8zEG9xCWMOfq2j7h0silbIYENnpv5+IsR?=
 =?us-ascii?Q?OnjoJezN4uK1qgdvWKLi5GxYJHrpnY34VCfvWOj+RQ58Vj9FgYsVas+cmgUA?=
 =?us-ascii?Q?IsW+at47F6ysEHpRcsD8JlOBpwkCtPLugoSoT12xG1q8S76ypVba0gXAN1MT?=
 =?us-ascii?Q?ICF1M1+8z1kcZmQpz7cOd8px7VQFUgGOWc1LcqOUH9U1zVOiaBRg1vYlUuq3?=
 =?us-ascii?Q?pMf5jcZ2RJbbiF4ODJHePuhZhbmeOpA3CwXvexOrk6D9tlwZF+PTeQYSpjba?=
 =?us-ascii?Q?sIsbJDZo05IiJZdy0SxJcJ9o0jPr9dLbKaTgW7zhArVBwJ1wHx+KOqeBtv5H?=
 =?us-ascii?Q?NpVgVZ2ddJRYD5vDRKxy46hNR92haFmbHISGzeXOvhb1k27pJR00ZkJ2R7w0?=
 =?us-ascii?Q?t64Sg6WllnRZ7pYJO1Vj/sZRzBTu0ZNOJsLRJnivqSNoJG5rMOmk78pDrAfh?=
 =?us-ascii?Q?MAuVzud0m7nkP79MMfSi4dzw42aetTFSoUNBSfTIxARMJWsMCDrN+3PJc+Ai?=
 =?us-ascii?Q?Imt9JUkfhozEsZ1Txmtwq7Uqjdg9VnuzhMPZqdnlBtp5V32Q+N3t7jG5hk/P?=
 =?us-ascii?Q?0rgtsP/hZGCehmhxt2HL+Iw1k/BHNrXswB9oAV41J0YqGZ8ormTkouMtSkKd?=
 =?us-ascii?Q?pb0rwvBMhTHUSXHdOaB2F8kI6sCIrcDo38rr7+yBz6EJNmmbKTqeA0tWbNLz?=
 =?us-ascii?Q?Ab85jElp+c2pDU1GMZZXp1yWY37uerzcSP7EzZ2BVTQ1EsES1DcM29wNVJlR?=
 =?us-ascii?Q?0LLb1aK7jbDsxJ5sXy1t62G63KGM72QAV1wiVtvhIagK7hbfKjflJ+sWMnUr?=
 =?us-ascii?Q?7n2JOfzzIv36hJqO8X7ncz2dC3zTAW20UfuRAbP9XOBnbuoT4PE3H+MRSxOY?=
 =?us-ascii?Q?pQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5414240-b2f0-43ae-f6a6-08dbbd7eaa85
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 04:19:53.0747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /E/9dgRke6MLkcvei4rwjYT0oDCS04hMcQ2r1aGqtVB1lsKIeq0JNWi21cJDzhPPddq0KsVHmsTg/CoKYQT7eQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8312
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 24 Sep 2023 21:20:16 -0700 (PDT)

On Sun, Sep 24, 2023 at 12:41:07AM +0000, Dr. David Alan Gilbert wrote:
> Hi,
>   I randomly noticed there are a couple of places in the kernel that
> do
>    ERR_PTR(0);
> 
> and thought that was odd - shouldn't those just be NULL's ?
> 
> 1) i915
>   drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c : 47
> 
>     if (i <= 1)
>       return ERR_PTR(0);

Yes, s/ERR_PTR(0)/ERR_PTR(NULL)/

Matt

> 
>   from f9d72092cb490 
> 
> 2) trf7970a
>   drivers/nfc/trf7970a.c : 896
> 
>       trf->ignore_timeout =
>          !cancel_delayed_work(&trf->timeout_work);
>       trf->rx_skb = ERR_PTR(0);
>       trf7970a_send_upstream(trf);
> 
>    from 1961843ceeca0
> 
> Dave
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/