Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <3d34a965-ab9c-d549-0c63-c717ab5d2edc@tweek.dk>
 <c2b92ff2-d077-4588-9d5c-93dfec0037ee@mailbox.org> <b85bf040-f6be-ef12-5b33-6d41991e4d97@tweek.dk>
 <CAK7LNAQVuKQ34xK8AA9M0dytb1zNpE+rUYDhi6kGDO60SYBpyw@mail.gmail.com>
 <d0016504-af19-eab5-8898-f51a8c8abdcd@tweek.dk> <CAK7LNARKiu54dRK9y8aRRFC_UrurE_qumXdv6TRJpzQ_AS1dwQ@mail.gmail.com>
In-Reply-To: <CAK7LNARKiu54dRK9y8aRRFC_UrurE_qumXdv6TRJpzQ_AS1dwQ@mail.gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 25 Sep 2023 16:05:35 +0900
Message-ID: <CAK7LNAQf6YVF6yCi3tRHE9Rf0o3g2MLqfiLxyJg4-fiM6ZmBZQ@mail.gmail.com>
Subject: Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules
To:     Martin Nybo Andersen <tweek@tweek.dk>
Cc:     Tor Vic <torvic9@mailbox.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Nick Terrell <terrelln@fb.com>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Lucas De Marchi <lucas.de.marchi@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 22, 2023 at 10:34=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.=
org> wrote:
>
> On Fri, Sep 22, 2023 at 8:04=E2=80=AFPM Martin Nybo Andersen <tweek@tweek=
.dk> wrote:
> >
> >
> > On Fri, 22 Sep 2023, Masahiro Yamada wrote:
> >
> > [...]
> >
> > > Hello, sorry for the delay.
> > >
> > > I am OK with picking the patch to my tree.
> >
> > Hi,
> >
> > That sound great :)
> >
> > > I think we can use --check=3Dcrc32 --lzma2=3Ddict=3D1MiB
> > > unconditionally.
> > >
> > > (But, if the in-kernel decompressor is improved
> > > to understand CRC64 in the future, we can loosen
> > > this restriction again.)
> >
> > Of course.
> >
> > > Just small change requests.
> > >
> > > Please do not use the Fixes tag to point at the Debian bug tracker.
> > >
> > >
> > > Instead, you can do
> > >
> > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1050582
> > >
> > >   or
> > >
> > > Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1050582
> > >
> > >
> > >
> > > Also, mention that this change happened in
> > >
> > > kmod commit 09c9f8c5df04 ("libkmod: Use kernel decompression when ava=
ilable")
> > >
> > > in the commit description might be helpful.
> > >
> > >
> > >
> > >
> > > I added Lukas to CC.
> > > He is the author of the change on kmod side.
> >
> > Is this ok?
>
>
> Yes, perfect!
>
> Thanks.
>


Applied to linux-kbuild. Thanks.


--=20
Best Regards
Masahiro Yamada