Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1028666rdh; Mon, 25 Sep 2023 00:30:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFP0vcDj/WjD68GsL5b0UYBb5ZYKctPm3r1E1IoTC1QdLfyv36gt4D+/7lNa6RMg2EuOGi1 X-Received: by 2002:a05:6a00:1d8a:b0:68e:25ff:613e with SMTP id z10-20020a056a001d8a00b0068e25ff613emr7102826pfw.3.1695627016709; Mon, 25 Sep 2023 00:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695627016; cv=none; d=google.com; s=arc-20160816; b=rVzjtiEzw6cip0u+DYBrNGnzPwwrHWOiGnYbe0HWykJzwl6gkFu1TA6DW5b3RI4TCh 1uooIcgd9A/ug0AAYyIEImBWpOpC/FAPxIUqbud4Y8mtrVb4E6EvdwCHFUdvkxcwm+jc V5IhWfEv4RB6sRrVLYrqRSNg9tolTGiMO3xIcdsO+jYl5T+6I+3ryOhiFuN2DCX4jJw+ IZvXjgzSYii8au4bVZumCxpKJVSDPNweaBuTrZOXR+ZRGX+TKNVyG8A2fHQuAvuRX09S z6yhueLT3BWDO0VwCjOlCG3MKmepHUbWohtAypq1mVUZ2em+KiD3N/WJD1JMnaDhRRQc qkVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=Z395Livy8ywWQH+7Oft/hdt4ClpbeXr+I39Uv6i+QQ0=; fh=tP8C7miElearLKeNdwG7wVnRIfBv898CvgVsTTJjS88=; b=jM5vXk2t8WknZ4+INHu5Dn3mi+CZSOoNMc0k+7rDp2yT/Y3GvIWqE3M3btKiBU5WQT 2CP3+5Sd1wdSEYYH7Foy6MG2o8helR4Y5OnkPmBKOH8b/4KuyYQ87MViDm2QKBhtaPFW B3FvIjvFV7Oiyq1Q5iSbKoSxNCDtjcMteh5v4DTpkC29MuoWEpehz1a151yLnCyCEe4p hgt7qGvrIy9ZB0EbPAOn+HpIiYYd+TxyUgMSb1gTmBNefhu1GqQyQFwCzc1AsMRns0lb qukOJfVYU2dLu6gCL6QgADF2CZ8wnldEMObRDnPEA94iw6fYMrfGIGJrFpBEE8PGjZuF 9AWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQb5w9gY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id h2-20020a056a00230200b0068e390d86b4si9980857pfh.133.2023.09.25.00.30.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 00:30:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WQb5w9gY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B147C80C65D0; Mon, 25 Sep 2023 00:12:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232463AbjIYHMX (ORCPT + 99 others); Mon, 25 Sep 2023 03:12:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232501AbjIYHMT (ORCPT ); Mon, 25 Sep 2023 03:12:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99BF3136; Mon, 25 Sep 2023 00:12:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90360C433CD; Mon, 25 Sep 2023 07:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695625931; bh=6Dr90FXidnenbYzY2VdDgQp3Cbw7imf3JMYhlHYthww=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WQb5w9gYIlCIasAEgSIf/oexPVyKpMoDU3WbMlURebjGMkLD+r3bNQFYG/y+duPdX 0cA9uDSBgdeaSBjuU8ziiOcXE+fkmTL+zstI0COL+dM44AbsCvK5nnV+eNc7ojcwXV pL0lyfQFn4rABMpqKf2TgdgwNue6kaxZ4geygT7WMZUYMkYzKG3asUe+nZazoHPusm vJkU7HLIoX/68tXJ4EspOHRJZ+/tcPHHDDrCOIWjGmnF4Vh+dnliux82QJLM5KY3uG XUsIh4YIj+HcR9oQm/vSU0XczCUBH9vga4xRKk7Z2xMIgmRBRf2DKf3OvzUpJOagsb wctBwxf4RyV3w== Message-ID: Date: Mon, 25 Sep 2023 09:12:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] ata: libata: increase PMP SRST timeout to 10s Content-Language: en-US To: Matthias Schiffer Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 00:12:22 -0700 (PDT) On 2023/09/22 22:55, Matthias Schiffer wrote: > On certain SATA controllers, softreset fails after wakeup from S2RAM with > the message "softreset failed (1st FIS failed)", sometimes resulting in > drives not being detected again. With the increased timeout, this issue > is avoided. Instead, "softreset failed (device not ready)" is now > logged 1-2 times; this later failure seems to cause fewer problems > however, and the drives are detected reliably once they've spun up and > the probe is retried. > > The issue was observed with the primary SATA controller of the QNAP > TS-453B, which is an "Intel Corporation Celeron/Pentium Silver Processor > SATA Controller [8086:31e3] (rev 06)" integrated in the Celeron J4125 CPU, > and the following drives: > > - Seagate IronWolf ST12000VN0008 > - Seagate IronWolf ST8000NE0004 > > The SATA controller seems to be more relevant to this issue than the > drives, as the same drives are always detected reliably on the secondary > SATA controller on the same board (an ASMedia 106x) without any "softreset > failed" errors even without the increased timeout. > > Fixes: e7d3ef13d52a ("libata: change drive ready wait after hard reset to 5s") > Signed-off-by: Matthias Schiffer Applied to for-6.6-fixes. Thanks ! -- Damien Le Moal Western Digital Research