Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 25 Sep 2023 16:08:46 +0900
Message-ID: <87msxau3up.wl-ysato@users.sourceforge.jp>
From:   Yoshinori Sato <ysato@users.sourceforge.jp>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
        linux-sh@vger.kernel.org, Rich Felker <dalias@libc.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()
In-Reply-To: <CAMuHMdXFSvyTGvYrc2af_Bba9hHNQ-taufOMXRPrKJGNiCP8mw@mail.gmail.com>
References: <20230802184849.1019466-1-arnd@kernel.org>
        <20230802184849.1019466-4-arnd@kernel.org>
        <CAMuHMdVjmD357K-yxxW-jn-6vKsXTg+u1Psw9DftyxH=dQoMEg@mail.gmail.com>
        <5dad2d86-78ea-4a39-8ee1-98e3eb134d36@app.fastmail.com>
        <CAMuHMdVYcvPL+JpPw9sA48=615cdfwa8d0LP-bVp0NWqbQ+JOw@mail.gmail.com>
        <190041c8-2d99-4bc3-adc3-6fbe902c1265@app.fastmail.com>
        <CAMuHMdXyLHitBWOMp74cqtJbSs6q_4sPOEee+x72tE-E2G-KWg@mail.gmail.com>
        <d2f5cdc1-4bff-4f1d-a7b2-38eee6a6a86d@app.fastmail.com>
        <f61e1f218ee4d5a87121c0e5ee0d8694364ea2dd.camel@physik.fu-berlin.de>
        <CAMuHMdXFSvyTGvYrc2af_Bba9hHNQ-taufOMXRPrKJGNiCP8mw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, 21 Sep 2023 17:52:29 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Adrian,
> 
> On Thu, Sep 21, 2023 at 9:45 AM John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de> wrote:
> > On Fri, 2023-09-15 at 17:49 +0200, Arnd Bergmann wrote:
> > > On Fri, Sep 15, 2023, at 17:41, Geert Uytterhoeven wrote:
> > > > On Wed, Sep 13, 2023 at 4:30 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > > > > On Wed, Sep 13, 2023, at 16:13, Geert Uytterhoeven wrote:
> > > > >
> > > > > Right, it looks like the GENERIC_IOMAP part if gone from that
> > > > > series, and I also see that the PCI host bridge does not actually
> > > >
> > > > No, 02/30 still enables it.
> > >
> > > Ok.
> > >
> > > > > map the port I/O window. That's usually fine because very few
> > > > > drivers actually need it, and it also means that there should be
> > > > > no need for GENERIC_IOMAP or the simpler alternative.
> > > > >
> > > > > The first version probably only did it accidentally, which is a
> > > > > common mistake, and I think the ones for hexagon, m68k, and
> > > > > mips can probably be removed as well with some simplifiations.
> > > >
> > > > When not selecting GENERIC_IOMAP in v2, the build fails with:
> > > >
> > > > sh4-linux-gnu-ld: lib/devres.o: in function `pcim_iomap_release':
> > > > devres.c:(.text+0x234): undefined reference to `pci_iounmap'
> > >
> > > Odd, that one is provided based on CONFIG_GENERIC_PCI_IOMAP
> > > and should be provided by common code, despite the similar
> > > naming this is unrelated to CONFIG_GENERIC_IOMAP.
> >
> > So, what would be the suggestion now to move forward? Shall I include this
> > series for 6.7 or better wait until after Yoshinori's series to convert
> > to device tree has been merged?
> 
> I think including Arnd's cleanups (that is, his v2) in v6.7 is fine.
> Sato-san's series needs more work, and is easy to fix for Arnd's cleanup
> (just provide sh_io_port_base unconditionally).

For devicetree support, we have been using GENERIC_IOMAP and GENERIC_PCI_IOMAP.
This change has no effect, so it's okay to be merged first.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Yosinori Sato