Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 09/12] iommu: Make iommu_queue_iopf() more generic
Thread-Topic: [PATCH v5 09/12] iommu: Make iommu_queue_iopf() more generic
Thread-Index: AQHZ5unyZ2I6PTvmrEWL5YfID2rsELArKpdw
Date:   Mon, 25 Sep 2023 06:49:03 +0000
Message-ID: <BN9PR11MB527624D70225AB2B4DA89B3C8CFCA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230914085638.17307-1-baolu.lu@linux.intel.com>
 <20230914085638.17307-10-baolu.lu@linux.intel.com>
In-Reply-To: <20230914085638.17307-10-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UAfgQQKRUf6SwbIUbCM3+sb+dTr73kJR72Yw6kTKbKwvWN4bCDWDzaUq4lV+?=
 =?us-ascii?Q?iQ23L94h0Di587Wxa/CaWzj9erWSUKvXx5S4CtbmeJy/i0ATGWhW6N/RGZuo?=
 =?us-ascii?Q?4PGWaYnFldKpaacURL3wylqdP08/pZ7S/d9WBuefr2I2cvHdgH0nEjbUxOLE?=
 =?us-ascii?Q?zwzYLfzshq1l0/ZoNo3W+CVSGwlV2H60genZSJvAOR0BnLludCnyGXvhwSXL?=
 =?us-ascii?Q?Kzi5/m3te0z8FYOFOBdLZZGIXyGvVgviQCrzNwCAaP8PXsjzAqe/KR9vJp6r?=
 =?us-ascii?Q?cflNceOaS2deWbR5dOef8Biyiu0hrBzRUbG1M1IbYX71c5SZ290O4ufEIQKv?=
 =?us-ascii?Q?O49AiuO7G6hMdM9c6QWrc8/2GowFo7CHNEMlRnfW0KSkgwVgIKRfvd/GT7N5?=
 =?us-ascii?Q?XoBSNW0xgtc0K7ZEekc32cSUPoEdQHTOrhdlMVK8lzcVflKn5HjusqO6GRwd?=
 =?us-ascii?Q?1qFtIYIn5fCtY4zjLQ8i374eWYm+zADR0bWXdXZMJSebKk8xtX60iQN4lJfc?=
 =?us-ascii?Q?TquSovMaWiDpv/Lpq8JAZll4aJOrv0vqNHrz0PR1B1ap2ItFltZE90F69aVW?=
 =?us-ascii?Q?aF/s7ukHv8d6fF4r+ChXibJbz95VjaYWkcHl+TuhoT/0vT3tJB/tnDigfIEl?=
 =?us-ascii?Q?xlLvQpNDV8s/R+8JoVu0sIAoq4D6NxfnaIF4em8mHKDVEfcbcBT50QudbT+Q?=
 =?us-ascii?Q?1D0R+7El/rwotB0TU2nPwM3Pe9O+KxFJA6B0JF22/bBlHrxyeySK70dhCMj4?=
 =?us-ascii?Q?VGiZCVYMum8aB32kgl3KgEI+5PHBGW9QfwHBPi+HXv1o8UTAETtLpilxEv7u?=
 =?us-ascii?Q?yZxXdsqe0l3eHn5K8R48q9VuWkXasV4XgHmhqtgqQ+KZsSgKVNuf8wjQ3jPQ?=
 =?us-ascii?Q?S3Gm0hsaiYQUjct/C7VHDNmKLUMF0siSltf9GsCi/nahMMnx/3PF31H5qNAx?=
 =?us-ascii?Q?Mf93DGMW6sWCpbBnLDFSeJAvthe6LClweFAvrPkjnR4qYfeN3dqkVB+Ypr3R?=
 =?us-ascii?Q?ATpv8v2kwL3WBVOgp/LY1zfGQnMi3ExQLnAPbTAgcc8i/PNQq8rP8KiS0Pqs?=
 =?us-ascii?Q?uFDS1mT/lz5kJDYqWJ7udsbDtqOvMHtvs7YMrNwBOY14kLzm10wYIgE23n7N?=
 =?us-ascii?Q?kfPIKGYT8KqihxyXo2tq6EM5iZIbVX9b9+M5VCM/muMRQ9i1J/NkPayfNOsi?=
 =?us-ascii?Q?BPQPUT7JM6DvaiQx27G4QVrYUH0cc3ig+6GUoa706sEqsAEHlXN02b2av0Gy?=
 =?us-ascii?Q?ZGJch2g71htTUsdG7SP2uPQNTbyKemWNHVfnFVEAC4ng3eUbYw26gqFJTMBf?=
 =?us-ascii?Q?/klwQycnWPYaKtlFhzByDezRw5oMUIGE1Zwcv8Uhsngleg3GuCNVTLwHNb5M?=
 =?us-ascii?Q?DVqg14gs59J6OFqcct+Ppnv3sO+jDaHAC7o26lad/CUA0sD1FunmKZdt41j5?=
 =?us-ascii?Q?62KMx39m6p99cg8DxVqUMf3FQ4DerSdYbOcamlKXEmNbvw+ZA0AojuV/37xD?=
 =?us-ascii?Q?n06EvOiOmt5Nk3Pv6zfkZmRmVBqaPTA8VMw5b1rxvvm/lc9HSTJoV1svPDpa?=
 =?us-ascii?Q?NqNAUOUXDsR62gBTrcHEVBJw0qFcXVDVIi+aPBfk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a269250d-f646-4178-d3e9-08dbbd9381e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2023 06:49:03.9726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gXQcjH6Sn0mByGovXU+rwvusM5Hh4dZXUluccxkNyVfzFOsnYeogXONtaofZqjyuFNb6rndWazS/fWpp3qvCfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5556
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 24 Sep 2023 23:50:39 -0700 (PDT)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, September 14, 2023 4:57 PM
>=20
> Make iommu_queue_iopf() more generic by making the iopf_group a
> minimal
> set of iopf's that an iopf handler of domain should handle and respond
> to. Add domain parameter to struct iopf_group so that the handler can
> retrieve and use it directly.
>=20
> Change iommu_queue_iopf() to forward groups of iopf's to the domain's
> iopf handler. This is also a necessary step to decouple the sva iopf
> handling code from this interface.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

With the fix of domain error check:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>