Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   <Shravan.Chippa@microchip.com>
To:     <conor@kernel.org>
CC:     <green.wan@sifive.com>, <vkoul@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <palmer@dabbelt.com>,
        <paul.walmsley@sifive.com>, <conor+dt@kernel.org>,
        <palmer@sifive.com>, <dmaengine@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <Nagasuresh.Relli@microchip.com>,
        <Praveen.Kumar@microchip.com>, <Conor.Dooley@microchip.com>
Subject: RE: [PATCH v1 3/3] dmaengine: sf-pdma: add mpfs-pdma compatible name
Thread-Topic: [PATCH v1 3/3] dmaengine: sf-pdma: add mpfs-pdma compatible name
Thread-Index: AQHZ7TpYtoHe5V6jCkaV0cVSgcPUurAmncAAgARoOAA=
Date:   Mon, 25 Sep 2023 05:22:03 +0000
Message-ID: <PH0PR11MB561127E9DFD6986C6479CC6B81FCA@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20230922095039.74878-1-shravan.chippa@microchip.com>
 <20230922095039.74878-4-shravan.chippa@microchip.com>
 <20230922-sappy-huddle-1484d64b27f3@spud>
In-Reply-To: <20230922-sappy-huddle-1484d64b27f3@spud>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0uPsDPrbc5/BY5QPKKeX86SIJweJa14tcMNIPfHWaFzHCd0YCTt+ff/C5oRc?=
 =?us-ascii?Q?H7ma5E1WLFVDnoMX9jFBbN4OmnhqkXsxLdCALQKsn2mRNjdP8OJDVtJqYIIl?=
 =?us-ascii?Q?TDtlOMXi01CnDZGtN6doBZNT4x+Yr5aX6ec/A26zFHoRaD9eQXovBgRsnKCd?=
 =?us-ascii?Q?AHmr2JRDD0Fmf0PR1yl/ZGgXZRzNWen+4djKF/zfDs/Z7vqGb8WRGr2jhIFD?=
 =?us-ascii?Q?jqfjhFDwnQW0MkJO+2BkG5pQUY6TKFzn4z4uLBU2QSiCTJTyaewopkMs3Slg?=
 =?us-ascii?Q?EjDmsAjIaN/+p83ZENTjYDpMEcB8FxglS3TyEk4AV30T/pw0sLp7f8Cqqf69?=
 =?us-ascii?Q?VNbT6Nr6P2Z3UYwXyN1eEM0fxqGezQ14jb89cY0bt43dIloK4lq9hrV1Arfi?=
 =?us-ascii?Q?ubUNcCwK/K13gVVA95WdydhlczoharfGQ/Kqsjy0zC9Ftpp0pA8r1WfF96da?=
 =?us-ascii?Q?cfJIhSwm227FnXLKETRVfdio19JRr85FPRvVE5qYZSBhvCWIjg3gMUe+WvB9?=
 =?us-ascii?Q?7hRbIiTUA/8kXtBlw4K7bovz++EWpG1+uXSnQTiMnKUbdXoQCka/SVeyF2XA?=
 =?us-ascii?Q?0qK3twzHeVHlzn5ZRM4L8I12Cp5kI5eL/TL1V82oE1B0dU+T2W/Dms3+iNA1?=
 =?us-ascii?Q?Lpl5yICUwld/BsAFv1mBhNn2ef5Aiya0MNPMIYVOI0KzvwUTYrcXY7hQ3Q/c?=
 =?us-ascii?Q?2tXyXRMmfrXtpQO2PhSjD9qOkqrq5zAboYmUaL2EhyEr5+vPp7lDW7IaDOBu?=
 =?us-ascii?Q?w9f0s28lhhNkH6aRiuKiI+tNHi7uafE9FT0JL9xAd9VphNOEPANbVkZyVRqd?=
 =?us-ascii?Q?FnUvbiy+izKqkgk0tUUPkXbQCDd3jVT+mHiyfOh7hiY4IJ3lTgOZjN8dm00V?=
 =?us-ascii?Q?ZGQE6Xl5RRjnousQhjumH+QRjy1ZSYlo/7QLCCzs1fz+RTRT/YX3fpz0CF/F?=
 =?us-ascii?Q?1cRfIEoVjV0HNW+dAJqNBi2sD/X6VKj3pqlQTIi8YczpDVov5Ekiq7tAV1lb?=
 =?us-ascii?Q?IYnH1qmzMiiKWXBqXeDp+jn5PeBq0iR2LZCHUaQ4dkdFpWzX1zrp3bJ8jW7I?=
 =?us-ascii?Q?GOk5U+oeE57jjoTFCzFuApGbq86T4jwHvWt885NQ+UrwTHpoqgIEgTP6+wE8?=
 =?us-ascii?Q?1iEYBga3VfU/JSp/oPhgIzZdcUUipvYuJdnNVoYHUL6ukTreuWXuDaqdwKjE?=
 =?us-ascii?Q?dbdbhyuI56dQSmM61epxLbD68/yIdEEXw+4hEp4CXbCLoPzoh0uPX4vViheL?=
 =?us-ascii?Q?M5I4wndRomUl1VwbXjjzxxeqRoZMZb5SwsxKR9UcIDIiskM4dtRKbp2iTxr0?=
 =?us-ascii?Q?fAF7qguTbhFSomPSg9DE/CmToUd7Vk+g88SpyFXHngVCO6E0rrIysm7vEzXJ?=
 =?us-ascii?Q?uzYJuDZ8nLStPn0JkFIhOE5wqu/D5pC5Jgnwf+Y0hP86Ip9j2U9pK+yaOVqj?=
 =?us-ascii?Q?yM85Ru0Hz/b0zOZDH4/DxhXSTMchwA7UylFNCOQW322zOHjAfuuLBEG0aD3E?=
 =?us-ascii?Q?wB5HWdsNxxrhfrKZyKfrSStjyx8TzjYFNSjUS4SFe7zItObkIMv1EjnXT+Cd?=
 =?us-ascii?Q?tx5iDSDCv2RQgtVl1NnSpYE+93zmTdOxLzpVNGJbqk/jhCajQlAInPf6/3Y8?=
 =?us-ascii?Q?DA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18b3e43a-b1d0-4f8b-7cf0-08dbbd875a0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2023 05:22:03.1696
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UegKb9uWY86qhUtZ6zb8P7hxrxTIYWjDYAKfEa5RaG7xKV87yoP4Nn6+JfRLgVEi6qk1oPZenTu6GjbuDKUFO4j29XeEvMLJEl+iTk+P0bg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4631
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 24 Sep 2023 22:22:27 -0700 (PDT)


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, September 22, 2023 3:34 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> Cc: green.wan@sifive.com; vkoul@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; palmer@dabbelt.com;
> paul.walmsley@sifive.com; conor+dt@kernel.org; palmer@sifive.com;
> dmaengine@vger.kernel.org; devicetree@vger.kernel.org; linux-
> riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Nagasuresh Relli=
 -
> I67208 <Nagasuresh.Relli@microchip.com>; Praveen Kumar - I30718
> <Praveen.Kumar@microchip.com>; Conor Dooley - M52691
> <Conor.Dooley@microchip.com>
> Subject: Re: [PATCH v1 3/3] dmaengine: sf-pdma: add mpfs-pdma compatible
> name
>=20
> Hey Shravan,
>=20
> On Fri, Sep 22, 2023 at 03:20:39PM +0530, shravan chippa wrote:
> > From: Shravan Chippa <shravan.chippa@microchip.com>
> >
> > Sifive platform dma does not allow out-of-order transfers,
>=20
> Can you remind me why we determined that this was the case?
> IOW, why could we not enable the out-of-order transfers and get a
> performance benefit for everyone? It's been a year or so (I think) and I =
have
> forgotten.
>=20

I will try to modify the commit message.

Thanks,
Shravan

> Cheers,
> Conor.
>=20
> > buf out-of-order dma has a significant performance advantage.
> > Add a PolarFire SoC specific compatible and code to support for
> > out-of-order dma transfers
> >
> > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> >  drivers/dma/sf-pdma/sf-pdma.c | 27 ++++++++++++++++++++++++---
> > drivers/dma/sf-pdma/sf-pdma.h |  6 ++++++
> >  2 files changed, 30 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/dma/sf-pdma/sf-pdma.c
> > b/drivers/dma/sf-pdma/sf-pdma.c index c7558c9f9ac3..992a804166d5
> > 100644
> > --- a/drivers/dma/sf-pdma/sf-pdma.c
> > +++ b/drivers/dma/sf-pdma/sf-pdma.c
> > @@ -21,6 +21,7 @@
> >  #include <linux/dma-mapping.h>
> >  #include <linux/of.h>
> >  #include <linux/of_dma.h>
> > +#include <linux/of_device.h>
> >  #include <linux/slab.h>
> >
> >  #include "sf-pdma.h"
> > @@ -66,7 +67,7 @@ static struct sf_pdma_desc
> > *sf_pdma_alloc_desc(struct sf_pdma_chan *chan)  static void
> sf_pdma_fill_desc(struct sf_pdma_desc *desc,
> >  			      u64 dst, u64 src, u64 size)
> >  {
> > -	desc->xfer_type =3D PDMA_FULL_SPEED;
> > +	desc->xfer_type =3D  desc->chan->pdma->transfer_type;
> >  	desc->xfer_size =3D size;
> >  	desc->dst_addr =3D dst;
> >  	desc->src_addr =3D src;
> > @@ -520,6 +521,7 @@ static struct dma_chan *sf_pdma_of_xlate(struct
> > of_phandle_args *dma_spec,
> >
> >  static int sf_pdma_probe(struct platform_device *pdev)  {
> > +	const struct sf_pdma_driver_platdata *ddata;
> >  	struct sf_pdma *pdma;
> >  	int ret, n_chans;
> >  	const enum dma_slave_buswidth widths =3D @@ -545,6 +547,14 @@
> static
> > int sf_pdma_probe(struct platform_device *pdev)
> >
> >  	pdma->n_chans =3D n_chans;
> >
> > +	pdma->transfer_type =3D PDMA_FULL_SPEED;
> > +
> > +	ddata  =3D of_device_get_match_data(&pdev->dev);
> > +	if (ddata) {
> > +		if (ddata->quirks & NO_STRICT_ORDERING)
> > +			pdma->transfer_type &=3D ~(NO_STRICT_ORDERING);
> > +	}
> > +
> >  	pdma->membase =3D devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(pdma->membase))
> >  		return PTR_ERR(pdma->membase);
> > @@ -629,11 +639,22 @@ static int sf_pdma_remove(struct
> platform_device *pdev)
> >  	return 0;
> >  }
> >
> > +static const struct sf_pdma_driver_platdata mpfs_pdma =3D {
> > +	.quirks =3D NO_STRICT_ORDERING,
> > +};
> > +
> >  static const struct of_device_id sf_pdma_dt_ids[] =3D {
> > -	{ .compatible =3D "sifive,fu540-c000-pdma" },
> > -	{ .compatible =3D "sifive,pdma0" },
> > +	{
> > +		.compatible =3D "sifive,fu540-c000-pdma",
> > +	}, {
> > +		.compatible =3D "sifive,pdma0",
> > +	}, {
> > +		.compatible =3D "microchip,mpfs-pdma",
> > +		.data	    =3D &mpfs_pdma,
> > +	},
> >  	{},
> >  };
> > +
> >  MODULE_DEVICE_TABLE(of, sf_pdma_dt_ids);
> >
> >  static struct platform_driver sf_pdma_driver =3D { diff --git
> > a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h
> index
> > 5c398a83b491..3b16db4daa0b 100644
> > --- a/drivers/dma/sf-pdma/sf-pdma.h
> > +++ b/drivers/dma/sf-pdma/sf-pdma.h
> > @@ -49,6 +49,7 @@
> >
> >  /* Transfer Type */
> >  #define PDMA_FULL_SPEED					0xFF000008
> > +#define NO_STRICT_ORDERING				BIT(3)
> >
> >  /* Error Recovery */
> >  #define MAX_RETRY					1
> > @@ -112,8 +113,13 @@ struct sf_pdma {
> >  	struct dma_device       dma_dev;
> >  	void __iomem            *membase;
> >  	void __iomem            *mappedbase;
> > +	u32			transfer_type;
> >  	u32			n_chans;
> >  	struct sf_pdma_chan	chans[];
> >  };
> >
> > +struct sf_pdma_driver_platdata {
> > +	u32 quirks;
> > +};
> > +
> >  #endif /* _SF_PDMA_H */
> > --
> > 2.34.1
> >