Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <740a4ede-4eaa-2775-ac31-3fa7c905e201@intel.com>
Date:   Mon, 25 Sep 2023 14:39:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 4/6] iommufd/hw_pagetable: Support allocating nested
 parent domain
Content-Language: en-US
To:     Baolu Lu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
        <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>
CC:     <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <joao.m.martins@oracle.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-5-yi.l.liu@intel.com>
 <7d07bea9-02a5-7113-8cc1-f7aed073cf96@linux.intel.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <7d07bea9-02a5-7113-8cc1-f7aed073cf96@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkpMNm5rOEZ3UEVkNmNoeUxLZVFOUnB2a3pZa2Y0WTFvZ3kzU1FCcHZlZ3Zt?=
 =?utf-8?B?ZHQwdTZsN01LYjg1K3V6NkUycjd5WmFYaWw1RGdqa29Hc3dkUjczeWJCRnY1?=
 =?utf-8?B?R2dJRk50SVB4YUR0UCtaMmFYUnJXYnJjSUZDYWhpSEIxd3lYYXlYRG0vUHlW?=
 =?utf-8?B?YmhuMDhQODlnY3J1QStBNCtZcHplb1pKU2NYSzZrWDlwMDkza3hkSFR5UW9j?=
 =?utf-8?B?TDM0ZDUyNHFCOWVteWdZOWQvcDZabkNCMFg5RlF4enRpKzdydHhoa2tWUzRv?=
 =?utf-8?B?WVR5Ni90STcrSWpYTFVYVzAzRVlvbjI1YVZtQldUYnZ5SWtla25YalF5Uy9I?=
 =?utf-8?B?aC9ERHpOR1hYRHN6dmR1bjFmLzQ0a3pGM00vamlVZkpJcnRpU3I5ZkpOcGk0?=
 =?utf-8?B?Wjl4V2lPOXZjMnZ5SjRwQ29HZitEdXo4SVJacEVCVVpMOGxKdm8raVhLSlhx?=
 =?utf-8?B?S2ZrTWlVR0Z3L2RZa3RQeVR4OTl5cEJSRkI4UzF0b29KWnloTkRRS1psb0lR?=
 =?utf-8?B?VURyaXdya1ZpdVd2YnNnTFV4bllpc0tFaXNkVVRlM0Y3cXBjU3IwVG9JSlNa?=
 =?utf-8?B?STN3dmpCYm91Znc5SUJYcUJ1SU8xY3F2Q0pza3lpUGozamZPaHFlVDNwV3px?=
 =?utf-8?B?TDBUSGEyQTlISk56KzByZ0h6bFBTclk1S0lOeTVDc2F1U0pRL3hZK1g4SDB6?=
 =?utf-8?B?Yk01MWRrd1dBamcyTTVLOFkwSEFCM0szZFNzaHhXbTRRZ3AwZ1VKNUJnaTdC?=
 =?utf-8?B?b0x2Yy9VaU1zVWdIdWsva1d1TGh4eGZpSU9Yd1dQUld1NXh4VW1tMFdQOGQ0?=
 =?utf-8?B?NlBqTTh0UEUza1dObzB5bzRveE5MWWppN3F3T2ZMRnJCdXkvUjBZWU42Nm1i?=
 =?utf-8?B?eTRpdWxGRmV6YXFDaFRaZzBqUm5aUEZBdHlEcDRNZnUwVHdQVTBZZUVESit3?=
 =?utf-8?B?ckRQV3Jqb21XZjJqZ2dHdUJBajI3djhYcW9vUmExaDU0UzBUci96OHhtWk9p?=
 =?utf-8?B?ZUJCS2lvejd2VmVsRjlOR2pLbTVMTmpVVmV6NTJMb21wUXBOM1NEbW41cTZ2?=
 =?utf-8?B?LzhMbG5XRDQreDFMVHNHcmJQYTBCM1RhdGU3NnNzcEJkbTF3bXl4Ly9SUFgv?=
 =?utf-8?B?dkdHL2dTSWI0TXhPTmY1QlF0bHJJNVNkRWFFcndPZHdhdkhRY2ZPNSs4czBU?=
 =?utf-8?B?azdqQ3VLbnZtb2NNZGU4ZGZXY3h0SWx4UUNSMzVzWlpVRmF1L2wxOUl1UWR1?=
 =?utf-8?B?endYY1pId3NqWDFFbFZieEVQYzIrWXBrbmNPREJad3FvT3VNZ0M5c1FtVGx2?=
 =?utf-8?B?RUdzMFFGdm1jejU2bDVVdEVpdXNKK0VkaVJsck9iQ2dhT3hqenVhUjh1bVBF?=
 =?utf-8?B?My9oTUdPUzNaMC9Jc0E2TUFmTHowb25nSzNxbmVvYTl1MnN2MDYvZzVBV3ZI?=
 =?utf-8?B?L3oyTzZ5elRFTmVuSGZaMTI0ZkRSTzNWc2VXaUU0ZHVTRjM2a0wvbEtob2xO?=
 =?utf-8?B?UjFvempaZnBCbXA5TG9OT0R4OEFrQnRrSW5OUmRmVVczaTJwRFJ0TDNYQXVs?=
 =?utf-8?B?K2U2NGM2QmxzenBTV1lQZmVONWttSEtHVDhHd0M5VEowREtzREZaSWwwQ01p?=
 =?utf-8?B?T3Z5dXBTaXhCaGVFMUxkdE1HektMSEZYMEFWbmJidlRCTEtaVjVYdzRrVjgv?=
 =?utf-8?B?Wm5zUStEWkhGcHkxTGt0RFFJY082Mk5RY05Remx5Qkk4L0hKY3NQTDcvMzFn?=
 =?utf-8?B?ZjArSWc0bnZoNm5zYXF3cFlBcEsrVW5sZEo2ZWF3S2hwcVV5UjQrR3JoSWkx?=
 =?utf-8?B?Z0xTOU9lUUp6bzZhVmQvYnd2dmU0ODFTVllxSjIvL0ZRQXR3S2ZEbVV5Z0xK?=
 =?utf-8?B?NkpkQkxRR1I1Q2UrN2lrc3c2SFpIYUJFV01MazZaWlJVd1hxbGtOeWxsOGJI?=
 =?utf-8?B?SjVUNjE4WnFlTG9hZCtLV2xRNU5adURZaytWNWR5NzNTdW5SdDMzRGlsSXRV?=
 =?utf-8?B?MlRZc2ZYS0prd1FmSUVHcXowT2wzdUdsSVdTd0tzM05SQkhSRGQ3V0I0RWJK?=
 =?utf-8?B?bUg1dlpxeHN4NkhKQ2ZXamNpU0pvOXIrQ1VEUUpCTEQ5Uy9tR1NiUmEvTVoy?=
 =?utf-8?Q?lGnNrLlw37ncbDH0x7mchRH+l?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 63ffbd7a-8d60-445f-c766-08dbbd91e43a
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 06:37:30.3087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uZetsmvOt1frGe+8vW+L5LoUswYpQ2Vxq2/qYjleYNhN1vXq9fsvxEiI9BSbWz0EFfeZb/CNWB0aSlX5G7Ov6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6090
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 24 Sep 2023 23:37:44 -0700 (PDT)

On 2023/9/20 13:05, Baolu Lu wrote:
> On 9/19/23 5:25 PM, Yi Liu wrote:
>> This extends IOMMU_HWPT_ALLOC to allocate domains used as parent (stage-2)
>> in nested translation.
>>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   drivers/iommu/iommufd/hw_pagetable.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/iommufd/hw_pagetable.c 
>> b/drivers/iommu/iommufd/hw_pagetable.c
>> index 5be7a31cbd9c..26a8a818ffa3 100644
>> --- a/drivers/iommu/iommufd/hw_pagetable.c
>> +++ b/drivers/iommu/iommufd/hw_pagetable.c
>> @@ -83,6 +83,9 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx, 
>> struct iommufd_ioas *ioas,
>>       lockdep_assert_held(&ioas->mutex);
>> +    if ((flags & IOMMU_HWPT_ALLOC_NEST_PARENT) && !ops->domain_alloc_user)
>> +        return ERR_PTR(-EOPNOTSUPP);
>> +
>>       hwpt = iommufd_object_alloc(ictx, hwpt, IOMMUFD_OBJ_HW_PAGETABLE);
>>       if (IS_ERR(hwpt))
>>           return hwpt;
>> @@ -154,7 +157,7 @@ int iommufd_hwpt_alloc(struct iommufd_ucmd *ucmd)
>>       struct iommufd_ioas *ioas;
>>       int rc;
>> -    if (cmd->flags || cmd->__reserved)
>> +    if (cmd->flags & ~IOMMU_HWPT_ALLOC_NEST_PARENT || cmd->__reserved)
>>           return -EOPNOTSUPP;
> 
> Need a parenthesis here, otherwise the compiler will interpret it as a
> different condition.
> 
>      if ((cmd->flags & ~IOMMU_HWPT_ALLOC_NEST_PARENT) || cmd->__reserved)
>          return -EOPNOTSUPP;

ok.

-- 
Regards,
Yi Liu