Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <a6513431-0a69-445e-9211-28a9dc9691d1@arm.com>
Date:   Mon, 25 Sep 2023 09:58:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: linux-next: Signed-off-bys missing for commit in the mm-hotfixes
 tree
Content-Language: en-GB
To:     Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20230925075026.2a6b4e65@canb.auug.org.au>
 <20230924164201.863ad5e63a2d555f6d33254c@linux-foundation.org>
From:   Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <20230924164201.863ad5e63a2d555f6d33254c@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/09/2023 00:42, Andrew Morton wrote:
> On Mon, 25 Sep 2023 07:50:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>> Hi all,
>>
>> Commit
>>
>>   48248e468270 ("mm: hugetlb: add huge page size param to set_huge_pte_at()")
>>
>> is missing Signed-off-bys from its author and committer.
>>
>> It looks like the commit message has been truncated.
> 
> Ah, thanks.  The changelog has a stray ^---$:
> 
> : If CONFIG_DEBUG_VM is enabled, we do at least get a BUG(), but otherwise,
> : it will dereference a bad pointer in page_folio():
> : 
> :     static inline struct folio *hugetlb_swap_entry_to_folio(swp_entry_t entry)
> :     {
> :         VM_BUG_ON(!is_migration_entry(entry) && !is_hwpoison_entry(entry));
> : 
> :         return page_folio(pfn_to_page(swp_offset_pfn(entry)));
> :     }
> : 
> : 
> : Fix
> 
> <chomp>
> 
> : ---
> : 
> : The simplest fix would have been to revert the dodgy cleanup commit
> : 18f3962953e4 ("mm: hugetlb: kill set_huge_swap_pte_at()"), but since
> : things have moved on, this would have required an audit of all the new
> : set_huge_pte_at() call sites to see if they should be converted to
> : set_huge_swap_pte_at().  As per the original intent of the change, it
> : would also leave us open to future bugs when people invariably get it
> : wrong and call the wrong helper.
> 
> That's actually from the [0/n] intro, which I pasted into the [1/n]
> changelog.
> 
> It gets through my scripts OK
> (https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-hugetlb-add-huge-page-size-param-to-set_huge_pte_at.patch),
> but it looks like git-quiltimport did the deed.
> 
> Let me add a check for that...

I don't think there is any action for me here? (except possibly, never use 3
dashes in a row on any future email correspondence). Shout if you need anything.