Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <3241c1386e1ba0bc288496a36365bd764e17fdae.1695368979.git.geert+renesas@glider.be>
In-Reply-To: <3241c1386e1ba0bc288496a36365bd764e17fdae.1695368979.git.geert+renesas@glider.be>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Mon, 25 Sep 2023 08:43:41 +0100
Message-ID: <CA+V-a8vK7-98aHZUBMpNpyehjG8pYf_0Vu8NmWq5bS3-eWTRKQ@mail.gmail.com>
Subject: Re: [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data()
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 22, 2023 at 9:09=E2=80=AFAM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Use the existing irq_data_get_irq_chip_data() helper instead of
> open-coding the same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-re=
nesas-rzg2l.c
> index 4bbfa2b0a4df9b83..c0f3c09affa64511 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -131,7 +131,7 @@ static void rzg2l_irqc_irq_enable(struct irq_data *d)
>
>         if (hw_irq >=3D IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) {
>                 struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d);
> -               unsigned long tint =3D (uintptr_t)d->chip_data;
> +               unsigned long tint =3D (uintptr_t)irq_data_get_irq_chip_d=
ata(d);
>                 u32 offset =3D hw_irq - IRQC_TINT_START;
>                 u32 tssr_offset =3D TSSR_OFFSET(offset);
>                 u8 tssr_index =3D TSSR_INDEX(offset);
> --
> 2.34.1
>