Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1140425rdh; Mon, 25 Sep 2023 04:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExIwJAXpczO3rakOlVi66UYr6inuTMJcrVnMWBtCZc2O2qx4s7tID3ExeWRIMPBHcU2lb7 X-Received: by 2002:a05:6830:3492:b0:6c4:eea8:cf13 with SMTP id c18-20020a056830349200b006c4eea8cf13mr1834077otu.27.1695642110869; Mon, 25 Sep 2023 04:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695642110; cv=none; d=google.com; s=arc-20160816; b=xcAxp1UEKux2yZBm6OH5mrCDPfDbijDjvQIGNC4LiSH9wkQbRt/uyui3M4tkioHqq7 oeaZKtdkZRCO6p/Oz4JhnpyoHX1EpRTmXUO/QQ+/k6Ot5UVT9ezb4e9Y0LWRzyo9SnKK G9LqMzy8qLopZYCF2AZn4hFWUa3GU1oR+zJxmZ984zkN6wakiVMnA2EIGsw3Pd1o9eyv 1gDThIFdcv9f2VbXNGoO/N7mwqYeDDPBHKs1/+WcLHeF2t7KJaZyt99UBXtI58t0m0Lr 5xb2XcYAfsbwH9T6buxlat1ifr9BegUoQIqcYJvIAss8XiJVRQsGTBXqbnFsVoSSGCX+ wRcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sKTwy9DKcjwW1wmQmyG6KE1BrY1N7uwPRSUHDXZWqLU=; fh=rvrCdUXPNX/0NBHNqh3KQo35MUEnsBNzYZ9DEy8ERJ0=; b=hVbRZEKEhOEhhqGTT20Y63QBa+IEUH2hwSTktzGF+RVEyA8taCu9OWIGfOKqzKIrNl 05dPfZEbFsT1JoVHSyiGJT5Ur+oVwThah4BRRVsYtPEBHvor0TafaRqZSk7pob2ZuxDg a6gpkmb/sPBZEusSruInSNHDbPTRqaDm79zkZyNW4ODDI4rCg4srIxe6n0V/zlfu3ljt nXklDvBhHYa16ZJ2XH6JT8MWWk79euld7e32jzHaTzA4Y20uYNRSMy9n94tSOkP7Crit C7hne74Cyz0s5IZekCRZiW9qVaNHjXy1LUE9h6D2JHhN1Uqh6DiVl+/sLiigfeMa9pSt Q1Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aJRYAZgp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id b17-20020a656691000000b005648d20203dsi10046674pgw.233.2023.09.25.04.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 04:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aJRYAZgp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 072F080B8DE7; Mon, 25 Sep 2023 00:22:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjIYHWs (ORCPT + 99 others); Mon, 25 Sep 2023 03:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232041AbjIYHWi (ORCPT ); Mon, 25 Sep 2023 03:22:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9B0C2; Mon, 25 Sep 2023 00:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695626545; x=1727162545; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EX/fS3GBRqS4B+ZBKLxnCaUT2he9dlkGETXA9I0BbhI=; b=aJRYAZgp3UR1fjRG50XuWeK01GtSisObc7jVtyHTTaUCUbDP0/yJ1Ckr FJYUTylYMF1kjZpdrGcfTD8Vm6pSmGkoThzhpn0L/W5iVDZx5PtguafSc uG8vC5wjLk++RjyNEQYPJIRwRzKvPv0E97Wnr/91Ul07l+CSV9WbsFjBK O2fJHRqmC2ajiOT08UOFhQZGqZffdZ28ZJZQNh+0B0K99XJWNfyg00pXt qRwjnVMyqGrlXFnvphb5zjmubI0SXHD9DKuwVKR9/JzXp8MaL+d6HDXro YUC2iVwR4atOq21y1ha/haPZP9v2FpenYf/AvPE+z97uIaikiVAe1on3q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="360571552" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="360571552" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:22:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="1079117832" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="1079117832" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:22:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qkfv9-00000000HHI-3rPn; Mon, 25 Sep 2023 10:22:19 +0300 Date: Mon, 25 Sep 2023 10:22:19 +0300 From: Andy Shevchenko To: Biju Das Cc: Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das Subject: Re: [PATCH v2 2/2] leds: pca955x: Cleanup OF/ID table terminators Message-ID: References: <20230923171921.53503-1-biju.das.jz@bp.renesas.com> <20230923171921.53503-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230923171921.53503-3-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 00:22:51 -0700 (PDT) On Sat, Sep 23, 2023 at 06:19:21PM +0100, Biju Das wrote: > Some cleanups: > * Remove the trailing comma in the terminator entry for the OF > table making code robust against (theoretical) misrebases or other > similar things where the new entry goes _after_ the termination without > the compiler noticing. > * Drop a space from terminator entry for ID table. > > While at it, move OF/ID table near to the user. OK! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko