Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 11/12] iommu: Consolidate per-device fault data
 management
Thread-Topic: [PATCH v5 11/12] iommu: Consolidate per-device fault data
 management
Thread-Index: AQHZ5un2ZJ/WReNtbkSLfM+RiDflerArKzKw
Date:   Mon, 25 Sep 2023 06:54:54 +0000
Message-ID: <BN9PR11MB52766E5569D115A4762AE9B68CFCA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230914085638.17307-1-baolu.lu@linux.intel.com>
 <20230914085638.17307-12-baolu.lu@linux.intel.com>
In-Reply-To: <20230914085638.17307-12-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3jGjY/MpWv39iA0jz5D2c7Xsh1/ATOUKwsswSVlvZHBpx3KYd2SklJzlJ1ow?=
 =?us-ascii?Q?OhFq8tMtMp4RAn06bg5pWMLlQ4ZFh+BZGFqXdSW03YkxGMDeVt8hy9LWU6A/?=
 =?us-ascii?Q?zc/3cpS5SCL+61UzdRwx+hpHYirevXrs+VgzQUjX45n0w4/iFg+9RnDf5B+C?=
 =?us-ascii?Q?1J4k5s3D0X9caMqjjtrzdz6HwphdO4izRlwKHUI3V+kNez3asZnS0uW70iV3?=
 =?us-ascii?Q?UBgdRRj7j0Hp1OGZVzJUv96ajlijJn2kWxROdmTGFG3IBEHu1QXnJgZDzjtH?=
 =?us-ascii?Q?0ScFMumf5mFGA/NIEiTGn2sl+QfqESvjtgTKNRI0Pkb87hytUsP4De0c36un?=
 =?us-ascii?Q?hSgggz3niuk2XymrBMOT6+VhlUYxQ3qVl3T7YQ1Y1lEx/CtzgR+IwLaW34l1?=
 =?us-ascii?Q?57p9n3Cv68RQQMVvpwSX1FtMrkG25ynWF7mtIGOT6xrPhqOFp4XRHft+u2ND?=
 =?us-ascii?Q?ycL5Lxx7Fm4awyoG4KsbnyOEnSeFD0PRo4OerMPklmswG210lZiIF31W+lR/?=
 =?us-ascii?Q?Yco4MVM0rSBpsNlnpJeeUbC5jcvoGHCgfizHqy08jZEshWVLXqGCGSE2uGc5?=
 =?us-ascii?Q?oK8k3TzRlImo9NKV0v1tnBgjvBL+3pnfS9iuX6VQd5iwuF8AK/KJKGcLi8vG?=
 =?us-ascii?Q?+fWUkYWSWNjIIWRUKAl/659HJTKoRhgcTSrCtPiiS3Uxb+edLa3W6ddf4H9b?=
 =?us-ascii?Q?GYK3rvzssIucjBNTWp48GiLOLDWV0SqwteZTlT0vtU9jm8tr0IvfQWYU3jWJ?=
 =?us-ascii?Q?xmRox6jm85+PAAHa5uXb2DLTvPNgjA+k4C0DYX6bX+sNoNIX7ubyXXxcGs3p?=
 =?us-ascii?Q?+fE69kYg/5ISEkSMjS/ZFzW/kr2O0H7LQhrU5/s+ifnVrqbDp5v92I8NCfeQ?=
 =?us-ascii?Q?Hy/2rJQEkrDshZQwXNPccSTUAg5rhL7dohyVGDaTpQRvX644dMq6dvXAJqVW?=
 =?us-ascii?Q?nUzx3dplRswTe47bpqe9kAXW4hQQTcs16d28J6h7X33vgaXL/HMDKQLFkd9G?=
 =?us-ascii?Q?QRMlcCk/Hq21/Zqu0EuLh/14XxIToEOey7pU0elyKJq56e408H5eBKqL+ztk?=
 =?us-ascii?Q?h+XWJ0mY1UZUGvd9MneWF9VOnXLYnPwD+XL/60aLm3lim8Q1E5MrXp4fs5Ax?=
 =?us-ascii?Q?bPRKFx73W6rLHtsadwxxZfXd8y/M5sd82m7qLqdjkKZOOQaOLOw0on4PBBoR?=
 =?us-ascii?Q?FM2hinVhQLcGOusSv/GqcDHy9mbrvQEWP1s8ZiwRBNyzvDvolbyMV+foNhbK?=
 =?us-ascii?Q?YKab7K9fykCzFp7HXQMkiKEl7AVNAsIihL5Vvh/rS5SIvixQfc9hE6rtU3bo?=
 =?us-ascii?Q?XsAK//0OLpUVlZCLkVqBiqbHPpREAla3GXaeIgGL92hdlWhH/+BQ+Cmqul/F?=
 =?us-ascii?Q?Tc0KBwlagZKxRxjC1bpoWoaht0onUJVhdw76ojumr9NZ85p8VfNwiCmbkXGC?=
 =?us-ascii?Q?bTqcJSWNj1jlk4TPn4/O5hnqEn3NW5oPxHfs67ArrsMYQcPUBhWle31TP16S?=
 =?us-ascii?Q?0xPXIuQjwv6e23WVqRUdbESN6eBP5s03dxOVj0UbaF9ctaxDmv/hhvUcDHWm?=
 =?us-ascii?Q?zAHxH93Hnsyz91LLXcKBU8+JTUtKG11jN5MMfbS+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed3001ec-1534-4839-86cc-08dbbd9452bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2023 06:54:54.3879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z+B3R5r1ts0MCil1sc68YEKE2XO/K2a5b5lkvTWcq/2ON9Pf/0ABu8cGaCLdGDS7QkE84+6RBGfxAf6vWFOgyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5556
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 24 Sep 2023 23:55:51 -0700 (PDT)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, September 14, 2023 4:57 PM
>=20
> +
> +/* Caller must hold a reference of the fault parameter. */
> +static void iopf_put_dev_fault_param(struct iommu_fault_param
> *fault_param)
> +{
> +	struct device *dev =3D fault_param->dev;
> +	struct dev_iommu *param =3D dev->iommu;
> +
> +	mutex_lock(&param->lock);
> +	if (WARN_ON(fault_param->users <=3D 0 ||
> +		    fault_param !=3D param->fault_param)) {
> +		mutex_unlock(&param->lock);
> +		return;
> +	}
> +
> +	if (--fault_param->users =3D=3D 0) {
> +		param->fault_param =3D NULL;
> +		kfree(fault_param);
> +		put_device(dev);
> +	}

this could be a helper to be shared with iopf_queue_remove_device().

Reviewed-by: Kevin Tian <kevin.tian@intel.com>