Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20230922073714.6164-1-wsa+renesas@sang-engineering.com>
In-Reply-To: <20230922073714.6164-1-wsa+renesas@sang-engineering.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 25 Sep 2023 13:59:40 +0200
Message-ID: <CAMuHMdXDhkhd9rOK7Ns5ViT3JMdDD3OB_sU9tSX4QGJ=7chKqA@mail.gmail.com>
Subject: Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default()
 in probe
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     linux-renesas-soc@vger.kernel.org, Jyri Sarha <jyri.sarha@iki.fi>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

CC pinctrl

On Fri, Sep 22, 2023 at 6:26 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
> device core"), we can rely on device core for setting the default pins.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -6,7 +6,6 @@
>
>  #include <linux/backlight.h>
>  #include <linux/gpio/consumer.h>
> -#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>
>  #include <video/display_timing.h>
> @@ -308,7 +307,6 @@ static int panel_probe(struct platform_device *pdev)
>         struct backlight_device *backlight;
>         struct panel_module *panel_mod;
>         struct tilcdc_module *mod;
> -       struct pinctrl *pinctrl;
>         int ret;
>
>         /* bail out early if no DT data: */
> @@ -342,10 +340,6 @@ static int panel_probe(struct platform_device *pdev)
>
>         tilcdc_module_init(mod, "panel", &panel_module_ops);
>
> -       pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -       if (IS_ERR(pinctrl))
> -               dev_warn(&pdev->dev, "pins are not configured\n");
> -
>         panel_mod->timings = of_get_display_timings(node);
>         if (!panel_mod->timings) {
>                 dev_err(&pdev->dev, "could not get panel timings\n");

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds