Date: Sun, 11 Nov 2007 11:30:16 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Erez Zadok <ezk@cs.sunysb.edu>, linux-kernel@vger.kernel.org,
       Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>,
       "Andrew G. Morgan" <morgan@kernel.org>,
       Casey Schaufler <casey@schaufler-ca.com>,
       Chris Wright <chrisw@sous-sol.org>, James Morris <jmorris@namei.org>,
       Serge Hallyn <serue@us.ibm.com>, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
Message-Id: <20071111113016.6956ce70.akpm@linux-foundation.org>
In-Reply-To: <20071111141510.GA29126@elte.hu>
References: <200711110101.lAB110LV017867@agora.fsl.cs.sunysb.edu>
	<20071111141510.GA29126@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 865
Lines: 25

On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Erez Zadok <ezk@cs.sunysb.edu> wrote:
> 
> > Small patch below fixes compile error.
> 
> > +			char name[sizeof(current->comm)];
> >  			warned++;
> >  			printk(KERN_INFO
> >  			       "warning: process `%s' sets w/ old libcap\n",
> > -			       get_task_comm(current));
> > +			       get_task_comm(name, current));
> 
> that's buggy - get_task_comm() returns void.
> 
> the proper fix would be to first do a get_task_comm() then pass in 
> 'name' as an argument to printk.

yup, it is all dependent upon http://lkml.org/lkml/2007/11/8/231
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/