Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1209357rdh; Mon, 25 Sep 2023 06:28:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsp9pfghO/4Ro2FCGlW24JPGSoLGfzJuZIfPKYyB1n90gxNcuqArMK0XB4lsCglixo3FHv X-Received: by 2002:aca:2804:0:b0:3a4:225d:82c0 with SMTP id 4-20020aca2804000000b003a4225d82c0mr8760138oix.31.1695648519517; Mon, 25 Sep 2023 06:28:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695648519; cv=none; d=google.com; s=arc-20160816; b=iBcslVq0HLO+5bsjcgn2w+Lo09jWzc/tauWv3qx3ioTgYLB97Xb0LoLo+IbY4IKHc/ v1tV3lEJs+lWVvbefCHz/sqflHrzkHgi34wMoeemP40RYJDv110YSfuB52f3q4DTdsdW 7kjYtegTKm0SiAHMq7Mlo2vS2izeq/XkuEiEwUaKkXI2vA7X3zw6eIauMPpFcwdt02QC yVoHWHw3XnyFVMexJVrjznmojntYbZ1K7XREmaKdOvnO1b0NiPAc92QDKdqrV0aB77Wk R/rBvOx2jn59hTWfMhT0hCnN2BY4t2eJQlaCV6Uzbm1ryGPx9g4oI9yS6mAeFv2VUAsE NcAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=DF70GKTjx6OLz0gFCNQLYyT2r+1t8lkHa2HhGDhuGTc=; fh=2ngKAzX2uZ7EEWOovrZvbrOADbBKtE5VyIr7qBDdlTM=; b=YT2c8nnzeWhacCWt6yZKR32Tqqb313eHlGfDVNV9acVUx4gLpzbs3SNmodg7LN9iWt vsS7HnUQllwp4UubfHP+0qB/3XZ2e2/WIxGDDfCjkpiqDNEe+3zPQ7ULc2JeoynYvA2p /Dm/3qFRmQbzMUYB9X+I+WouFfVn+bKcOeGuu1kFBCb+tMKHtQMklvIoVylnbfmecIGm IgS2QcaEIVMnjk6ocPQ5ipUd15jvh5s4HQTeg2NY/wI0sY4xTrgFfpdYBOQvOvYQii/p 7+AcfQjpNKqtR0yZ2tJF3di7n2aR/puzH6E/eYu4QOPT0uef2M8YMXdxsPP5i91ge719 iEDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hH8gFqZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id cb3-20020a056a00430300b0068fb986fcf3si9725513pfb.377.2023.09.25.06.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 06:28:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hH8gFqZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 34A8B8025DC8; Mon, 25 Sep 2023 00:47:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232483AbjIYHrd (ORCPT + 99 others); Mon, 25 Sep 2023 03:47:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232172AbjIYHrb (ORCPT ); Mon, 25 Sep 2023 03:47:31 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 059EFFB for ; Mon, 25 Sep 2023 00:47:23 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-401187f8071so39516315e9.0 for ; Mon, 25 Sep 2023 00:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695628042; x=1696232842; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DF70GKTjx6OLz0gFCNQLYyT2r+1t8lkHa2HhGDhuGTc=; b=hH8gFqZOWsojPUw1Tjmrk6tsefZj7JMeYJJIH0rK5JkNn0N4LBht/rIJBU5IFwT7Vr QQ8fPBFK59pYfKyRxNXuenXx0+7wsMeQcJgzXRZJ1hSgC6Cdj/Bw79oBtpOVG9Kli4F/ JAvq7Ki+SDrqQFMUn5hIwyTz6wfpJHs2tljWED2R2LZ8C02tDda+GrM5TQ5f2nPSwoZK 5yeMxD6h3Cg1Z0GQ4E6INB0n1KXX2QiGv6fS+DJSvVMKIbCvaIDf5J5LV+6Q8IogWUNO F2T+VkgitHPf/HWraqb+Ai2rKarFudGPvIDYeFW4BeDUVP1pwNXvZugShmIZq3VtVlJ/ HVNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695628042; x=1696232842; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DF70GKTjx6OLz0gFCNQLYyT2r+1t8lkHa2HhGDhuGTc=; b=EMrUgA31ewrP1nmvgV+kEh0reHZP8TKpfhL+T20i+jxqlOlrMVTB3MaIMgb1rCkoY0 YPAqppXDkeBke4KhRP/zstwfOXLHDCtyj25I61+KTD5DG9HPL4beWOGFmR8A1HHSXTwF L5ttELm8TFAkqo0yaCGq+aRpqJb0MVm+kaRyH5UCbzaHLTfKnNrEWArote1NNB+gMHf3 UvKVmAv7NVluVlalFsNjgkcryswnYCUEQJpdIs3y9qJgeczEN0aI94yRofkRIaA2ou4N FClSLfhI1HXpvsoY360VNCJ2eCY7weVIXjFWW3tDsISQMfSEffWf2JGSpGyWc+TxALm3 AE5Q== X-Gm-Message-State: AOJu0YzEha1XN9ZyQ+sdtDzFiiC9CoMnDxOpQtTnxoePP8M6U8KOfC92 s/v7PwmR2y3OPxoQORMo0BAOsg== X-Received: by 2002:a1c:6a1a:0:b0:403:c70b:b688 with SMTP id f26-20020a1c6a1a000000b00403c70bb688mr4857963wmc.6.1695628042233; Mon, 25 Sep 2023 00:47:22 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:a927:1e5c:85b4:9da1? ([2a05:6e02:1041:c10:a927:1e5c:85b4:9da1]) by smtp.googlemail.com with ESMTPSA id iw7-20020a05600c54c700b003fc16ee2864sm9882636wmb.48.2023.09.25.00.47.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 00:47:21 -0700 (PDT) Message-ID: <883b0780-1f89-40a4-fbd0-a3d4845c2826@linaro.org> Date: Mon, 25 Sep 2023 09:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name Content-Language: en-US To: Bragatheswaran Manickavel , rafael@kernel.org, rui.zhang@intel.com, amitk@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-imx@nxp.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230917083443.3220-1-bragathemanick0908@gmail.com> <786d197a-a2b5-2507-f5d7-24e8224a3922@gmail.com> From: Daniel Lezcano In-Reply-To: <786d197a-a2b5-2507-f5d7-24e8224a3922@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 00:47:45 -0700 (PDT) On 22/09/2023 11:31, Bragatheswaran Manickavel wrote: > > On 17/09/23 14:04, Bragatheswaran Manickavel wrote: >> Added identifier names to respective definitions for fix >> warnings reported by checkpatch.pl >> >> WARNING: function definition argument 'void *' should also have an >> identifier name >> WARNING: function definition argument 'int *' should also have an >> identifier name >> Signed-off-by: Bragatheswaran Manickavel >> --- >>   drivers/thermal/imx8mm_thermal.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/imx8mm_thermal.c >> b/drivers/thermal/imx8mm_thermal.c >> index 14111ccf6e4c..5dc6c18f12df 100644 >> --- a/drivers/thermal/imx8mm_thermal.c >> +++ b/drivers/thermal/imx8mm_thermal.c >> @@ -78,7 +78,7 @@ >>   struct thermal_soc_data { >>       u32 num_sensors; >>       u32 version; >> -    int (*get_temp)(void *, int *); >> +    int (*get_temp)(void *data, int *temp); >>   }; >>   struct tmu_sensor { > > Hi Team, Could someone help in reviewing it. Please no more "gentle reminder" Read: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst Especially, the section _9_ Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog