Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <5a71297f-c333-46a5-1215-082366a732a5@intel.com>
Date:   Mon, 25 Sep 2023 08:31:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v6 00/25] Enable CET Virtualization
Content-Language: en-US
To:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <dave.hansen@intel.com>, <peterz@infradead.org>,
        <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
        <john.allen@amd.com>
References: <20230914063325.85503-1-weijiang.yang@intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20230914063325.85503-1-weijiang.yang@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGJEdWlVb2ZYaEUybGpIcHB4NjdCUlZCdEVad1VUbFZDNkxGakFUNGZ1K0g5?=
 =?utf-8?B?MlZ3TXNVYVRnV3pZMWcxSTkvRlpSVWRCUWJ3YVlrUHRHb2lVK0xqaUNUUzBF?=
 =?utf-8?B?Z2dtSDJhZGxjTlFOMVRQT0NuUFMvb2NGYlNid2RwYXJjNytQdkFJTFRoUVZl?=
 =?utf-8?B?TStHQWQvVWNMaFdGeCsvNXBOekpYUXFUMVA1MktrT0J6d3FqWmJFMDFBNXlK?=
 =?utf-8?B?ejRqVjVHWVdmNHpjSy9XRm5JTUpRS1orMEp4Nlo3c05qckl3bzY2RnhuVUV4?=
 =?utf-8?B?VmJkTGlHQ3lDT0xDNmp4ejhQc1EydTFtR1lsS2p6WitKTmdoZW1ORE5UWHZw?=
 =?utf-8?B?MGNodStWbmExUGJwUUFYUWdwenN3RHBMbFFCZXg4MlJCbE1EL1d3N0ZTLzNa?=
 =?utf-8?B?UVhmT0ZkekUrWUFxWnlkS1lHR0JJU0JiY2JmVU52WW93RHlYenZZbHJPK0pQ?=
 =?utf-8?B?UDRxZG5JWldoYWJndk1zaURVbUg2dHErZ2p3Y1RabkwvRk5BMjUwU1p5SFhU?=
 =?utf-8?B?dmh1WmVOeU1hUlFEWmt4WndaS3BSNTVmSyt4RmxmMld1aFlzdG1QU0puOVFU?=
 =?utf-8?B?djYwaU81TkptU01QdVRLMDRFU0VsOTBpRmViRUhjWW5mU1pIWGNXaEE5VkZN?=
 =?utf-8?B?UFJQVnVERlduT0FRK0VDb0hsL1VhbzgxajN6dVNhMisxV3hDL01ZelJXa3RK?=
 =?utf-8?B?SDAxYmtSenlKV1FadWJ5ZFdxRm0vTmQ2c1BmVWp1aEFIQVBIRkdrTEd1d3Nw?=
 =?utf-8?B?M0txN3VQYVFXRlVkK3oxeFFGUFN3cDZjYXJhbE5ObmV3RDlJdU5lMkRtdGcr?=
 =?utf-8?B?c0M5bndvUWxHQnBFY0RsTHJ4Um94a2QwMURMZWhpQ3lkVDEvQU5lN3grN2Ix?=
 =?utf-8?B?RGVlRTdHUU5WYUNNREQzS3BMSy9uQjZvaFpwQ2xyc21Bc0FqQTJ2ait2UHEy?=
 =?utf-8?B?d0RNYjlyS1V3bzNlSjBNdk5UVC9rWEZndnpIWU9rRjY4YjNCV29zeTFqQllN?=
 =?utf-8?B?TG1DNjkzKzlmZ3BvbFowRWVkV1phaFJ0d0NxZkM4WXgxTzdjWUZMYU82a0Fa?=
 =?utf-8?B?ZUJVUlZXQWlhU0xBRmE0NVBqNlZsSjVNQTc2SmlXaFpmUldSYXRaSEV3d29p?=
 =?utf-8?B?YWRzOWdCenpEa2JGUFJOR3ZhcEpaTHVpSTE0aS9RQXV5K1kxaFlybHlzTzJL?=
 =?utf-8?B?Z1ZneXlQdjdCNm1lY1hqdW5rejFZNGx3V2ZVUUR6K2dERVlISCtyMWM3WGFE?=
 =?utf-8?B?SW4wR0xqbGNpVG5zZnUxb012L0M0VWRoS1g3SHJ4VUk2TEVzamI0bUJRTVRl?=
 =?utf-8?B?c0RGQ1Q4WDhDMFRER214cVBqcmQ0MXdCWHYyRzJXcDdXUHF4Y1ZnTXZNTDg1?=
 =?utf-8?B?NG9GKzUyZkRuSjhZZSs5T1lKMmFVYXpXODMxSlJwaS9KNW5xWUJaODFWMmJl?=
 =?utf-8?B?dEdJQ1dwdy9WRXgrZ1l2R3BVYVROTFIyOGoxV01YbXFrRnlaaTVEL2VlV1k2?=
 =?utf-8?B?K3hRdnFTRXI4WEN4T3h0NjFMODdtZ1ZPRFNWeGh1UitQcUMwbzNud0RrNXB5?=
 =?utf-8?B?ZHJ6b2JsMjU3ZWd6M3Y2UFpHSmJnVTRZdEJDYVEvVXlKMjRQeWxaRmpwZ1o4?=
 =?utf-8?B?KzY1ZDZSeEw3VCtrdi8vOGRmaWFQTWlJSVhnbkREeFdVdW1FaE9yWTE4ZHEz?=
 =?utf-8?B?ZUxsTzZRRDR0SkxZU2gxazlPamdQem0xc1ZCaUJreUpKMlJUN2pYR28rQktD?=
 =?utf-8?B?NStYVXRGdSttemRnanZHeFAzZmNJY3FHNzRzOXoyOFZWZmU1cE9NU01BcnlP?=
 =?utf-8?B?K1lpN2VBTTlKZFAvZ25yVmwzcDJIMDJrT2JtZE9oaEJRNjlUWlphTk5sdE1n?=
 =?utf-8?B?VUJUOTlvWEYybEdSRG0yRkZNcEpxODdPSW1IWDFNTWlYTE81RVFaMWh5cEZF?=
 =?utf-8?B?S05OdGJzV3F4RFM0bjlTZzFKZGRBeC9zYldZNStvR1pKMjFQTC82Sm41TTFM?=
 =?utf-8?B?emZxMzhtTUMzOTFRNE9tcm9BWGxBSjJrVEU1M3pVdWtDNm5nbkY5NDg5MVRO?=
 =?utf-8?B?QURrOWpMSCtFZko2YjZ4enc5WmRReSttbzN5amMwdE5UWEFsYlBpdU9ZeTJP?=
 =?utf-8?B?M1FGZFpmSnVORC9VTTZ1Z3V2OFRnbTJoS1lHTEJtRTgxOHloV2w3cVJuWTFj?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d613673-11b8-4f32-fe65-08dbbd5ed78e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 00:32:04.7236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wpFD9K1pWlpw97OBJc2EBQjsAS0h7h7iZ8e8ckr3SBMIOf3idV7ZPL1793cP5R/Gybh2Cp/A0Z7UzU9xUH7hgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7804
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 24 Sep 2023 17:32:18 -0700 (PDT)


Kindly ping maintainers for KVM part review, thanks!

On 9/14/2023 2:33 PM, Yang Weijiang wrote:
> Control-flow Enforcement Technology (CET) is a kind of CPU feature used
> to prevent Return/CALL/Jump-Oriented Programming (ROP/COP/JOP) attacks.
> It provides two sub-features(SHSTK,IBT) to defend against ROP/COP/JOP
> style control-flow subversion attacks.
>
> Shadow Stack (SHSTK):
>    A shadow stack is a second stack used exclusively for control transfer
>    operations. The shadow stack is separate from the data/normal stack and
>    can be enabled individually in user and kernel mode. When shadow stack
>    is enabled, CALL pushes the return address on both the data and shadow
>    stack. RET pops the return address from both stacks and compares them.
>    If the return addresses from the two stacks do not match, the processor
>    generates a #CP.
>
> Indirect Branch Tracking (IBT):
>    IBT introduces new instruction(ENDBRANCH)to mark valid target addresses of
>    indirect branches (CALL, JMP etc...). If an indirect branch is executed
>    and the next instruction is _not_ an ENDBRANCH, the processor generates a
>    #CP. These instruction behaves as a NOP on platforms that doesn't support
>    CET.
>
>
[...]