Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 25 Sep 2023 08:47:10 +0300
From:   Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To:     Doug Anderson <dianders@chromium.org>
Cc:     dri-devel@lists.freedesktop.org,
        Maxime Ripard <mripard@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, airlied@gmail.com,
        daniel@ffwll.ch, festevam@gmail.com, kernel@pengutronix.de,
        l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        linux-imx@nxp.com, linux-kernel@vger.kernel.org,
        shawnguo@kernel.org
Subject: Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call
 drm_atomic_helper_shutdown() at shutdown time
Message-ID: <20230925054710.r3guqn5jzdl4giwd@fsr-ub1664-121.ea.freescale.net>
References: <20230921192749.1542462-1-dianders@chromium.org>
 <20230921122641.RFT.v2.1.I134336fce7eac5a63bdac46d57b0888858fc8081@changeid>
 <20230922075610.ekrzyz6hfcd3rjsm@fsr-ub1664-121.ea.freescale.net>
 <CAD=FV=ViV-n2T1Bup+XScsWD11yWpTmW3qEOLTTDj3kTtTY4Cg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAD=FV=ViV-n2T1Bup+XScsWD11yWpTmW3qEOLTTDj3kTtTY4Cg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3902:EE_|AM0PR04MB6803:EE_
X-MS-Office365-Filtering-Correlation-Id: b5af0833-938e-4298-9709-08dbbd8adecf
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dmGQ+pxrDOUZgGqy3/DWoRKETynWePi7PF4MzGDFsGgjlS7hX03Z7hO/dOn5t9I5pqXBITdaetYYiG9F9PAg8mHDgXr7+LDiAcyyhEKr3kaPZUtfN8ZCXrNRfI3CPZ/sPnJeqKHD8yaaFf49hVzoKuG66n9/aHmftkI49tXC9vF9kd8zZcGm4UhJ4aEsuiZNF89WMvJvH7Vct0kzfvcnhr6/lnCwvilR5eSaon9xua0aoIam7VW2IJmbRcmeAWDfdKLRJhlsZEKQ4hLnWWyyCNRx6RiYUFg/Ud+75xPKylxTend+OKve2ibPc4rT/EfEn8ouhkSxIY0g2PqWLKrBzRd7wu3F/sIFSQYYfQgT5hbGmCCQjLOHmjf5x2m0U5BrLAKGmP3Wkh82vqc0GAQLehrxHnyXkWCPInLG+LSFX9cgyWwJ/KrUWlfnEx7IoyciXPXMNblMHRQaOXRQQDa2S245ht0a4OeEfoda6LmS4jpUINNHmccpsI2JiGFuI1B8MHagjD/ljliIuvBIA03i8jmJ2OUH65A/ZLJse7CtDhqLe/phVZuATQQYiJOUZ45T
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3902.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(376002)(366004)(136003)(346002)(230922051799003)(451199024)(1800799009)(186009)(54906003)(2906002)(5660300002)(316002)(6916009)(41300700001)(44832011)(7416002)(8676002)(8936002)(4326008)(66476007)(66556008)(66946007)(86362001)(1076003)(6486002)(53546011)(9686003)(6512007)(6666004)(6506007)(26005)(38100700002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHJ5SnRKaW1jbHdhQTZiVXlPeHRTYlc5dzI3d1UxN25BRkM1dTVBYjYzaW5T?=
 =?utf-8?B?U1VtQjVxMkVIRTFFcnkwSG80OGFRMExicmJra2cyeGFCdjZISk1rNHFGVktD?=
 =?utf-8?B?TTRDV3ljNFBqMjVDLzd5TDQ5b1R4UVZsdFFybUVGQk9pRXFXZ1RkNmtVOWJU?=
 =?utf-8?B?VzdidlZYNTZ5MFVNZWpaUnI4cFZJSWFrSFdHRXlBbjlUMy95SkFmUTNNVThW?=
 =?utf-8?B?S2w3L3diNUlTdk96aXAraVJUUUJZaFgxQlJTYzAwNHRBUFZpZ2dyVVdFWGtF?=
 =?utf-8?B?bWpvVzd5R3I0MzNBVjhObVA5YXlkSTA0OFEreldockdEL0dMZTVva2lOcUo2?=
 =?utf-8?B?UmdWdlpVYTBJNUVoY0JqTENGSjBtTzNpVkFleGpvUG53a2lNV1E2R2dadURU?=
 =?utf-8?B?Vm90Z3FsaVVhNWVuaFlsMXZHZU01SVIxdEZPeHZsUGNiZzc1QVFEeEU5RUFx?=
 =?utf-8?B?TEhXS1B4akl1a1JtNzc4Uk56WGZCSHFHVkNCeEZXaFUyeEE0UGNJV3A3b1hj?=
 =?utf-8?B?VURsaTBsYVhRcytMWWxucmNDYS90R09veHVtbVNodVJMK2NPMW1oay9oQkhU?=
 =?utf-8?B?RklpenB5ZjlRcVcxYUxLVy9INk1EL0sxU25FY01qaEpxVFRDaFRSaFZBc09q?=
 =?utf-8?B?bmlMUHBiL0ZoZ3BkSUdVOWVWSXBlTGdnRGxrajJhTDNFZGtxV1RHQU1aTkd6?=
 =?utf-8?B?M1FUQ1QyRnFQQlBYUkYrZUFQWlJubXdMM2htaldwNFlOUVh6Q3EzQ1dTM2Fn?=
 =?utf-8?B?TEVxRjFJeks0ZjJzaVdVdTZvcmdwWXE3eEN2ZmVHdWYyRDhwRElQcGpxdVdz?=
 =?utf-8?B?QXBIQ0ZCbmdBbjVxUkp4dG5zRTNjak52WmFOSGdUajNBOXZ3OThhN3d5VFBF?=
 =?utf-8?B?M1FFMjRGNy9ZWVNORURLSFJUUFhFNlQvUWhEaDJBZVZ0azdaUjVmbWJJRzhU?=
 =?utf-8?B?UmFqTmlLTmJHUWpGenovU1gxUzBMU1B6TlU5UzlzWWNHak8rK2FSMXlhMnY1?=
 =?utf-8?B?dVdpNEtnR3JTM3F0TVRxZ2UxclpZa1BSNEU3bVJuK2pDQU11WkdnMm5QT05G?=
 =?utf-8?B?RjZYb2ZUNElNRVdmZERXMTZvK0x3bWZBemdLWm9wMC84c2F6RVBIR0JscUN1?=
 =?utf-8?B?TnQ0b2dWOW15Q0JDWVgxUVFRZ3BiVUx3emVqNW83WE9QZUdtMklQUnFSaHlS?=
 =?utf-8?B?SXoyV2dTZGRnTVJtb1hIdjFBTVdnS00yaFQ5YjI5NW5TbG1vNUVhaEliQ3hx?=
 =?utf-8?B?bS9FWFNzNHFqTEdNazZicDFHUkc3VVRtSXY3bVE1WDJlV1ZFRWdTejRmTk9k?=
 =?utf-8?B?ek1McDlWTWZUeVpNZ21Uai9WTGVoeWZmbVhrYlJKVjRiaTlSbDlyN29za3RT?=
 =?utf-8?B?bzI3T0xGNHNpQVBaMURIUndaS0dxbnpRZTNjK0JMMDZEckxMQzVnaXlvQmlJ?=
 =?utf-8?B?WitzdENZU2dSRXZDc0VvcDVMWGtqU2tzOWlrNC9uZUFjVndVM3hZd2xUTUtM?=
 =?utf-8?B?a2l5eUpnQU02QjM4cGZLTWhMT1lVZFR1bnFKMWYzQUhLbmhCWkh2clRjWjBP?=
 =?utf-8?B?UnVNcTAzdWQzQ003c2hrY1YzU2VtejJjRXJHcHgyZHdiOFlUc1hjaVR0VzZJ?=
 =?utf-8?B?NzNNQkZxdDQwYzdESDQyY05oOUxvQ3JtWCt5UGlBT1JEWVZVTzZVdW9hZXIr?=
 =?utf-8?B?S2ZtUExUdEphK1V5a205Q0kyRGw1MHVRZnM5aUdtdzRjUEZnTk5pZXBNYWk4?=
 =?utf-8?B?M1N0c3lBUUpzZ0k5MjRudnBUU3RHNUY2Z1huM0h5Z1JnRUpHeTFvaG54R0dV?=
 =?utf-8?B?UDVSZDRjRFRwSlNsVHpDNVRnTFI4dEgweDVRZm55SVMrWFVQSHE5dnhhYUdo?=
 =?utf-8?B?dUFnQ2xXczlia1J5VXQ1aFZKaUxndFlvNHdDdTI3TGMwb3ExM090QXFHQTNn?=
 =?utf-8?B?dkZDYVFLd1hkNUlpenVyZzdQbURGaWZGU2owT2kxSlFwQ1VGMlhYQXVldFRa?=
 =?utf-8?B?Ym1PMm5Pb3FvK084L0J1L0x5cGs1YVVib3F3bFUvQ3cwemlBOE4ycG9Od0xq?=
 =?utf-8?B?SFArT1lPM0czTk5KdzZ1TnNuUjhwU2duWlQ3d0xWS0F0WVFSSVM5VEtldVAr?=
 =?utf-8?B?MVJXdG1pN3NPTCt5ZlVEZEEzZzZ3NU5pTExKQ053d3RVdnB0WVR2cG8yREtX?=
 =?utf-8?B?RkE9PQ==?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5af0833-938e-4298-9709-08dbbd8adecf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3902.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 05:47:14.6737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vwyQLwX4lHlqgyA0/pMe+p2KhY3Fhj0OrnIjCXWOu51mdVlz7yGvAXRsFw8wr6BU5eGI5xYLhrZ5KAs61CFEMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6803
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 24 Sep 2023 22:47:24 -0700 (PDT)

Hi Doug,

On Fri, Sep 22, 2023 at 08:44:16AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu
> <laurentiu.palcu@oss.nxp.com> wrote:
> >
> > Hi,
> >
> > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote:
> > > Based on grepping through the source code this driver appears to be
> > > missing a call to drm_atomic_helper_shutdown() at system shutdown
> > > time. Among other things, this means that if a panel is in use that it
> > > won't be cleanly powered off at system shutdown time.
> > >
> > > The fact that we should call drm_atomic_helper_shutdown() in the case
> > > of OS shutdown/restart comes straight out of the kernel doc "driver
> > > instance overview" in drm_drv.c.
> > >
> > > Suggested-by: Maxime Ripard <mripard@kernel.org>
> > > Reviewed-by: Maxime Ripard <mripard@kernel.org>
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> >
> > No issues found on i.MX8MQ.
> >
> > Tested-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> > Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> 
> Thanks! Would you expect this patch to land through drm-misc? If so,
> I'm happy to commit it there with your tags.

Yes, please do. The i.MX8MQ DCSS patches go through drm-misc.

> If patches to this driver normally flow through drm-misc, I'm also
> happy to post a patch to MAINTAINERS (or review a patch you post)
> adding this to the entry for "NXP i.MX 8MQ DCSS DRIVER":
> 
> T:     git git://anongit.freedesktop.org/drm/drm-misc
> 
> ...which would make it obvious in the future that things should land
> through drm-misc.

Thanks, that sounds good.

Laurentiu