Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 25 Sep 2023 12:49:57 +0000
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Nicolas Dufresne <nicolas@ndufresne.ca>
Cc:     Benjamin Bara <bbara93@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Benjamin Bara <benjamin.bara@skidata.com>
Subject: Re: [PATCH WIP RFC v2 0/2] media: uapi: Add V4L2_CID_VTOTAL control
Message-ID: <ZRGB9bXX6HZ6aobi@valkosipuli.retiisi.eu>
References: <20230609-v4l2-vtotal-v2-0-cf29925f4517@skidata.com>
 <5f7873743042cb302c2cb55cdb7ea5e9b26966f0.camel@ndufresne.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5f7873743042cb302c2cb55cdb7ea5e9b26966f0.camel@ndufresne.ca>
Precedence: bulk

Hi Nicolas, Benjamin,

On Thu, Jun 22, 2023 at 11:14:41AM -0400, Nicolas Dufresne wrote:
> Hi,
> 
> Le jeudi 22 juin 2023 ? 09:12 +0200, Benjamin Bara a ?crit?:
> > Hi!
> > 
> > This series adds new controls for the vertical and horizontal total
> > size. Camera sensors usually have registers regarding the total size and
> > not the blanking size. Also user space prefers to calculate with total
> > frame sizes. Therefore, this would simplify implementations on both
> > sides and could be seen as a replacement or upgrade for V4L2_CID_VBLANK.
> > Additionally, its value is independent from format changes and therefore
> > simplifies calculations in user space.
> 
> The naming is getting more and more generic. We need to find a way to give these
> controls a name that associates them to their usage field (sensors). If we keep
> growing the control list this way, in few years it will be terribly hard to
> understand what is used for what.
> 
> What about, V4L2_CID_SENSOR_VTOTAL/HTOTAL ? I'm expecting the last bit of the
> name to come from very well known specification, otherwise, its not a great name
> either in my opinion.

These controls can, in theory at least, be used for any image data bus:
they're not related to sensors but to any source of image data on a bus.
Compare this to the LINK_FREQ control, for instance: you basically need
these to calculate the frame rate (or calculate these based on the desired
frame rate).

These configurations are often called line length (in) pixels and frame
length (in) lines, the controls could be thus V4L2_CID_LLP and
V4L2_CID_FLL, to keep them a little bit shorter.

-- 
Regards,

Sakari Ailus