Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
MIME-Version: 1.0
References: <20230924222559.2038721-1-andreas@kemnade.info>
 <20230924222559.2038721-3-andreas@kemnade.info> <CAHp75VfvmED4ZsmrH4B6m9kGsH=68-zjQd5JMszb6UBTtbF0bw@mail.gmail.com>
 <20230925140415.00130082@aktux>
In-Reply-To: <20230925140415.00130082@aktux>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 25 Sep 2023 15:28:15 +0300
Message-ID: <CAHp75VeyCnDwCAf4pKVynQDXdqM9nURLFHKODkgF0c+BLCrQ7w@mail.gmail.com>
Subject: Re: [PATCH 2/3] iio: imu: mpu6050: add level shifter flag
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        bcousson@baylibre.com, tony@atomide.com,
        jean-baptiste.maneyrol@tdk.com, chenhuiz@axis.com,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 25, 2023 at 3:04=E2=80=AFPM Andreas Kemnade <andreas@kemnade.in=
fo> wrote:
> On Mon, 25 Sep 2023 14:07:58 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Mon, Sep 25, 2023 at 1:26=E2=80=AFAM Andreas Kemnade <andreas@kemnad=
e.info> wrote:
> > >
> > > Some boards fail in magnetometer probe if flag is not set.
> >
> > Which flag? Can you elaborate a bit more?
> >
> well see $subj. The level shifter flag.

Well. it is better to have the commit message being self-contained.

> > Does it deserve the Fixes tag?
> >
> As there are only certain boards affected, they would also have
> to add the flag in dtb, I do not think it deservers a Fixes tag.
> Even in the board I have here, there are basically two
> mpu9150 connected per cable, only one of them needs the flag.

OK.

...

> > >         unsigned int val;
> > >         int ret;
> >
> > > +       ret =3D regmap_update_bits(st->map, 0x1, 0x80,
> > > +                                st->level_shifter ? 0x80 : 0);
> >
> > This is a bit cryptic, what does 1 stand for?
> >
> Well, I do not find anything in
> https://invensense.tdk.com/wp-content/uploads/2015/02/MPU-9150-Register-M=
ap.pdf
> I have just found a similar line in the ancient 3.0 vendor kernel. No sym=
bolic
> names there.

Okay, perhaps a comment on top to point out this ("the code based on
v3.0 vendor kernel, the meaning is unknown").

--=20
With Best Regards,
Andy Shevchenko