Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Armin Wolf <W_Armin@gmx.de>
To:     markpearson@lenovo.com, jorge.lopez2@hp.com
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] platform/x86: Fix reference leaks
Date:   Mon, 25 Sep 2023 15:28:42 +0200
Message-Id: <20230925132844.72479-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:HhaFlpIL7gg=;afsaFn/AJccQrwOI/JVAxafSbnW
 VcfkMswN4NZV9V6W2VvjvHr5qKL0SOovqTQd/8FhW9y6Ho8qGCYpcpHixd8512cMZ7zKFNqqs
 CgEEH1SbMuf1f2CUHya/EKZQxA6qSXWC5juGAmEJSWULdhDD3X1UWjSWgssbAMZsmfiqNW3xg
 koy4jZkRgMfPYC3vDLvv19C9671tdNLcxDUqq+mrqv+BQjDwFX0DLSBcW1RxWJgAp2/YmrYJl
 2D3T1ct48Hc8U8E2ovBi5iPSFt3jOyJPgoghhabkrC/FaOZ/vqIkRrcZSgUiebEL8+xe1CNYh
 xTQ9EzvoFCTlemBi7vbDcWvshT79ZW1DH6Zfpq4HHLXBuQqhRHwR+5PWNLerMOBLk6D6/qc0i
 wkcgd/gU4ph0/oFXx7PWKT/UBuDt0ekLX8C9nhdITTpa10bv1uc9BV6kSvf40kbZDjkh9qLYK
 AGBEP0q59Fs6uIZb2OIJ4Hc1K73RdZRZUbrMBwJ/noSHczAQZRBbrdK58LsHDbto+Tpmh3WeY
 CaZt9KNVtjKx+eCHbrG1fxnk5pm1tVhiB2HYBNldxQEhUFFC5u0Wov40ryzFl9DTp/pDXNChC
 5QJDOqrH0jOXxRHQ0v+H7gU1v4Jeop5wC3DXKipOVS6G0OpgPXYlt0K2mlCdwnCKUI4Dyb7Cm
 ydJDQi8O6Y6VHEslhLgvhlItXtHw2gQTA4iuu3DuDmePD6YjpJrbwJ6kh5AL4Hc4O8/AHgatM
 mzcn3P5AlFfmdeVMYklKfUvPXlGYvFi0JP1ARbH26cPArjuSLPitvTIur76NO1aIIgOR33E7w
 JLhIFjo7fcPzPRib9Mw8EILijM5iQkRPAWxR5UFyR0qi0GOsmgCl8dUIAH9zooslbP1uri1vY
 eTWhTWnCU8szt+47F8mhtdqG8zhYHbFN2BRfA9KmpACQTBTbqpnezTFtd6lUMDvuk7I1Cj/BS
 uGcDGcyLjoofe09fir4RHTxPJ0M=
Precedence: bulk

If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). This issue likely first appeared inside the
dell-wmi-sysman driver, see
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
However, it also seems that the bug was copied from this driver into
the think-lmi and hp-bioscfg drivers. Maybe a more abstract
fw_attr_class could prevent such issues in the future by abstracting
away the kobject handling?

Armin Wolf (2):
  platform/x86: think-lmi: Fix reference leak
  platform/x86: hp-bioscfg: Fix reference leak

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
 drivers/platform/x86/think-lmi.c             | 24 ++++++++++++++++----
 2 files changed, 30 insertions(+), 8 deletions(-)

=2D-
2.39.2