Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1328550rdh; Mon, 25 Sep 2023 09:20:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkskUAKu5YLn/SCKAt4ds+nWDuhzr+iOmR32gB9XQfpoWtTVUR9GPnA24AO195IomN4c2W X-Received: by 2002:a05:6a00:18a3:b0:690:cae9:714d with SMTP id x35-20020a056a0018a300b00690cae9714dmr5201837pfh.13.1695658822628; Mon, 25 Sep 2023 09:20:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695658822; cv=none; d=google.com; s=arc-20160816; b=b9QW94sUHBXfvZmhy83lYuD9+ozNDwS2zPa5cEYbihVFMRf+VomD5DVsSj5KZe77fS H5LQDn1xyWKFv5hr1CePoYW7bPGToK1E+XiinG/iIrXjqe9UQH8HD/aybFLI4KCCt5kb 3gKC+cmByypMZ8I3jYmfjzQC8z4kQZo1ThyyoEEp2EYS7tvZIq31+gkPkMTXFpnvAVBb wxpeefWzuENebuPqqlPUNdXBpiM8hv/XUvwATE5XrcJyZPjcjNlyHLEkjEhR9SoKchqW 3XpUA0arn6zJh92F8Vf/xhZQ0T1ZWhvZ87IUnRk842d4fagb1KyotX81Gk6MxjVGP/M6 Wpuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OYWoXvhFRey3Jy19pu8xFEtqjP/997zz5z2k/ZPWF/w=; fh=wRP2X+abPQ9dUYYzTShLwLXJkqnUFuK1jvIr5TcWOtw=; b=nkosLml+8Xpd2ZGwjPLRTe9j1z1+nlgl25qi3bILb2TmneRsstWzSJT9gDWNl2ZZBo hSvFWqg4UStpdQQasQNGns6WWkawGJmZ1TN3ve/5NyUgczT1yH2QpwWXClgXOnSKmoV9 TpwTkIn/x+S+Z1mHW6Uv9gas5yTwFTbnnc5bEvEjFrdSONxbD2ZTVkfLGQNmZlAxauQs BQcyl5Y4oP9zgyW5yP0c2FSqyFMd3CxuaZrdunAT1ZhtyGniUqQmMC2Nzzgjnw28udRx 70npI42Tmit8+x1M70MjuUXvdi8SQ+/mUJkvdsz4GczLotPSNzjpwgoFfMUk3a4zZFkn KCpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=m0WY63OM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id cm17-20020a056a00339100b0068e2566615esi10348142pfb.379.2023.09.25.09.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 09:20:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=m0WY63OM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9869880740CA; Mon, 25 Sep 2023 09:06:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbjIYQGA (ORCPT + 99 others); Mon, 25 Sep 2023 12:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbjIYQF7 (ORCPT ); Mon, 25 Sep 2023 12:05:59 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 179EA92; Mon, 25 Sep 2023 09:05:53 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38PG5hQ7106103; Mon, 25 Sep 2023 11:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1695657943; bh=OYWoXvhFRey3Jy19pu8xFEtqjP/997zz5z2k/ZPWF/w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=m0WY63OMLIAlBbY2DLAMie054PF7DB0BX17mQOO1EeTpvGqpv9kAeCieUp9QrI78s iixu0VZ28DuGCK+XrM6/CDwvP01YQIBbkMZSCRsbqefBIc8foVNKZKETvIQkAUFtYK a02JS+2+DUfBWNS4Nfutrr1MTnzGt1BjQj/0AEYY= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38PG5hOp007370 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 25 Sep 2023 11:05:43 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 25 Sep 2023 11:05:43 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 25 Sep 2023 11:05:43 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38PG5hQg028417; Mon, 25 Sep 2023 11:05:43 -0500 Date: Mon, 25 Sep 2023 11:05:43 -0500 From: Nishanth Menon To: "J, KEERTHY" CC: , , , , , , , , Subject: Re: [PATCH v4 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the main domain watchdog instances Message-ID: <20230925160543.4q2rjntoxrh27qh6@drivable> References: <20230925081332.15906-1-j-keerthy@ti.com> <20230925081332.15906-6-j-keerthy@ti.com> <20230925131927.f7ff2u2ip3jxejyg@dreadful> <9fef2589-c864-bcb9-be9d-435d6abd470c@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9fef2589-c864-bcb9-be9d-435d6abd470c@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 09:06:08 -0700 (PDT) On 21:03-20230925, J, KEERTHY wrote: > > > On 9/25/2023 6:49 PM, Nishanth Menon wrote: > > On 13:43-20230925, Keerthy wrote: > > > There are totally 2 instances of watchdog module in MCU domain. > > > > > > Signed-off-by: Keerthy > > > --- > > > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > index a7b5c4cb7d3e..0b7cc277a567 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > @@ -714,4 +714,24 @@ > > > ti,esm-pins = <63>; > > > bootph-pre-ram; > > > }; > > > + > > > + mcu_watchdog0: watchdog@40600000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40600000 0x00 0x100>; > > > + clocks = <&k3_clks 367 1>; > > > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 367 0>; > > > + assigned-clock-parents = <&k3_clks 367 4>; > > > + status = "disabled"; > > > + }; > > > + > > > + mcu_watchdog1: watchdog@40610000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40610000 0x00 0x100>; > > > + clocks = <&k3_clks 368 1>; > > > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 368 0>; > > > + assigned-clock-parents = <&k3_clks 368 4>; > > > + status = "disabled"; > > > > Explain in commit message as to why these are disabled. I believe it is > > because this RTI instances are tightly coupled to the micro > > controllers. but that information needs to be documented. > > Sure. I will add that to the commit message. And inline to code for context, please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D