Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Robert Foss <rfoss@kernel.org>,
        Yang Li <yang.lee@linux.alibaba.com>
Cc:     neil.armstrong@linaro.org, jonas@kwiboo.se,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        jernej.skrabec@gmail.com, Laurent.pinchart@ideasonboard.com,
        andrzej.hajda@intel.com
Subject: Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings
In-Reply-To: <CAN6tsi44s3h3Ox3mK2pi+Mw8pGCB9fgMcoWmJhCenHoK9=t=-w@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20230920004400.81091-1-yang.lee@linux.alibaba.com>
 <CAN6tsi44s3h3Ox3mK2pi+Mw8pGCB9fgMcoWmJhCenHoK9=t=-w@mail.gmail.com>
Date:   Mon, 25 Sep 2023 14:08:25 +0300
Message-ID: <87a5tao6hi.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 25 Sep 2023, Robert Foss <rfoss@kernel.org> wrote:
> NAK

Feels a bit harsh.

> Personally I value maintaining a simple to follow `git blame` history
> over correcting indentation.
>
> Ideally bad indentation should never be committed in the first place.

Agreed, but when that inevitably happens, do you really want it to be
cast in stone? To me leaving bad indent (or style, or whatever) in place
indicates we don't care, while the opposite is true.

Maybe look into tooling that lets you easily git blame the parent commit
of a line in git blame? (For example, in emacs vc-annotate, it's just a
matter of hitting 'a'.)


BR,
Jani.


>
> On Wed, Sep 20, 2023 at 2:44=E2=80=AFAM Yang Li <yang.lee@linux.alibaba.c=
om> wrote:
>>
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() =
warn: inconsistent indenting
>>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu=
/drm/bridge/synopsys/dw-hdmi-cec.c
>> index 673661160e54..fe2ff4984fc5 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct=
 device *dev)
>>         struct dw_hdmi_cec *cec =3D dev_get_drvdata(dev);
>>
>>         /* store interrupt status/mask registers */
>> -        cec->regs_polarity =3D dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> -        cec->regs_mask =3D dw_hdmi_read(cec, HDMI_CEC_MASK);
>> -        cec->regs_mute_stat0 =3D dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STA=
T0);
>> +       cec->regs_polarity =3D dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> +       cec->regs_mask =3D dw_hdmi_read(cec, HDMI_CEC_MASK);
>> +       cec->regs_mute_stat0 =3D dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT=
0);
>>
>>         return 0;
>>  }
>> --
>> 2.20.1.7.g153144c
>>

--=20
Jani Nikula, Intel