Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Armin Wolf <W_Armin@gmx.de>
To:     markpearson@lenovo.com, jorge.lopez2@hp.com
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] platform/x86: Fix reference leaks
Date:   Mon, 25 Sep 2023 15:25:55 +0200
Message-Id: <20230925132557.72138-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ZUpRUpSbieA=;TbYe6f7OzcniIxKI0D41j4KjZDz
 V0mZBDxzFNiObY2lY1wyke6KokUeO9mIDXEAOFTkGdNCmEUjE2SE4+ND/Jnw+OQkucIyM5YAZ
 CS2zkPs2TonyFRPRPDrWXIlxg/gqMfD1uD21v9kDV7S706LzHb8UBxc2n+qBOKIT603Q6K2Fd
 5haxl+NtLXRFgaKTvXqIT4HJfWZVsCEz3CYXoEKczUnd3SmvpIq7fzQ2Euz4+mAWdii9rNmTD
 313hGRYufQTGSaC+m4d1jFZ6MilLcvW4ubew+l3g1DLDf4aojn4POIev1Nt4plqMWLVOqYblQ
 +uEN7Z/ghHzbvG1a+6dG34c2D0h0aTCoelgg4TaalfBbwOgx92vKuGOxX/r72WbrfhbAqmZ0l
 jZfldeti57HJUFXwPQaVwVuwRRbJWkiBxbBNgsGrMrfo/gWi0yfwUV9ujbvTPiIShkK6yYDGV
 bxyUol18uSJWy6D+UA0ib+VYqldDz/3jekpvHM0hPsU3wl6nNJgWBXfBTelF5mvVonFv68OLY
 jdwfp4tzIsSozSDKpBKEh5T+TVqKCZsJIIvBv346WolaLT3vQGyi6aftVACfdrCCyNeLPR5/l
 ILz2STHiqpe7w9bcfjgDITFIHXrBka4ONozT+OPzjjVUL6VsA1oj4XfrDpBPBF5eQnBgmR1fw
 FR5/7PROR/iFojz1VBNCdUvbPaq3nnAhYiSehlTHdRbtOe832iG1I1ZPmDi8vj+YIQTZxe05T
 e7wEVnqbR5F/XUAVeJGTV44KitdQ4fjPmlk2Pg0bcP3GliLz95wDUae5Sh17Hd3xdxM8vwHwN
 /92xNZurZQbPcaPk6+1fy/PHcy27Lp5K56TKLAZ/UjrP8157kG2OLueOXr2xZQwI4VPPRYarA
 dFZtKi7fDswWscp6q2zwfW03eYXCS5PVRVVeQdWEF4NzJZLVFq0ah7Gkp00RNq9ZBz7+l2Icc
 1BvfJC1NyhUUFY38pg0LTnG/mMY=
Precedence: bulk

If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). This issue likely first appeared inside the
dell-wmi-sysman driver, see
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
However, it also seems that the bug was copied from this driver into
the think-lmi and hp-bioscfg drivers. Maybe a more abstract
fw_attr_class could prevent such issues in the future by abstracting
away the kobject handling?

Armin Wolf (2):
  platform/x86: think-lmi: Fix reference leak
  platform/x86: hp-bioscfg: Fix reference leak

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
 drivers/platform/x86/think-lmi.c             | 24 ++++++++++++++++----
 2 files changed, 30 insertions(+), 8 deletions(-)

=2D-
2.39.2