Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Feedback-ID: iad51458e:Fastmail
Date:   Mon, 25 Sep 2023 09:02:48 -0700
From:   Boqun Feng <boqun.feng@gmail.com>
To:     Alice Ryhl <alice@ryhl.io>
Cc:     Alice Ryhl <aliceryhl@google.com>, a.hindborg@samsung.com,
        alex.gaynor@gmail.com, benno.lossin@proton.me,
        bjorn3_gh@protonmail.com, gary@garyguo.net,
        linux-kernel@vger.kernel.org, ojeda@kernel.org,
        rust-for-linux@vger.kernel.org, walmeida@microsoft.com,
        wedsonaf@gmail.com
Subject: Re: [PATCH v2 2/2] rust: arc: remove `ArcBorrow` in favour of
 `WithRef`
Message-ID: <ZRGvKPhgJXWfluyZ@Boquns-Mac-mini.home>
References: <ZRGd4lsNP30L2yB3@Boquns-Mac-mini.home>
 <20230925150047.1961646-1-aliceryhl@google.com>
 <ZRGknJCB6tFgX3Gr@Boquns-Mac-mini.home>
 <0b7fc71c-b3c7-4c29-92a9-587daa46ad59@ryhl.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b7fc71c-b3c7-4c29-92a9-587daa46ad59@ryhl.io>
Precedence: bulk

On Mon, Sep 25, 2023 at 05:30:05PM +0200, Alice Ryhl wrote:
> On 9/25/23 17:17, Boqun Feng wrote:
> > On Mon, Sep 25, 2023 at 03:00:47PM +0000, Alice Ryhl wrote:
> > > > > > I'm concerned about this change, because an `&WithRef<T>` only has
> > > > > > immutable permissions for the allocation. No pointer derived from it
> > > > > > may be used to modify the value in the Arc, however, the drop
> > > > > > implementation of Arc will do exactly that.
> > > > > 
> > > > > That is indeed a problem. We could put the value in an `UnsafeCell`, but
> > > > > that would lose us niche optimizations and probably also other optimizations.
> > > > > 
> > > > 
> > > > Not sure I understand the problem here, why do we allow modifying the
> > > > value in the Arc if you only have a shared ownership?
> > > 
> > > Well, usually it's when you have exclusive access even though the value
> > > is in an `Arc`.
> > > 
> > > The main example of this is the destructor of the `Arc`. When the last
> > > refcount drops to zero, this gives you exclusive access. This lets you
> > > run the destructor. The destructor requires mutable access.
> > > 
> > > Another example would be converting the `Arc` back into an `UniqueArc`
> > > by checking that the refcount is 1. Once you have a `UniqueArc`, you can
> > > use it to mutate the inner value.
> > > 
> > > Finally, there are methods like `Arc::get_mut_unchecked`, where you
> > > unsafely assert that nobody else is using the value while you are
> > > modifying it. We don't have that in our version of `Arc` right now, but
> > > we might want to add it later.
> > > 
> > 
> > Hmm.. but the only way to get an `Arc` from `&WithRef` is
> > 
> > 	impl From<&WithRef<T>> for Arc<T> {
> > 	    ...
> > 	}
> > 
> > , and we clone `Arc` in the that function (i.e. copying the raw
> > pointer), so we are still good?
> > 
> 
> No, the raw pointer in the Arc was created from the immutable reference, so
> the raw pointer has the same restrictions as the immutable reference did.
> 

I see, this was the part I was missing. Thanks!

Looks like the only fix is replacing `&WithRef<T>` with
`&UnsafeCell<WithRef<T>>`? But that's a bit wordy and I'm not sure
whether it's better than `ArcBorrow<'_, T>`...

Regards,
Boqun

> Alice