Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1375397rdh; Mon, 25 Sep 2023 10:44:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQoaejjeULv4vx7mDuJYpZ/7IP6dvU3RjyxjvjYvIH7+j0lazD8m3LRfjEfEMy/0aLvmG3 X-Received: by 2002:a17:903:2345:b0:1c3:a4f2:7cc1 with SMTP id c5-20020a170903234500b001c3a4f27cc1mr9480698plh.5.1695663847853; Mon, 25 Sep 2023 10:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695663847; cv=none; d=google.com; s=arc-20160816; b=B6pU3noFML41h298jzjIoOnzfTsYHNmsqblYP5D9RgDnVn4SYkTJul0tx1tC1pTESk jxaAY+4Hjgfg6eSCUztrCOykAlj7W6E7niClZjKxXigAGU7snKRmPIozUyRj5hlc60wU X2gGLZbgaScK5ZIk3zkIBWe9W1SUptOOquggNnBMuxMbRfGDaOWnBKHWQe8scMjlPAGq uFhCZ2MOq1SkGPevADLE0y0obu7bJmtMWxi3OlxcaCrFUI+fbqXbOjwFbUyF761eTeXq AvgIBSGHfAk38mznEGhl81PsYo9r1qC5v5rbXJCO/U3akLtS6/eT4CL8RO+0WYvRw/fm 2aog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=nw3qGH7/FH4+ugIgrXtTnsAMMytm41mtZb4PZdUTaRw=; fh=u8xkv/KR/Q4wOfABmLr1yq/G8qAgpn8D5gwhBvQWXb8=; b=pGKMCTwcqKcm/QHkCZZyEdphwrx9+YfhcoSVZfl5AP0Fog0j7YrIWgft4B/YYxV07U B5GNvyGLakrxjM2oSpEo0GEGwMehCmRescM9aVvHslfZB6RcWP+0Nwa1lKk5/xND9Mos P0DzbwNXmizTvPLCiEWA8Zc6KmzuD7bo4GvnInaEdo93s3EJAzJrRx8/IwM5/Yh+ehcC nAhPwwVRcbD5aMW73mlKpV+xGUR+BulOzG9JGWvlkF4l7FEB4mRxRMYewFMGamxwtL2t HoPFESlACpsQprbRUcGFp4Stv0xuZ0QGXfUUEmaIdD+dqI1ckz3URs+themW67BoCNrO xsDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=deNy7dVM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id m2-20020a170902e40200b001c5bfb049a4si4626161ple.368.2023.09.25.10.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 10:44:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=deNy7dVM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8D12A8065ED0; Mon, 25 Sep 2023 09:37:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232303AbjIYQhf (ORCPT + 99 others); Mon, 25 Sep 2023 12:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232294AbjIYQhb (ORCPT ); Mon, 25 Sep 2023 12:37:31 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AA3DFC for ; Mon, 25 Sep 2023 09:37:24 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-414ba610766so4231cf.0 for ; Mon, 25 Sep 2023 09:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695659843; x=1696264643; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nw3qGH7/FH4+ugIgrXtTnsAMMytm41mtZb4PZdUTaRw=; b=deNy7dVMO/XkwcpI8t5Nl8gMWPlSH5qVSuO7TfyzQM4wuGFlUVj0NM4u9CILwvAUA7 Z2bqcImSO60IEKCIQsMcbUPO1Q7Fe/F8OkN3sIjFjYTSHj26LjFS/IKaQx61GgQcQaJH Ya3r0JF6sUxgObPwWaKc36Sca4fQvxYo7tgupW203KxLGSB7l/2gxBiKMl9osEfyi4ZS jXysf8vyL71CrYhVeOhm/z9Fijbl6P5J+c7BuwEJz74bdhXy4m6KJvuGSWEv9CEDxEXe qU0pnI9vGKd3RzaBT3bDsDWjzagdjB7mcMgofKULHV5m8794rOnrz/rGrciBsnJSAlNB j/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695659843; x=1696264643; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nw3qGH7/FH4+ugIgrXtTnsAMMytm41mtZb4PZdUTaRw=; b=ZvcKiWqRdNe+s6dSeBQTBZeeYqZZOvYn6JlY/HZWtj5C93MFEUnSO8+ItmnUGlFcgY arj3IxfyU+RaS8G0HLYftSpAYkEhwj6uXVwWQNQyIJUHWJB52FEJ29vPHlhxHhtXMPeW nLe/l2MLrGPQ4GJPLgMeR/+nKNSx4+dZS7PNTV5vu6HbYuHd0jE7JmauT98EVn+3WwZa UHUAisJFu9FFNjunUwrCWyctZAkrpBLPLZyDSqfzqbwk+JMJ8B+x2gtSqSFddKlGxNwq geueaO3khJSebnULzc3OINkJm2DbLyNN9f9i7RDCe8AMmv77RiphJEr7e7xyj8lTuuFw irng== X-Gm-Message-State: AOJu0YzyZUOSLsDxy/mEfBfG3y7bZWDpBz4UqsiWZUnDZjIbHk0uk558 mv0574vLglNqZIOcF7FDOeiKN9SHZAY/pXNppQkrjA== X-Received: by 2002:a05:622a:1353:b0:403:aa88:cf7e with SMTP id w19-20020a05622a135300b00403aa88cf7emr307507qtk.29.1695659843315; Mon, 25 Sep 2023 09:37:23 -0700 (PDT) MIME-Version: 1.0 References: <1695621444-56530-1-git-send-email-renyu.zj@linux.alibaba.com> In-Reply-To: <1695621444-56530-1-git-send-email-renyu.zj@linux.alibaba.com> From: Ian Rogers Date: Mon, 25 Sep 2023 09:37:08 -0700 Message-ID: Subject: Re: [PATCH v10 0/7] Add metrics for Arm CMN To: Jing Zhang Cc: John Garry , Will Deacon , James Clark , Arnaldo Carvalho de Melo , Mark Rutland , Mike Leach , Leo Yan , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 09:37:42 -0700 (PDT) On Sun, Sep 24, 2023 at 10:58=E2=80=AFPM Jing Zhang wrote: > > Changes since v8: > - Add fully match identifier check as suggested by Ian. > - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-r= enyu.zj@linux.alibaba.com/ > > Jing Zhang (7): > perf pmu: "Compat" supports regular expression matching identifiers > perf metric: "Compat" supports regular expression matching identifiers > perf jevents: Support EventidCode and NodeType > perf test: Make matching_pmu effective > perf test: Add pmu-event test for "Compat" and new event_field. > perf jevents: Add support for Arm CMN PMU aliasing > perf vendor events: Add JSON metrics for Arm CMN Thanks for the patience with all the to and fro. I was able to test the series with "git am -3" to get around a merge issue on perf-tools-next. Reviewed-by: Ian Rogers Tested-by: Ian Rogers Thanks, Ian > .../pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 266 +++++++++++++++= ++++++ > .../pmu-events/arch/arm64/arm/cmn/sys/metric.json | 74 ++++++ > .../pmu-events/arch/test/test_soc/sys/uncore.json | 8 + > tools/perf/pmu-events/empty-pmu-events.c | 8 + > tools/perf/pmu-events/jevents.py | 11 +- > tools/perf/tests/pmu-events.c | 65 ++++- > tools/perf/util/metricgroup.c | 2 +- > tools/perf/util/pmu.c | 27 ++- > tools/perf/util/pmu.h | 1 + > 9 files changed, 456 insertions(+), 6 deletions(-) > create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json > create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metric.j= son > > -- > 1.8.3.1 >