Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Qiuxu Zhuo <qiuxu.zhuo@intel.com>
To:     tglx@linutronix.de
Cc:     arjan@linux.intel.com, bp@alien8.de, chang.seok.bae@intel.com,
        linux-kernel@vger.kernel.org, nik.borisov@suse.com, x86@kernel.org,
        qiuxu.zhuo@intel.com
Subject: Re: Subject: [patch V3 09/30] x86/microcode/intel: Switch to kvmalloc()
Date:   Mon, 25 Sep 2023 23:43:33 +0800
Message-Id: <20230925154333.55668-1-qiuxu.zhuo@intel.com>
In-Reply-To: <20230912065501.335403273@linutronix.de>
References: <20230912065501.335403273@linutronix.de>
Precedence: bulk

> ...
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Microcode blobs are getting larger and might soon reach the kmalloc()
> limit. Switch over kvmalloc().
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> ---
>  arch/x86/kernel/cpu/microcode/intel.c |   50 +++++++++++++++++-----------------
>  1 file changed, 26 insertions(+), 24 deletions(-)
> ---
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> ... 
>  static void save_microcode_patch(struct microcode_intel *patch)
>  {
> -	struct microcode_intel *mc;
> +	unsigned int size = get_totalsize(&patch->hdr);
> +	struct microcode_intel *mc = NULL;

No need to initialize the 'mc' to NULL as it's unconditionally
set by the following kmemdup().

>  
> -	mc = kmemdup(patch, get_totalsize(&patch->hdr), GFP_KERNEL);
> +	mc = kvmemdup(patch, size, GFP_KERNEL);
>  	if (mc)
>  		update_ucode_pointer(mc);
> +	else
> +		pr_err("Unable to allocate microcode memory size: %u\n", size);
>  }
>  
> ...