Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1427525rdh; Mon, 25 Sep 2023 12:26:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVQ6V7sdLiTqE5DZZbp0lnW0YvB1a1QQ20R+65sbd+T5Kysm7LdiKem53hA+qmVO4/16/k X-Received: by 2002:a17:90a:bd0c:b0:26b:4a9e:3c7e with SMTP id y12-20020a17090abd0c00b0026b4a9e3c7emr7096960pjr.4.1695669985062; Mon, 25 Sep 2023 12:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695669985; cv=none; d=google.com; s=arc-20160816; b=Q/TqFn6hcNNy8mJlBLubeZFTVo2AxdLJBtvubVtAFR6LuqlvtWa9ZUrYy721dRpGaG LFV/pojIVl3nWNqYSOkfd/YXGDECDsgtS0guUaLBG3KmdJrK4XDydBM4lrLlN+mInJoP 2PdU40LPuRXE6jT8njX8Pm+oNya09DcFAXf5pTCJYE/o3G6TWgsV4ylkTKbaAPF3yv4G p/wrEW+fEg0bXM8MDIvhrGXYOE2df2RahgHsfMayacIPYNlQFTCOGFA11hAn2gCXMdZm 9e52mXiwlPDoRM/H1fjwRHq3oMXaV9HPAwACEiNdhXChELu3buMgZtC0dn76k56dBIfF V2Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=C8AVXr6vllU577ND8JQi6s5Wb2XnBxy1FQk2gXYImts=; fh=BE5PIaNu1W/fuN5RZoxQKl66KdFKPEyU9jys72aFCXc=; b=vBbnxJYk/0hOu8nO3T9hwsNICGrVk+9zSnErhveA0kZosNuO/KS/r5PobnHnKbLNFn TRYXTaTE0mvMFCKRGDRY17DoVZxB2t7LUZkbV73zjHUv0gLATsLLIjwYFPsxPdPwtrnL scaI3Si83CPDbT4DQrg8Oi2qwS4+VuYxil0m6oSmhfsXxAalMYrNoLi+Gr7l6kCWnx0M Rkqwl0zvs73v9P+Lo+4/DJwAmWRgnMsh582J51jwfEF4G/FRdEEqXLkk9mumj4l5h6rO jIbY4o9kZXX/MM9qtBYfGM1ZxT/vP+ezyRxTuCIkLKcqVmeRScXMIewFL9STmFlHQV4e vD3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nwdwXGck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id e65-20020a17090a6fc700b00275cffed966si4726513pjk.57.2023.09.25.12.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 12:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nwdwXGck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 842248037965; Mon, 25 Sep 2023 10:13:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbjIYRNc (ORCPT + 99 others); Mon, 25 Sep 2023 13:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbjIYRNa (ORCPT ); Mon, 25 Sep 2023 13:13:30 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10F79124 for ; Mon, 25 Sep 2023 10:13:22 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso5215651a12.3 for ; Mon, 25 Sep 2023 10:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695662001; x=1696266801; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C8AVXr6vllU577ND8JQi6s5Wb2XnBxy1FQk2gXYImts=; b=nwdwXGckYPlPX21pEof3xnvcqZtcLo+KJ3+jVK0axkL3B9r8vRWYdHvuPmYQG+0SMW 0kplhw0TQhtU0Iwi8LNa4wT1D+uBm3rl8SZyA+8Yw+2aNjTVr3NIha6HuMFqSvToYIPN 2KvBec9sl1KfxAXU/PbYcm2nl3P/IgqmPDnkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695662001; x=1696266801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C8AVXr6vllU577ND8JQi6s5Wb2XnBxy1FQk2gXYImts=; b=lNh/aZnQYuCuZWlUboVSodxI9YOGg872smlSkDh0h4knRhQtapHC4noacBNDnvHj0z ONrjHgDMuIEWoAOncKRSyK4xdJOdxJzhrNv0SLze2gbsajNCM4wm+CYG2nzdirrdqOWq XbJqllOTg2DhF0sECkGK3pwz6pn8UHkarIyqQHqNpoQ2wdZZPTsOgt9h6Lq/odCCoN3a qJZwjkE8eP8WMqrYNO5ao/arMcby7H34WeaHjbvNJ4qXRlwuH4P1TNyKtDvi8IOhAlto WnFf4NQjksGuPoMvc/7nvrvW4nlmG2651ZqhVOxzlTFSfbU0WWCGla8gfoOh0580vTGg gAgw== X-Gm-Message-State: AOJu0YwHkTj5w43iCtW9nyOnBcbofpspV+/lcZok7N2slKAJ7NVLg23/ FF9AOzYJ8SQi+7xy8V2lHnJgkA== X-Received: by 2002:a17:90a:4e4e:b0:268:f987:305f with SMTP id t14-20020a17090a4e4e00b00268f987305fmr6859749pjl.46.1695662001491; Mon, 25 Sep 2023 10:13:21 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 20-20020a17090a199400b00268b439a0cbsm9146846pji.23.2023.09.25.10.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 10:13:21 -0700 (PDT) Date: Mon, 25 Sep 2023 10:13:20 -0700 From: Kees Cook To: Shuai Xue Cc: tony.luck@intel.com, gpiccoli@igalia.com, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, robert.moore@intel.com, linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, baolin.wang@linux.alibaba.com Subject: Re: [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header Message-ID: <202309251012.AD87704BB@keescook> References: <20230925074426.97856-1-xueshuai@linux.alibaba.com> <20230925074426.97856-2-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925074426.97856-2-xueshuai@linux.alibaba.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 25 Sep 2023 10:13:33 -0700 (PDT) On Mon, Sep 25, 2023 at 03:44:18PM +0800, Shuai Xue wrote: > Move pstore creator id, section type and record struct to the common > header, so that it can be use by MCE and GHES driver. I would prefer this was not in the pstore header -- this is a backend detail that should stay in backend headers. -Kees -- Kees Cook