Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1450063rdh; Mon, 25 Sep 2023 13:12:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/E8ZFyJjvh1cZ5cOdyiT2emyistv+xdnw3ozmTzbe6DoZps1NF4tf9DWkKwroLvKX2ILV X-Received: by 2002:a05:6870:2d5:b0:1d6:97:bd7d with SMTP id r21-20020a05687002d500b001d60097bd7dmr10200688oaf.34.1695672723920; Mon, 25 Sep 2023 13:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695672723; cv=none; d=google.com; s=arc-20160816; b=E1xZUYN30E+OwGeHzibPoWdXjuRleVCOwU6NgubF05yaYs9WccoTR/M5y6x18wKzjU a8JZPTwZtlOSopwae2bslDrerLSS3nbPBpwus+nDORAnHdecQhLhMnJOTJO9EXf6Y4mb xNCKbocUsLn+UiIR8/lcfCvrDTl96Nz35+8dO57VRrz9ER8AhwBprUg2BlzJ8Xy89+Dz k9CFyLj/pT7at3LqR5S+f/Pi8NqGDXqRWQ5BxGstb2aHXHofwaZW6mOGcVi1pz4sf+U8 +0So8xZvZ9TWQjZ/0Slnj9iUZ6d/fhXifrOBL6wg9pGDwNwu/0flg2xRMfDR8TH08ZHN x+yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wJKSHvRX2JxkhPx/HsYL92E1VTGeWyXM9NmRTnd2dkM=; fh=Gabplon4a/kw+SV/UjixwE+OggmQ6r8L8lq+WVWOTxg=; b=lt5z6ER16cck351/e6uc8XG8sMnxrVV27Xzm7ymImd3/OIGEewUN+hRzi9b64Y2M4E J7s1ECcTLxEJVlcoJ5kL/ASfmmFCp5/i+ZzKzZBcuubSLOAxkF5uaaGERX7IK8wd9ng6 2UB15q6uNDNGthU89tNUdnHl0MQbNPrPgjpDBDBl2TLqPQkkZffHB7pfuIeUe4VilpAF Q4eCAQr7bGWF+PpbP9YKYAF44Rv8rS+n4+JD7tE5y0GA2EZDqWkfihkb49zJ4Hw1YIiz BtobLd6AktE4Kgm3EJ2Gwz7rnWcSz6darpWIme5vBWrbeSWFVAlEFRFn1N+S8nNpj0A+ phpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=KMgCFdcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u69-20020a638548000000b00578b4980785si10780951pgd.36.2023.09.25.13.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 13:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=KMgCFdcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7D13F8020133; Mon, 25 Sep 2023 07:55:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232443AbjIYOz6 (ORCPT + 99 others); Mon, 25 Sep 2023 10:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232395AbjIYOz5 (ORCPT ); Mon, 25 Sep 2023 10:55:57 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F04810C; Mon, 25 Sep 2023 07:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wJKSHvRX2JxkhPx/HsYL92E1VTGeWyXM9NmRTnd2dkM=; b=KMgCFdcYzdi4gJvjK3P/sbbm3j WY1MDli4qbflqNzaQAQ4MI0hGRJunn+B/+4PUyReklOdHF9lVO8ix/vQjT2pcYI7At97OILvsSP1m anl6QjfMJ/OQ68+T6S2Ng9OcCVmtmfN2vkNm8BTYEAjSTe86zgL2l65ogXqeJTLk6GYethIbJ6eih q90vhS8qP7LHFe298SL/48kJ1oiHSduLIXykGeKNx47B4t955qe1Rmmw0XW7vRuzOVob08iKcPgET 0+BZQrFImlnb+7OREtu+G3JQNwaPYL9zE9AK4isuXxM9R9HukQ1jeQg93Ujowqmvts7m0G4TQUZ+H Yy6BaiFg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qkmzz-00EU4W-2A; Mon, 25 Sep 2023 14:55:47 +0000 Date: Mon, 25 Sep 2023 07:55:47 -0700 From: Christoph Hellwig To: Wenchao Hao Cc: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, Hannes Reinecke , linux-kernel@vger.kernel.org, louhongxiang@huawei.com, lixiaokeng@huawei.com Subject: Re: [RFC PATCH v2 00/18] scsi: scsi_error: Introduce new error handle mechanism Message-ID: References: <20230901094127.2010873-1-haowenchao2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230901094127.2010873-1-haowenchao2@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 07:55:57 -0700 (PDT) Before we add another new error handling mechanism we need to fix the old one first. Hannes' work on not passing the scsi_cmnd to the various reset handlers hasn't made a lot of progress in the last five years and we'll need to urgently fix that first before adding even more complexity.