Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   SeongJae Park <sj@kernel.org>
To:     Juntong Deng <juntong.deng@outlook.com>
Cc:     sj@kernel.org, shuah@kernel.org, damon@lists.linux.dev,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests/damon: Add executable permission to test scripts
Date:   Mon, 25 Sep 2023 20:53:30 +0000
Message-Id: <20230925205330.83701-1-sj@kernel.org>
In-Reply-To: <VI1P193MB07529234393616AE94D58C7B99FCA@VI1P193MB0752.EURP193.PROD.OUTLOOK.COM>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Juntong,

On Tue, 26 Sep 2023 04:35:52 +0800 Juntong Deng <juntong.deng@outlook.com> wrote:

> When running the test for the damon subsystem, there are a lot of
> warnings because test scripts do not have executable permission,
> for example:
> 
> Warning: file debugfs_attrs.sh is not executable
> Warning: file debugfs_schemes.sh is not executable
> Warning: file debugfs_target_ids.sh is not executable
> ...
> 
> This patch adds executable permission to test scripts to eliminate
> these warnings.
> 
> Signed-off-by: Juntong Deng <juntong.deng@outlook.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/debugfs_attrs.sh                    | 0
>  .../testing/selftests/damon/debugfs_duplicate_context_creation.sh | 0
>  tools/testing/selftests/damon/debugfs_empty_targets.sh            | 0
>  tools/testing/selftests/damon/debugfs_huge_count_read_write.sh    | 0
>  tools/testing/selftests/damon/debugfs_rm_non_contexts.sh          | 0
>  tools/testing/selftests/damon/debugfs_schemes.sh                  | 0
>  tools/testing/selftests/damon/debugfs_target_ids.sh               | 0
>  tools/testing/selftests/damon/lru_sort.sh                         | 0
>  tools/testing/selftests/damon/reclaim.sh                          | 0
>  tools/testing/selftests/damon/sysfs.sh                            | 0
>  tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh  | 0
>  11 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_rm_non_contexts.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/lru_sort.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/reclaim.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/sysfs.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh
> 
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh b/tools/testing/selftests/damon/debugfs_duplicate_context_creation.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_rm_non_contexts.sh b/tools/testing/selftests/damon/debugfs_rm_non_contexts.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/lru_sort.sh b/tools/testing/selftests/damon/lru_sort.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/reclaim.sh b/tools/testing/selftests/damon/reclaim.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh b/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh
> old mode 100644
> new mode 100755
> -- 
> 2.39.2
> 
>