Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 25 Sep 2023 09:59:37 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     Robin Murphy <robin.murphy@arm.com>,
        Baolu Lu <baolu.lu@linux.intel.com>, joro@8bytes.org,
        alex.williamson@redhat.com, kevin.tian@intel.com,
        cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com,
        kvm@vger.kernel.org, mjrosato@linux.ibm.com,
        chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
        peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Message-ID: <20230925125937.GY13733@nvidia.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <0d37a1b1-e7ef-fa73-d17c-629cd254ae75@linux.intel.com>
 <20230921164447.GQ13733@nvidia.com>
 <dcde6757-8d14-6460-c75e-c30d69219e4b@arm.com>
 <94004987-3cab-9fde-a231-7c63ac88a866@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <94004987-3cab-9fde-a231-7c63ac88a866@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kGrFdYZVlR3c5s+uwP7Apawu3tAc4HBs8RBtgR6YgP6wD0Kv/UiGNTBgJppM?=
 =?us-ascii?Q?kRIasbRGNr+c1okLkRJ4Z+2OmzrbqmIL2A7V2DI4cCwUSBZwgteMHmQA97oZ?=
 =?us-ascii?Q?mW3/zzkXbKVm8mpI0HvJ6M1KFS17R4P4HO0CgOWrcnvO0UJXOQj+wiP4dwab?=
 =?us-ascii?Q?LvuN37yrRRzWmnyePxsM6Hvgu3fcIPDBNKubDU6V6clRdO3SQNxvZlJnb28G?=
 =?us-ascii?Q?ZsYfx1yZuRr4/etzbTwoxOIthyJxABa4ijeL7C1x23HI7fhqnm2ruBj9j5XZ?=
 =?us-ascii?Q?DSV0ZzeFCARdw0aMbO3qt1tESUsl4CR4lX69cL8tPG6CFrta/Y6y6HCt1akm?=
 =?us-ascii?Q?ZRWvBBh4fk3U+rUT+yqIIrEi8zPri7kNOHEFrkBkhaRjFk2WeIazXLaJc+/S?=
 =?us-ascii?Q?yhZwUxSNnUEgRrq8B3SYfV2+OXQ+cq/Yf5uNNJt7vfgVzFtHq4OL3ShvGc5J?=
 =?us-ascii?Q?3ohchbuoyEnPWdMK8VEwz9dP1Q5IbjArSj0EfwlJTFVRUA3Dv2GWCWSMqXg+?=
 =?us-ascii?Q?h6VcpM7JV4jXDqGvU7UnP7vdUuZ8qa2b3pYePRJ+WRL2jFveaInGfGRNB+gb?=
 =?us-ascii?Q?oBPootyDPZ9qaiggjl7MNXHGcKqKY3qa/YKl7ENollR5gaySjERTRIjIaeDk?=
 =?us-ascii?Q?QHlE7dA87KSR2Sin4ND6VsoMJrkIKp0oXgEbk7td5uoS5vPaAamMwMjSxOnu?=
 =?us-ascii?Q?c2QFthIZjJw749lkoySD9jS2ITDJUFEn732Al+jiYrQCgfKJPQsi+jXFsM7l?=
 =?us-ascii?Q?bK8Hly3vNtdmgCN0rr8xpvOQRNMNgH451XZ4i5DaBu17XEOmTGV9BI1LHprn?=
 =?us-ascii?Q?Kl3k1M8KOXn6ep/NXrcbS/U3jxc9hpGQhzE5T3PW3oHvJj6YrS1vl2FDOupd?=
 =?us-ascii?Q?ZSiX63cPy3X6fp5EbTUoSgYZgBMuC0yP06zfu97eDanA0kDJ1JsFjM493x5Q?=
 =?us-ascii?Q?jFo2DNUOnpa06x7vRKzpSv5dphVFuhGXhcFZuJZ1gjV0oPBz+LZsadiS4ADL?=
 =?us-ascii?Q?XvJKle5mBXarirzZIbGYNQR9/bISEUuveYJaXU5EOTOUttxcLbeHGSMS4wiP?=
 =?us-ascii?Q?XOSlhOsxJx64IBi/fsWdiFLx+8LRYaVjobE+zNzFK5BGWR94nDCZG8QqIsH9?=
 =?us-ascii?Q?aQHGHQW5JvBAI+uky5BcVJoKO1D7LVCXZpaHU0erFbYxycRhpXXNfcipBXJ0?=
 =?us-ascii?Q?sW5gbexgJ5lHXHjvQK9Rd7V0XwyDCegknEo6HWPQUPURIs7rZ7X7gJFEqXcL?=
 =?us-ascii?Q?JT9jds/3TvclTy4w1MY9bpAugVi3fzstSkeI8uVIg+7un9vVjJyBw4gcSOo4?=
 =?us-ascii?Q?HgMmmXFLEURZlu35jvcdlkv99tMojVvL6QA215Ne3jTjf5apCNMeu46bUH5I?=
 =?us-ascii?Q?eD0X8RE3PcyGaEykqBe0gqEqD1hmF0gFuojFQS0IwXUP3dyOaFViRxjZBLto?=
 =?us-ascii?Q?F4sba1XNJ5UvNK11vREK7/8mgrog29MiLJnJ4gwcW4KSFKN91sg4ClQMtiCh?=
 =?us-ascii?Q?YIJeIKPVMOW2sETVeVVeV7FNCV53gNgOktcP8oMfb0WnDcg21YzbNM+Ms3yF?=
 =?us-ascii?Q?5Mq2GNPmBf9Su1LRFVM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47f10770-1165-4622-0682-08dbbdc746be
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 12:59:38.8064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2EJpE/ZaCLmrZo8En1VTicUvR3a12io0kjYGvE7HDq14vJwhgDjui+UTHCNINWne
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7992
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 05:59:47 -0700 (PDT)

On Mon, Sep 25, 2023 at 02:17:37PM +0800, Yi Liu wrote:

> yes. It is just what the existing domain_alloc_user op does. Here we add
> a hwpt_type as the type can be given by user, so we need to define a
> specific type for it.
> 
> Perhaps we can also name it as IOMMU_HWPT_TYPE_UNMANAGED to be
> aligned with

unmanged is also a weird nonsense name these days. We are slowly
replacing it with paging.

> the domain type naming. IOMMU_HWPT_TYPE_GENERIC is also a good choice.
> Please feel free let me know your preference.

This seems OK to me so far

Jason