Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f8582d20-c8b4-4f8d-58a9-aacf2052c7e9@intel.com>
Date:   Mon, 25 Sep 2023 14:19:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v10 08/10] x86/resctrl: Display CLOSID for resource group
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <reinette.chatre@intel.com>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <paulmck@kernel.org>, <akpm@linux-foundation.org>,
        <quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
        <damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
        <peterz@infradead.org>, <jpoimboe@kernel.org>,
        <pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
        <pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
        <daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
        <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>,
        <christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-9-babu.moger@amd.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230915224227.1336967-9-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXZyT1pwU1JsSmlHUTJmemt0d0gwOWhnajVWaUFtYWZVdUlFUlZEcU95UjNo?=
 =?utf-8?B?c1FkZDZaOWRQQ25PRy9HR2Q0eExMUkhEaE84QTJzNlg3d1pPeklXRlRVUGs0?=
 =?utf-8?B?RFI3WnJaaHAvcGF0WXh6MmhEdk0yb2RuVUtGTmhCa1RZN3Y3QnVIK3dMRzht?=
 =?utf-8?B?SnNXM012Uy9BNldlVlUzUzlLVnhrYW5OUkpvL0dCWjRGRzlPQVFjdWF4RUR1?=
 =?utf-8?B?RG5oa3Fya1BXR2prSzRTVkJUSkdJN0pjSHZHS2tSYzYwN0hxdjJtVUpacG9F?=
 =?utf-8?B?YVEwZnNtSDFFVE03a2liYk10Vi9VemNNZ3ZzNCtOVTJKckcwZzYwSUNieEo4?=
 =?utf-8?B?MlhoYUVXeWR6azVmRW4zandKODZJNXlCSjdwbmFBV2tkN0FFbzYvb2JTdnZP?=
 =?utf-8?B?cmlVeVNHYkVBbTZSSS9ROGY3WnNEUzJHcHBqVHRRSzVMNFp2d3l6SVdJcEVm?=
 =?utf-8?B?ZlcvZXgycWpxSUVlTGJITGV1ZWVFbldTak1MZnRiZUxxZnFkMEgyTUx4Wjho?=
 =?utf-8?B?bko4U21UZlFaYTdFMzZhZFlkTXpaL3ljekIvaVJFRUptQitIWTZSN0RXa1c2?=
 =?utf-8?B?RWd4Q1lFUHVLa0hWRHgzQ0RhbXdVOG9kZmlHckR4VG0yVmVRSFArNmtJVjdv?=
 =?utf-8?B?MzZlZjF5OU9wSG9RdzlwZDRXYXZRWTBOZDR0cU91OENkL0xWWW12bWgwWjg0?=
 =?utf-8?B?MDBadEl1Zko5N0l3SXZLWXpZdHJTRXdJM2pCQ3UxVTZXd2tMYTUzUzF6Q3Q0?=
 =?utf-8?B?d0Z6eUJ6U3lBdE5qVUFvamN2WXQyamJRdXJFY2FtbEkwelVvUnBabnMvV0tq?=
 =?utf-8?B?dUZzRlJSem5oYW9XTlRqNmZYT29WL0VrbS9MZXF2dGpQYVJpS05aUStjbmE1?=
 =?utf-8?B?U3pGMGVHSXdJVlNUNzMwUnNhdExOdXUrcXpXRUM2cFZ2cjVNMlFaczUvWG96?=
 =?utf-8?B?U3hjL1JQMXdxUHVZM3ZDR2RrZ1pQQURHOTFPVDdUbWl1M2RDb0VUazRURUgy?=
 =?utf-8?B?Zk1IM0k2MFd3cUNFbXpPRDNpUzZaTFphTE9yczJyZWg0ZFoyRUNHTmxJa1Y3?=
 =?utf-8?B?RnpXVmpwUXliS0JPbDYxOVZJTnoySXlsQmV4dnpxdkpiL2J1ZDFmSWQzeGU0?=
 =?utf-8?B?VGMwQXloeVVYdFFPTHYxQk44dEZVd2JkMk44VHovNUl4OE5sei9HSmlDTjVP?=
 =?utf-8?B?cmR2QmlYK3hjV2UvZGR1VFBFUEkzbnZOV2F2OFlmWkJ4STRtMXlRL1BlYjRv?=
 =?utf-8?B?UnBXa3ZJemw5ZFZRSTNHbDFuYUIvNk5tWksyNGxzb0FtME1KSk5LVy80NnE4?=
 =?utf-8?B?S25MVEh2QVR3YkY0Vk14eGUzK0g3ZEUyVzdjUkNCYzhlYWxmNENFcy9ySHY4?=
 =?utf-8?B?aE5lT1FNZUp3TDNOc1d6OTNETFlBRHJqZmpycXJINlRuU3BubklHMStWdFJG?=
 =?utf-8?B?dEpaZFhmcitvWElhSjRCWGttWEo0bmtlS1M5TTB0eVpFTEZkQUtYOWcwcmh2?=
 =?utf-8?B?YVptL0dTTUVQeTVDc3p4Y3hxd29IcTVraDNWTC9rTitVZ1Q5clJoZHJSVnk1?=
 =?utf-8?B?dXRVaGI3WnNmVG5ZK085d29sSHdtSmhYN1Fkb2YzZEltTlhXa3NnQTl4bS91?=
 =?utf-8?B?QW5ubXIxQ1QrbWF3NkVBc3ZTMG5iZFlVSk4wNFFDQ2NmM2oxUmF6Zzg4U2pX?=
 =?utf-8?B?Y0NGdDVtTGN1ODlSaSttZUdmVmZGUlExck1pYkVWL1ZVZzV2dWpPenB1cDRK?=
 =?utf-8?B?aTBlRmtoeFhNbEoyQis5UVNkNm90SHRUTnNqaFJuZVRIbDdTa2hJQ0VDdlJS?=
 =?utf-8?B?Tk5EMHhKYmNlUmx1VW5DdWtxQTBKRk1GcGQ2U2lnTlIrb2NQSHNrNjQ0amNC?=
 =?utf-8?B?Nm9iRFltc3N0bVQ4WkpzOXZwU01LWDdUa1NpSis0aTVZdllZNGlHVW5LbzJ5?=
 =?utf-8?B?VnhZR0E1d3lkSk93WVd5UzBXdCtZUUVHNDZjazU1Q3creG8zOEwvZ21LN3Js?=
 =?utf-8?B?eEUrc1V4ZkR0Z0JYSmlqVTIvZHNyUmx5ZldzbEdzQTNYYmZOZFFBWXNVZUd6?=
 =?utf-8?B?QVpMd3k3VDROTjV6TWpRTXF6QnZ4TkxFSFliWndzUENaYlY1b2dhWHhpUVdl?=
 =?utf-8?Q?b4lavKCAVrFFiNr2PllucAk/t?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d65cdb0c-72b8-4240-335d-08dbbe0d0d31
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 21:19:07.0238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aIDeE2lrPsLWHA3uZGCoHgVSe6732Kg1PWIajRbQRPEDY5MQjrlxkBR3zsbfvKYZrsE3l3AynT/59s4/HUYYkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4707
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 14:19:59 -0700 (PDT)


On 9/15/23 15:42, Babu Moger wrote:
> In x86, hardware uses CLOSID to identify a control group. When a user
> creates a control group this information is not visible to the user.
> It can help resctrl debugging.
> 
> Add CLOSID(ctrl_hw_id) to the control groups display in resctrl
> interface. Users can see this detail when resctrl is mounted with
> "-o debug" option.
> 
> Other architectures do not use "CLOSID". Use the names ctrl_hw_id
> to refer to "CLOSID" in an effort to keep the naming generic.
> 
> For example:
>   $cat /sys/fs/resctrl/ctrl_grp1/ctrl_hw_id
>   1
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua