Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20230922193639.10158-1-vishal.moola@gmail.com>
 <20230922193639.10158-2-vishal.moola@gmail.com> <fd2149bb-2c5f-222c-5134-ae251910b3cc@redhat.com>
In-Reply-To: <fd2149bb-2c5f-222c-5134-ae251910b3cc@redhat.com>
From:   Vishal Moola <vishal.moola@gmail.com>
Date:   Mon, 25 Sep 2023 11:57:51 -0700
Message-ID: <CAOzc2pxjg=ReO_3s-LWu_iwik=5ASS3qL-2dKGjd6BN6AthH2w@mail.gmail.com>
Subject: Re: [RFC PATCH 1/2] mm/khugepaged: Convert __collapse_huge_page_isolate()
 to use folios
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 25, 2023 at 12:18=E2=80=AFAM David Hildenbrand <david@redhat.co=
m> wrote:
>
> On 22.09.23 21:36, Vishal Moola (Oracle) wrote:
> > This is in preparation for the removal of the khugepaged compound_pagel=
ist.
> >
> > Replaces 11 calls to compound_head() with 1, and removes 499 bytes of
> > kernel text.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
> >   mm/khugepaged.c | 52 ++++++++++++++++++++++++------------------------=
-
> >   1 file changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> > index 88433cc25d8a..f46a7a7c489f 100644
> > --- a/mm/khugepaged.c
> > +++ b/mm/khugepaged.c
> > @@ -541,7 +541,7 @@ static int __collapse_huge_page_isolate(struct vm_a=
rea_struct *vma,
> >                                       struct collapse_control *cc,
> >                                       struct list_head *compound_pageli=
st)
> >   {
> > -     struct page *page =3D NULL;
> > +     struct folio *folio =3D NULL;
> >       pte_t *_pte;
> >       int none_or_zero =3D 0, shared =3D 0, result =3D SCAN_FAIL, refer=
enced =3D 0;
> >       bool writable =3D false;
> > @@ -570,15 +570,15 @@ static int __collapse_huge_page_isolate(struct vm=
_area_struct *vma,
> >                       result =3D SCAN_PTE_UFFD_WP;
> >                       goto out;
> >               }
> > -             page =3D vm_normal_page(vma, address, pteval);
> > -             if (unlikely(!page) || unlikely(is_zone_device_page(page)=
)) {
> > +             folio =3D vm_normal_folio(vma, address, pteval);
> > +             if (unlikely(!folio) || unlikely(folio_is_zone_device(fol=
io))) {
> >                       result =3D SCAN_PAGE_NULL;
> >                       goto out;
> >               }
> >
> > -             VM_BUG_ON_PAGE(!PageAnon(page), page);
> > +             VM_BUG_ON_FOLIO(!folio_test_anon(folio), folio);
> >
> > -             if (page_mapcount(page) > 1) {
> > +             if (folio_estimated_sharers(folio) > 1) {
>
> For a tail page of a PTE-mapped THP this is not the same.
>
> The possible side effects this might have should be spelled out in the
> patch description.

Ok, I'll add the side effects to the commit message in v2.