Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Laurentiu Tudor <laurentiu.tudor@nxp.com>
To:     shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: [PATCH v3] arm64: dts: ls208xa: use a pseudo-bus to constrain usb dma size
Date:   Mon, 25 Sep 2023 18:10:15 +0300
Message-Id: <20230925151015.4449-1-laurentiu.tudor@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hC8dVc/beVIZFcK/65HvwB2kLQjrH5Verd+yqMWJ79eDb2xRR84co6NEpMJG?=
 =?us-ascii?Q?3f4qoX9n5PfZDquA6t+UpsOo2GEZEBndImnaE01aQEBGVIaky0VJ4V8ZXN+U?=
 =?us-ascii?Q?UGxjBKm0WQHL0CZYiQOO/+o4q24WxeVNeI4PbjPSpsejqT5PtO19WfRNUnKr?=
 =?us-ascii?Q?s3VMYQLiVjmQQNFZNRyTQ8bxceSBG53JUs1EeKt/Yi9fIwqBGoqcinn87+ps?=
 =?us-ascii?Q?TSgSY6akqmAwPx8odpT2ojixeqzL+aOKV+Rlg4Na8xCyKZJr96V9oN92oNFs?=
 =?us-ascii?Q?nD8XHyEMAdIfZonUYG1Y1USYEDQwniLZ9dsTtewZ3jlsbJbsP/7VQ6231Tu+?=
 =?us-ascii?Q?8RczBLkqkZxZs0bNb1qaC1QJiQixjNAkC3m580moofc8OCt1w1FjJPqAfW4W?=
 =?us-ascii?Q?deP0vWUs8weMESWyJJCdbqMz0bqXAytYUH+PE9uKFXK9bFqpRvutPvV6FSF3?=
 =?us-ascii?Q?JPkDn8s83qOB8WOYdJ1WS8oFSCytz7jnMQOhtTav1S02HtSOQwAzUQC9pkhD?=
 =?us-ascii?Q?qYYVL+DcJX9gA+j5wc2nruxoAKA0Qe2mUuYcnxmg68gbzyLGVRpKVFB83msx?=
 =?us-ascii?Q?yVplDTmcOz9mz2T0ic3BYuYpfIl6F4JoCKlgp46t211HJwxESZ7ZNjlVgvi+?=
 =?us-ascii?Q?1TZVRJZtIMXhg0drIjbvIrGpr2lVil0ePS0ujRxExvYtqfvQsA/A68i3kE0n?=
 =?us-ascii?Q?6fTOaOgzRDkEe/hAztLoG3u38U/cuanGPX73w8DDZJZkcxXyhjw4vtcYXPKB?=
 =?us-ascii?Q?j53cu+B7bJae8Fr4ABPt8zZYRUo3YNIJOvHNBJ/EqSQlF4bBuF/KQqL69FVo?=
 =?us-ascii?Q?jy57Kh5JrM8xZdj4+Ug6nLGw/ZZwR1RcYBoiTfRx80Ujpf3mK/p0yuN5jN5Y?=
 =?us-ascii?Q?fpw21we8+NnUv4qJv0SC+WwasMDlM+X9r251IYTd5c5Os0oTHdvryZDxKwXZ?=
 =?us-ascii?Q?Np44bVx6xL7vsO0sQhj/TmRFzcV1NHHpUs0xSBkuK/TtDXLSMfhuC4kS+ca9?=
 =?us-ascii?Q?7+8J7PT6hRczadk0he38cBwf/xo7SobB7hqvpYHB2UU/9urTIb6GzgSOhe7P?=
 =?us-ascii?Q?HSxujj5uOwtki0Que1MgEVA3Ps4Qexh2GVVNAd/U6ft7Z56pwMK8rODDLWku?=
 =?us-ascii?Q?MsP45CPN0tH9hCDV7QnQGyBt/d2VbqmzK/7VA5fl2xGmKeSmn5lw/7l7R3dd?=
 =?us-ascii?Q?SOnz65WfhgLbitdqphEoVUBAtQB1PgtU+tW3AuR2qBJtA7P94bi5L7m+S6mS?=
 =?us-ascii?Q?1Y5XLEkNvhYSbXLZNg5IoLtsV4oWQZvLZotSNfd8sA7y3tcjM8DbYpi2xrVB?=
 =?us-ascii?Q?UsBQqccQ6/yx1OyNKZU5orzXdSPxHyvBUaQbFfjQxyBRaRoW5elHgc4qodsE?=
 =?us-ascii?Q?4aTyRHlUXe8Ymiiyrr1PUq8uuOq9GOLlCABL1ap2YKXOxmyKjSGJ6PydfATB?=
 =?us-ascii?Q?GGaWehw40m9G7o3/hPUD+sJ8ue19GGfR+afYQ/SAmlwlJ6zmRibJznHgZtuu?=
 =?us-ascii?Q?9w6f8V5TJktlewAVWH4SnD4DB/8BetoSlYc33CtgAH6Mus7ZZij969Inrf1s?=
 =?us-ascii?Q?Pkh6ArKvs/EA+CQ9se0ao0iliTQQNO7EG3RmqEyP?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1516f1e1-1554-4063-c05b-08dbbdd98bc9
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9380.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 15:10:25.5378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qn+TlZNLIrKVd/J28+fNXzwuUEM3OLCTc41yYJwTeMs6Wpn/SLMkRijoNweNVxYlveTOWQ9si9TkL13AjMJaBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9204
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 08:10:42 -0700 (PDT)

Wrap the usb controllers in an intermediate simple-bus and use it to
constrain the dma address size of these usb controllers to the 40b
that they generate toward the interconnect. This is required because
the SoC uses 48b address sizes and this mismatch would lead to smmu
context faults [1] because the usb generates 40b addresses while the
smmu page tables are populated with 48b wide addresses.

[1]
xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1
xhci-hcd xhci-hcd.0.auto: hcc params 0x0220f66d hci version 0x100 quirks 0x0000000002000010
xhci-hcd xhci-hcd.0.auto: irq 108, io mem 0x03100000
xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2
xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed
arm-smmu 5000000.iommu: Unhandled context fault: fsr=0x402, iova=0xffffffb000, fsynr=0x0, cbfrsynra=0xc01, cb=3

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
Changes in v3:
 - move 'status' prop to the end

Changes in v2:
 - renamed pseudo-bus from 'aux_bus' to just 'bus'

 .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 46 +++++++++++--------
 1 file changed, 27 insertions(+), 19 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index d2f5345d0560..717288bbdb8b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -1186,26 +1186,34 @@
 			dma-coherent;
 		};
 
-		usb0: usb@3100000 {
-			status = "disabled";
-			compatible = "snps,dwc3";
-			reg = <0x0 0x3100000 0x0 0x10000>;
-			interrupts = <0 80 0x4>; /* Level high type */
-			dr_mode = "host";
-			snps,quirk-frame-length-adjustment = <0x20>;
-			snps,dis_rxdet_inp3_quirk;
-			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
-		};
+		bus: bus {
+			#address-cells = <2>;
+			#size-cells = <2>;
+			compatible = "simple-bus";
+			ranges;
+			dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x00000000>;
+
+			usb0: usb@3100000 {
+				compatible = "snps,dwc3";
+				reg = <0x0 0x3100000 0x0 0x10000>;
+				interrupts = <0 80 0x4>; /* Level high type */
+				dr_mode = "host";
+				snps,quirk-frame-length-adjustment = <0x20>;
+				snps,dis_rxdet_inp3_quirk;
+				snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+				status = "disabled";
+			};
 
-		usb1: usb@3110000 {
-			status = "disabled";
-			compatible = "snps,dwc3";
-			reg = <0x0 0x3110000 0x0 0x10000>;
-			interrupts = <0 81 0x4>; /* Level high type */
-			dr_mode = "host";
-			snps,quirk-frame-length-adjustment = <0x20>;
-			snps,dis_rxdet_inp3_quirk;
-			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+			usb1: usb@3110000 {
+				compatible = "snps,dwc3";
+				reg = <0x0 0x3110000 0x0 0x10000>;
+				interrupts = <0 81 0x4>; /* Level high type */
+				dr_mode = "host";
+				snps,quirk-frame-length-adjustment = <0x20>;
+				snps,dis_rxdet_inp3_quirk;
+				snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+				status = "disabled";
+			};
 		};
 
 		ccn@4000000 {
-- 
2.17.1