Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Qiuxu Zhuo <qiuxu.zhuo@intel.com>
To:     tglx@linutronix.de
Cc:     arjan@linux.intel.com, bp@alien8.de, chang.seok.bae@intel.com,
        linux-kernel@vger.kernel.org, nik.borisov@suse.com, x86@kernel.org,
        qiuxu.zhuo@intel.com
Subject: Re: Subject: [patch V3 08/30] x86/microcode/intel: Save the microcode only after a successful late-load
Date:   Mon, 25 Sep 2023 23:30:04 +0800
Message-Id: <20230925153004.54984-1-qiuxu.zhuo@intel.com>
In-Reply-To: <20230912065501.269244004@linutronix.de>
References: <20230912065501.269244004@linutronix.de>
Precedence: bulk

> ...
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> There are situations where the late microcode is loaded into memory, but is
> not applied:
> 
>   1) The rendevouz fails

s/rendevouz/rendezvous/

>   2) The microcode is rejected by the CPUs
> 
> If any of this happens then the pointer which was updated at firmware load
> time is stale and subsequent CPU hotplug operations either fail to update
> or create inconsistent microcode state.
> 
> Save the loaded microcode in a separate pointer from with the late load is
> attempted and when successful, update the hotplug pointer accordingly via a
> new micrcode_ops callback.

s/micrcode_ops/microcode_ops

> 
> Remove the pointless fallback in the loader to a microcode pointer which is
> never populated.
> ...