Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Armin Wolf <W_Armin@gmx.de>
To:     markpearson@lenovo.com, jorge.lopez2@hp.com
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] platform/x86: Fix reference leaks
Date:   Mon, 25 Sep 2023 16:28:17 +0200
Message-Id: <20230925142819.74525-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:iZ542rEmHXA=;e+TNDwZ5hRC0vlET3hTVp6gKna2
 s9/vbFZBY5k0Nm3DZgnrHOAdt88aH5INE5uwM+hmhc12EFe5sJXiapSeiwIEaA6DdYTKrxw2q
 o01ZzFEJK5lvjoEjCmr0I5E1vnjX+srpiDwn5qYzNvciAF/wvQ7KQVffzsjrL0oYqkoFzb8zO
 KU7yWdCIxTNusDAOFuEhIfEXtYOO1DEdPLrSHL4xbiZqGf2ek8fpwQ1dEjIVs+j3NeHsy5w6V
 ihzyvisJs0G4ceDqwPWu0xTuy/PRseqLfBQqaYMrCoVl1qxlV3ECt6sgOOpRegjdxw6U0dSQg
 FsJDBliAopAR/Epp7qnmiTNrTp0U0wF43blKoi/EawiGshNmdItOohH4XZ7SA7UgUWwX0y6Tj
 3QyBjTYQKuBg303/UzXDMzH14csw+5HzOyfml8TaW6np6lWWr0xg/YiMSDTHFa7FEZerif+7k
 Uc4+UJkVPk5F+Kpuam/YdYSFQPKgaxiNXALkmNLQV86aGNZaj1macH4MsiOFjdj5B0mhY/TWD
 nSO96mm0yBK91zIXuG7n7fkqrmu6dyEbwW9izOinmNZRlKQMYdcm/bVxkvnoWM/34aKUOFCxQ
 A4KmQhxbgScHvzugG0nTZQFID0a6OLfElRci6hpyKmy1FdgnLu9hF31YKQmqSE2SlxMIJlpWX
 fjfH2Y8kDa80bmDOg8kWk33ylQ5o18vS3SisNE0Q/s3bEfFWWxZ9yKk14wir620tBtSgLqy+e
 nE+qctvQG4pRDHOgEEOFrqZifhOjddNeh2XPPtfwp0Tbs1xbF9N0cXihG1Ms/Nc1CttK2sCV+
 zZJsd4oEP/2Pfn98BCLGzyS/4Nd48QYQdCTTu5hkIFB/jMyfRqTDPMhE4uwl0FsUzH6wsCx4u
 yUWEHy85oAE2gCtWk++Z5dBiCYG/0S2Xlt2aF97BuQf1mfbT8lAnKdcSSYAvOVzfPTYvU5jeZ
 UOwA31aApfnqntWe0TDE+4/UAbU=
Precedence: bulk

If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). This issue likely first appeared inside the
dell-wmi-sysman driver, see
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
However, it also seems that the bug was copied from this driver into
the think-lmi and hp-bioscfg drivers. Maybe a more abstract
fw_attr_class could prevent such issues in the future by abstracting
away the kobject handling?

Armin Wolf (2):
  platform/x86: think-lmi: Fix reference leak
  platform/x86: hp-bioscfg: Fix reference leak

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
 drivers/platform/x86/think-lmi.c             | 24 ++++++++++++++++----
 2 files changed, 30 insertions(+), 8 deletions(-)

=2D-
2.39.2