Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 25 Sep 2023 09:11:44 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Michal Wilczynski <michal.wilczynski@intel.com>
CC:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <rafael.j.wysocki@intel.com>,
        <lenb@kernel.org>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <rui.zhang@intel.com>
Subject: Re: [PATCH v1 9/9] ACPI: NFIT: Don't use KBUILD_MODNAME for driver
 name
Message-ID: <6511b140c87aa_acca294d8@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230925144842.586829-1-michal.wilczynski@intel.com>
 <20230925144842.586829-10-michal.wilczynski@intel.com>
 <ZRGrk8/0UMd9FuFH@smile.fi.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZRGrk8/0UMd9FuFH@smile.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m2eWm4ThU4j99qKLg5L56tos+kHSB08keOf8BkqblRYhrvewnwNHLvPhKqzO?=
 =?us-ascii?Q?Sgmg0hK3ZJY1hc5lLUWn/MW2vZ5lQWlpSsn16Z36BtRe73kZ+S5CPozQerR3?=
 =?us-ascii?Q?3ZpAkNuWW/0aZ3hwKfxFVeO33748+Sg46708bmR6wBUJ3uhABMclIykHLlbu?=
 =?us-ascii?Q?UaC5bxTt6g5g/aRaPFHw7AhEM5AMwHzIGA2aUHkxQfhlYUQsVL32YAdCQonB?=
 =?us-ascii?Q?3PWGYtJ7JHObMe+sjDO+rw582tdf98PC5ZDroXXACNvuX4Enlg2eLbWrlbEi?=
 =?us-ascii?Q?67q/HHXL/vMQKewo0IDu+688Wx6wG/RgQSabL/jaBYxQJHr2ime2EgCXmOof?=
 =?us-ascii?Q?8cNjG5k6Nqk1I3bQChqOYL98bPevcwRReXi+a2os8HEzfq/bPPTrusfwq+VA?=
 =?us-ascii?Q?Pf5c6QXkNyMuhtGE8fDV0VszVIaE6UUiQUHoO0zNNt4WcWLuPvwoOK3D65+8?=
 =?us-ascii?Q?sNywGIeuk465CpJRyZN9oBSOQHva2Vt2ZRzxnNKWnCxuTyRwO+qwV+94o3xz?=
 =?us-ascii?Q?NdaW6EdBS3YP3w3vMR23PulbnEyLnQgNdjV9IUeo60/E9ulnpCMGH/0O3mlp?=
 =?us-ascii?Q?lZ3rAuDHiomnJG7EUzJCUY3XAuWLnbkcXbwLjKPnSwYUSUCEE2hIUpAQrn9U?=
 =?us-ascii?Q?iP4dwbAGPz6FIa5nClZAlhqnxDjlxULniShIzbri2PuFiMBn01C5JnVslhGR?=
 =?us-ascii?Q?g7JqM61FF882LI0s1b+9U2reeCrf3QFkrXd6LLwTpc5GkzbmVppuiK6SXmcz?=
 =?us-ascii?Q?AQwrpXIH9FTedLoNp6tc8UTzjVseMknWlWxxDw9/AlmxGPtWnRkUcr3589TB?=
 =?us-ascii?Q?CW6GM5BmaPwfvp5FPKXecvArbtmScPcEBPorIH9zBT8jBamOgFiiKvHwfIgm?=
 =?us-ascii?Q?eEdEUIBfNTLANs0//9acBnlUJQV6OFvGk0LIA9QN40f1IpzOkXG1sHXNVFUK?=
 =?us-ascii?Q?2eLlYeiPa++LGiyIeX2y3pIHDsln+kQDSCMAhthRZPnADCIMyBSeuWTgQ+H0?=
 =?us-ascii?Q?8msSQbN5OTLvReMqTsPmRlx2WBlJB5EUUa+WFCv6gdHB4NVMFlW20wl2mIb8?=
 =?us-ascii?Q?ZMKuVyZSeyZhGVDG7FT2bIKDDbx9NrSo2cbQS6uswWBu4WHOVgEdxROkmf1S?=
 =?us-ascii?Q?5gMNsjWxMUtQ8Cym0WCnKie8g8a2LORdMqk5YbaZjXmNJmkygLqmr/tHtySX?=
 =?us-ascii?Q?bKfZrsPU1G+ww4dcmHDGOteiLdrCs0wqMGAe+DNJbivN7DlSB4DUrF0XsP/i?=
 =?us-ascii?Q?kbJWMw0SrthTCiaC9eEpXStBH63gNHCK2UVKuvX49owvT6Q/M94rOAd+xUKl?=
 =?us-ascii?Q?fOTiQqdvUO708g20YKat6jd/6okZO6up6vL4WeNBkp6TfpzxsZBUJJaaaRgE?=
 =?us-ascii?Q?NsyQsEVuLkog92+qr6w3SA0w8ikgs+TVTzAybZ6k3kASxq1yptI9Ebuq/s6H?=
 =?us-ascii?Q?6VfLkoEmgVKmYy4V2M5lzeVTYmEq8pJbtzurcGPyMl9MLZTVnCpXvtMGZbPN?=
 =?us-ascii?Q?PE3RQmmMApVDDT4HL/Ak3+VPgA3KXdL40CKo177Vj0fyNoBMBAMQiPs7C7KQ?=
 =?us-ascii?Q?lJzBYdXokJEa5wa40Z/YD03pKUygoujuGAqGJuGpCz0gnPRUCSfbc5TrGwKg?=
 =?us-ascii?Q?Pw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0edd7a76-301c-456a-3ad9-08dbbde21f35
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 16:11:49.0298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f9xXb7I0iEDRgkhxXmtNPPRPIZBKabJjYdWF0vT+XRtaPPevyfpeDwh9IcbD2+X2iNOelvnOG7eHMCLQp9OAbrI2Kr2GbSsIhRDoltJ76R4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6537
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 25 Sep 2023 09:12:15 -0700 (PDT)

Andy Shevchenko wrote:
> On Mon, Sep 25, 2023 at 05:48:42PM +0300, Michal Wilczynski wrote:
> > Driver name is part of the ABI, so it should be hard-coded, as ABI
> > should be always kept backward compatible. Prevent ABI from changing
> > accidentally in case KBUILD_MODNAME change.
> 
> This is up to maintainers, probably we won't have any users outside of existing
> model (instantiating via ACPI ID). All the above is "strictly speaking"...

...right, more than 8 years for this "risk" to materialize indicates
it's a non-issue to me.