Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 26 Sep 2023 01:37:58 +0200
From:   Alejandro Colomar <alx@kernel.org>
To:     Axel Rasmussen <axelrasmussen@google.com>
Cc:     Peter Xu <peterx@redhat.com>, linux-man@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes
Message-ID: <fn2nopit4w4gu26ysqzffzobukvlvj77adykh5ythobk6rcljb@sdfwmlzpnf2f>
References: <20230919190206.388896-1-axelrasmussen@google.com>
 <20230919190206.388896-5-axelrasmussen@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7vgy4blmhwfscbm4"
Content-Disposition: inline
In-Reply-To: <20230919190206.388896-5-axelrasmussen@google.com>
Precedence: bulk


--7vgy4blmhwfscbm4
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes
MIME-Version: 1.0

On Tue, Sep 19, 2023 at 12:02:00PM -0700, Axel Rasmussen wrote:
> - Fix missing paragraph tag. The lack of this tag yielded no blank line
>   in the rendere dpage, which is inconsistent with style elsewhere.
>=20
> - The description of UFFDIO_WRITEPROTECT was a sentence fragment; the
>   last half of the sentence was left out by mistake. Add it in to fix
>   the issue.
>=20
> - move UFFDIO_WRITEPROTECT 'since' to its own line All other ioctls
>   note the kernel version introduced on a separate line from the ioctl
>   name. Update UFFDIO_WRITEPROTECT to match the existing style.
>=20
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---

Patch applied.

Thanks,
Alex

>  man2/ioctl_userfaultfd.2 | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index b5281ec4c..339adf8fe 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -31,6 +31,7 @@ using calls of the form:
>  ioctl(fd, cmd, argp);
>  .EE
>  .in
> +.PP
>  In the above,
>  .I fd
>  is a file descriptor referring to a userfaultfd object,
> @@ -351,6 +352,7 @@ operation is supported.
>  .B 1 << _UFFDIO_WRITEPROTECT
>  The
>  .B UFFDIO_WRITEPROTECT
> +operation is supported.
>  .TP
>  .B 1 << _UFFDIO_ZEROPAGE
>  The
> @@ -693,7 +695,8 @@ field of the
>  structure was not a multiple of the system page size; or
>  .I len
>  was zero; or the specified range was otherwise invalid.
> -.SS UFFDIO_WRITEPROTECT (Since Linux 5.7)
> +.SS UFFDIO_WRITEPROTECT
> +(Since Linux 5.7.)
>  Write-protect or write-unprotect a userfaultfd-registered memory range
>  registered with mode
>  .BR UFFDIO_REGISTER_MODE_WP .
> --=20
> 2.42.0.459.ge4e396fd5e-goog
>=20

--7vgy4blmhwfscbm4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUSGdYACgkQnowa+77/
2zK1TA/0DhG5yr7StwFzK4NjnJiDDw+3oacXTZgx6sa0kYYJDqe3o0Bb5SosjsGE
ltXNDkCkF+0PaUc85M4zaqpuLtQk/1dYDcn8ySRkl4smkbNhrWd6Bl/2RZc+uUJI
KHob3h7Ilt/NIoDuHQBnjleuFrQHQ1ofUZ5RSq5BRyn7JFmTu3Unls8bHWMu+YE/
X8knCMHGQbKm0Y6u9QhMB8rOgUM967n9tV+0i201XmFYkqInb6cbVr0xNCfDRl8m
paC6fGbhxeyqDxpSbJi6xa3d4/PZ1PTl7XxuUC3fTCkx6t2r27UVLeWcb5r4fTV7
zV1+tg+dnFxJYyO4LTQCgDYA8jUKjWCmebkXg5MHUB/XXwFxWZk78TNNCgIf/poj
weGXn8XbJamFujFPzhAlNlNC07zZPWsHgo5wusxilBFEw2TwmxLxJZjTQmOS3K4c
RIbxD5ALLiOPYEfasYOZkMLxtLIiXHAwuG8Z5Wj3Lu0HaTkJy7D2fMxtATIcmQ5R
SMhT6QvoT1GtJNn2zGJ3McSwFkK356ECwocQuUp+MTRnSX/OxAQ3raf/VlNhujOA
MQMSo6jQdIh4/Rt2HRHgKK+ql7O2FwyTVB2Iw5jiu/NssYokU6qzUq+xZID979ib
4dGcxnIv9+ChW2xfaEA0Kd25ODId3Iiz/qYHcOldYym1txp+Eg==
=x8ug
-----END PGP SIGNATURE-----

--7vgy4blmhwfscbm4--