Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <8db70d9a-28e0-1b3a-afb2-e569037471cc@intel.com>
Date:   Mon, 25 Sep 2023 11:25:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 6/9] platform/x86/intel/ifs: Metadata validation for
 start_chunk
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <20230922232606.1928026-1-jithu.joseph@intel.com>
 <20230922232606.1928026-7-jithu.joseph@intel.com>
 <e628f81c-5023-2e59-f45f-e76885e41446@linux.intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <e628f81c-5023-2e59-f45f-e76885e41446@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXl5cGNhRFljQUY5VWJWUEZPOTE1amUvMHJXSlNMY1FtL0w2NE9wdUZ6dFpp?=
 =?utf-8?B?bHJTRHFMbFE3cnFKWGs3aWhxZnRqb2J0bFdRT1dXN2NiVVFtVlVXdWRxODVk?=
 =?utf-8?B?MVdENkRiNG9rMlZNOWNoVVVvZ3VlUVZKYTRPeDVId3huWVZCMENCUzBGOHFm?=
 =?utf-8?B?N0NHYjJrV09jUnIrWVBwaGEzRk5Ba2E4YVQ5RFE3ZUV6U0VWWFkzNWhhWGsr?=
 =?utf-8?B?Z0pxdk5Sa1VjYnFQcERCVGE2NVNiYzlQbWVyaDZFYUg4S3hNcFJIQTJlL3BN?=
 =?utf-8?B?b1c4YXZyRWhiVTFCTm8wVlpxQ3BtY0VqVCtyUXYvZEI0cWxwQXF6bWJRL1NZ?=
 =?utf-8?B?MUdKa0FzbGw4VjFndTlxRVA3bGpWUk1WUHVGSnhZb2xvS0wrWHZVcnhNMGZV?=
 =?utf-8?B?cnhjMVgzblJRZnl5YlYwME1KUnFRWkdod1E3MU9CZkhZWFRHbldJNm5UTTg3?=
 =?utf-8?B?RFUzcnd1bnBaSnVSb0F2SHc4ZG5DT01DYXEvcHRHTkVieFpFR3MyL1lBb3Zm?=
 =?utf-8?B?T1lnQzdUdm1ZOXlqdTJCQndlanZNR0h5c3R3VVc2K0dzNUsrdWN4dkV1aWlQ?=
 =?utf-8?B?VCtVd3ZiQ3V5eVBjem1QK2QzOXljS3hrWitaK1ZTUkpRa3JoNlduNDh5T0Jm?=
 =?utf-8?B?U2srNjBTU0NJcTNrQkZKVGdRYlJ6OUhLMU5xRzVZYmZ5cklLMDlXNWgxcDhQ?=
 =?utf-8?B?dXlxcDJjSmF2S2hxU2xOTE9UQ0g1ZmdTOXhmVkhrYyt4Y3Btcitib1l1eGM5?=
 =?utf-8?B?ZXNRL3lqNlVRSU0rcWdGS3ZIbVk3VG1yYTRhNnVVRXBVbll4YkFLeWlsUlpU?=
 =?utf-8?B?UElaTE1ZU1J4b3JtcmJDY2VjOS92Ykw2THBiNHRVelJsb2NGQ2cxOUdUcFpI?=
 =?utf-8?B?b2t0ZnBtYm05OExBcUdvd0JYWVNDS2dUeHFxWUYrZ1FqUmNiaHI1VUFraW1m?=
 =?utf-8?B?TG93VGVwNzdxcUFmejJicXQwN0QxWWtobFVja2dKSkNUaWFSckxEbWcrZDJm?=
 =?utf-8?B?aXhpNWFpcWpvb2NsMitja0E5S2JBS2FmeFZ6NWtzZU1ib1ZRaWxrcGJvZmR3?=
 =?utf-8?B?bWdVRXY0N1MwOW42dnhsY0RoVXBUN1NIczhyVXpzM2ErMTY5R29YUlpjc3hY?=
 =?utf-8?B?aUt0RDRMZDhMaFZ0K24vOXV5MWJJRWkwY1UrL1ZTdHU4bWxtTHRYN0NBNkRE?=
 =?utf-8?B?SE5uQW5xK25RdHBlTFdieWxIL2xpck5UZ2R6WERWTjk4U1VhcnpLQU9wUTB0?=
 =?utf-8?B?RHR3TFFTV25wRURROEpRRDAzUzNJRDVvOSswSTlMUkZ4bDNXSXV1WG5SSmQ5?=
 =?utf-8?B?UW51dVAwbi9YTndhOWphbmhjd3NrVkdUc2E5Y0tqRkVHYUU3NEptNW5jc2xN?=
 =?utf-8?B?bWg3SnV2SFpLZUQvY3hhN3pacGRHditDQlRzclRUZFByQVdZOG9vZnVBV1hx?=
 =?utf-8?B?ZFJFVC9RcFJLdW51Rk12YVlmM1RaSmdVOXVOTzQwV1h1ODJnY1FQZTU3SWdi?=
 =?utf-8?B?Zk95T2xMdlNSS2UzWTFFcGpTckc4ZE1qMDVMMFRuZ1hLK1lrSkRiWktoSFI5?=
 =?utf-8?B?a2x0Qm8yNmZZWVNJKyt3bGZweVhxcFBoSFhpR0hpZnhGaDgxVkluSWorRWJL?=
 =?utf-8?B?UzRsOEVXMDZVNU4rTkRRVjhncjc3aG05TnhhRlJKSVJQbDUyblZEUHEzL2xm?=
 =?utf-8?B?aWhXUTVPSFpuQit2bTdKOUNjNHZ1NzVpUW1aVFQ2ejdPNUN1eE5STUowTStn?=
 =?utf-8?B?Yk5RL1g2Zmh0Mm11d2JYZHk1RnpEQlpSSThoand6N25HUlF3czNZNFdwN1FZ?=
 =?utf-8?B?eHRPM0FFT0hYSnFtdFdKZ3Z2TjgvU0lERVU1M1U2TXdvb2dwUEl0RnNIQklP?=
 =?utf-8?B?MEhYWXRGV2ZGTWpuODRKeGc0VzZIOFk1SkJDNkJSZFk5czNzYklVelNNNUJP?=
 =?utf-8?B?ZDN6cEZ2NUpRY3F0dTN5MndzeXM0b2tGcmhEdjlsVXVhMkdOQ3ZxQm40T2FJ?=
 =?utf-8?B?UmM4TTI0L3ZScld6bmNORExuQ3U4TnBna0RQS09tRTlpRFFjTG8vRk41NFJs?=
 =?utf-8?B?bE5MWmRkdTIrTkwxNGQyeDdxeWNZbGpjWXhMUDZ2elBab0FzdXc0U0xyV3Q0?=
 =?utf-8?B?M210UnduMmdCUGE3dDBQY1l5T2dYTTJGc3JMa0kyWFZtVTRYQ1NSS3F4YTly?=
 =?utf-8?B?YlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a086c32b-9779-4275-6c3b-08dbbdf4dbb5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 18:25:56.0682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2p7rpe8j+VlROLMsl+eYC9VyLy+3fdO1Uqijffcb3zB1TTpoMe/ZZJgaqL0zwf7Wr6E/FlhEMnO2Wu0HKk+o/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4529
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 11:26:28 -0700 (PDT)


On 9/25/2023 8:45 AM, Ilpo Järvinen wrote:
> On Fri, 22 Sep 2023, Jithu Joseph wrote:
> 
>> Add an additional check to validate IFS image metadata field prior to
>> loading the test image.
>>
>> If start_chunk is not a multiple of chunks_per_stride error out.
>>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
>> ---
>>  drivers/platform/x86/intel/ifs/load.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
>> index b09106034fac..c92d313b921f 100644
>> --- a/drivers/platform/x86/intel/ifs/load.c
>> +++ b/drivers/platform/x86/intel/ifs/load.c
>> @@ -291,6 +291,13 @@ static int validate_ifs_metadata(struct device *dev)
>>  		return ret;
>>  	}
>>  
>> +	if (ifs_meta->chunks_per_stride != 0 &&
>> +	    (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride)) {
> 
> I meant that != 0 should be on the second line.
>

Ah I see ... Will change

Jithu