Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 26 Sep 2023 01:50:06 +0200
From:   Alejandro Colomar <alx@kernel.org>
To:     Axel Rasmussen <axelrasmussen@google.com>
Cc:     Peter Xu <peterx@redhat.com>, linux-man@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] ioctl_userfaultfd.2: describe missing UFFDIO_API
 feature flags
Message-ID: <4a6utza2kwlghdrgpoc2p56gfzwb4lwpp6rsqed4gaecvbfdxt@f2gw6c737te6>
References: <20230919190206.388896-1-axelrasmussen@google.com>
 <20230919190206.388896-7-axelrasmussen@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cjrue5kcslvl7m5p"
Content-Disposition: inline
In-Reply-To: <20230919190206.388896-7-axelrasmussen@google.com>
Precedence: bulk


--cjrue5kcslvl7m5p
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 06/10] ioctl_userfaultfd.2: describe missing UFFDIO_API
 feature flags
MIME-Version: 1.0

On Tue, Sep 19, 2023 at 12:02:02PM -0700, Axel Rasmussen wrote:
> Several new features have been added to the kernel recently, and the man
> page wasn't updated to describe these new features. So, add in
> descriptions of any missing features.
>=20
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---

Patch applied.

Thanks,
Alex

>  man2/ioctl_userfaultfd.2 | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>=20
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index e91a1dfc8..53b1f473f 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -204,6 +204,13 @@ If this feature bit is set,
>  .I uffd_msg.pagefault.feat.ptid
>  will be set to the faulted thread ID for each page-fault message.
>  .TP
> +.BR UFFD_FEATURE_PAGEFAULT_FLAG_WP " (since Linux 5.10)"
> +If this feature bit is set,
> +userfaultfd supports write-protect faults
> +for anonymous memory.
> +(Note that shmem / hugetlbfs support
> +is indicated by a separate feature.)
> +.TP
>  .BR UFFD_FEATURE_MINOR_HUGETLBFS " (since Linux 5.13)"
>  If this feature bit is set,
>  the kernel supports registering userfaultfd ranges
> @@ -221,6 +228,22 @@ will be set to the exact page-fault address that was=
 reported by the hardware,
>  and will not mask the offset within the page.
>  Note that old Linux versions might indicate the exact address as well,
>  even though the feature bit is not set.
> +.TP
> +.BR UFFD_FEATURE_WP_HUGETLBFS_SHMEM " (since Linux 5.19)"
> +If this feature bit is set,
> +userfaultfd supports write-protect faults
> +for hugetlbfs and shmem / tmpfs memory.
> +.TP
> +.BR UFFD_FEATURE_WP_UNPOPULATED " (since Linux 6.4)"
> +If this feature bit is set,
> +the kernel will handle anonymous memory the same way as file memory,
> +by allowing the user to write-protect unpopulated ptes.
> +.TP
> +.BR UFFD_FEATURE_POISON " (since Linux 6.6)"
> +If this feature bit is set,
> +the kernel supports resolving faults with the
> +.B UFFDIO_POISON
> +ioctl.
>  .PP
>  The returned
>  .I ioctls
> --=20
> 2.42.0.459.ge4e396fd5e-goog
>=20

--cjrue5kcslvl7m5p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUSHK4ACgkQnowa+77/
2zKijg//Y70CRLE5sfeTvnRPNP9o+9cOLE60z1NZTTXAVlvBpJM6ag1S6Hivd/lQ
KBq3W7eOZEA5k04InXcQhLaTcuf+eeBCNgRz9oIeUvuy6yNbjo47NKT/ojX381zq
j8dq6LzhPdHAJB4jmYiZJS5FAvGEOBdIzLQ0dxJPk1i2BEcLfnqOKQ0dU7g8BB6S
mpEduHSlxKciyWOQNvOcl2oMsSqFDWbICejaov8zYdruEIWXS7nSJOTI3lLlYcKF
YiHTLc0J0SAv00F3uygTRASFR9FQt3xzlY6ponV4JKp0LIxMMQz/U24mTM6p8wF2
zpdyuckSc5IUpr5z0iVbSSWRZb5fy1Ky5xZtsTXK9ghcSEiAvt73VZRbR6zvAtg4
3WWcJSgYCvBQYA+gCWBLq+3C/RER0MFO8GCv1gXSWZ4KoBQtnwS5MYJSm+sUwj1U
BXk4Bm8EUATI1VcpJmQg5bgkyKG8kLzO9L0ONYVULBYgiYceEU2yTgXlzNGHVW4A
8OWNsqoB+AmSTuUUWcQNe1cZNz3aB/SZs0J95Zi8CntwcMCqtQBkumNY1aNJC1fQ
xR9ZEHeq5PtR5jpXQYK0YovY4MO5bTCJHM9Eig+37xMOM1q2pdx9u0nWCILsfGV7
VrdWUt+3QckgLnRRnvITNa67CQ05C2wKmSaGzrnN+WeKswqfSVQ=
=u08m
-----END PGP SIGNATURE-----

--cjrue5kcslvl7m5p--