Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 25 Sep 2023 15:57:00 -0700
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Om Prakash Singh <quic_omprsing@quicinc.com>
CC:     <neil.armstrong@linaro.org>, <konrad.dybcio@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>, <conor+dt@kernel.org>,
        <davem@davemloft.net>, <devicetree@vger.kernel.org>,
        <herbert@gondor.apana.org.au>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <marijn.suijten@somainline.org>,
        <robh+dt@kernel.org>, <vkoul@kernel.org>
Subject: Re: [PATCH V3] crypto: qcom-rng - Add hw_random interface support
Message-ID: <20230925225700.GC437346@hu-bjorande-lv.qualcomm.com>
References: <20230925172312.2843262-1-quic_omprsing@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230925172312.2843262-1-quic_omprsing@quicinc.com>
Precedence: bulk

On Mon, Sep 25, 2023 at 10:53:12PM +0530, Om Prakash Singh wrote:
> From: Om Prakash Singh <omprsing@qti.qualcomm.com>

That is not a valid email address here, please correct this.

> 
> Add hw_random interface support in qcom-rng driver as new IP block
> in Qualcomm SoC has inbuilt NIST SP800 90B compliant entropic source
> to generate true random number.
> 
> Keeping current rng_alg interface as well for random number generation
> using Kernel Crypto API.
> 
> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
[..]
> diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
[..]
> +static int qcom_hwrng_read(struct hwrng *hwrng, void *data, size_t max, bool wait)
> +{
> +	struct qcom_rng *qrng =  container_of(hwrng, struct qcom_rng, hwrng);

Please also remove one of the spaces after '='.


Other than that, this looks good to me.

Regards,
Bjorn